From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"madalin.bucur@freescale.com" <madalin.bucur@freescale.com>
Cc: "scottwood@freescale.com" <scottwood@freescale.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
"ppc@mindchasers.com" <ppc@mindchasers.com>,
"roy.pledge@freescale.com" <roy.pledge@freescale.com>,
"Igal.Liberman@freescale.com" <Igal.Liberman@freescale.com>,
"pebolle@tiscali.nl" <pebolle@tiscali.nl>,
"joe@perches.com" <joe@perches.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet
Date: Tue, 3 Nov 2015 11:23:14 +0000 [thread overview]
Message-ID: <1446549794.21216.56.camel@transmode.se> (raw)
In-Reply-To: <BL2PR03MB545ED95392F5CB88EC06B11E62B0@BL2PR03MB545.namprd03.prod.outlook.com>
On Tue, 2015-11-03 at 09:37 +0000, Madalin-Cristian Bucur wrote:
> > -----Original Message-----
> > From: Joakim Tjernlund [mailto:joakim.tjernlund@transmode.se]
> >
> > On Mon, 2015-11-02 at 19:31 +0200, Madalin Bucur wrote:
> > > + if (unlikely(fd_status & FM_FD_STAT_RX_ERRORS) != 0) {
> > > + if (net_ratelimit())
> > > + netif_warn(priv, hw, net_dev, "FD status =
> > 0x%08x\n",
> > > + fd_status & FM_FD_STAT_RX_ERRORS);
> > > +
> > > + percpu_stats->rx_errors++;
> > > + goto _release_frame;
> > > + }
> >
> > I cannot find any detailed error accounting(maybe I am not looking hard
> > enough) but I
> > would appreciate if both TX and RX errors where better
> > accounted(rx_length_errors, rx_frame_errors,
> > rx_crc_errors, rx_fifo_errors etc.). This has helped me many times in the
> > past diagnosing
> > board HW problems.
> >
> > Jocke
>
> Hi Jocke,
>
> There are some error counters exported through ethtool (used to be debugfs).
> FMan HW provides more debug information than we currently export, that will be
> improved in the future but given the current priority of having a codebase as
> small and reviewable as possible we had to drop some things from the initial
> submission.
I know, but ethtool is not always available.
Even the old fec_main.c has it:
if (status & (BD_ENET_RX_LG | BD_ENET_RX_SH | BD_ENET_RX_NO |
BD_ENET_RX_CR | BD_ENET_RX_OV)) {
ndev->stats.rx_errors++;
if (status & (BD_ENET_RX_LG | BD_ENET_RX_SH)) {
/* Frame too long or too short. */
ndev->stats.rx_length_errors++;
}
if (status & BD_ENET_RX_NO) /* Frame alignment */
ndev->stats.rx_frame_errors++;
if (status & BD_ENET_RX_CR) /* CRC Error */
ndev->stats.rx_crc_errors++;
if (status & BD_ENET_RX_OV) /* FIFO overrun */
ndev->stats.rx_fifo_errors++;
}
so it is just a few more lines ... Pretty please ? :)
Jocke
next prev parent reply other threads:[~2015-11-03 11:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-02 17:31 [net-next v4 0/8] dpaa_eth: Add the Freescale DPAA Ethernet driver Madalin Bucur
2015-11-02 17:31 ` [net-next v4 1/8] devres: add devm_alloc_percpu() Madalin Bucur
2015-11-02 19:51 ` Joe Perches
2015-11-02 17:31 ` [net-next v4 2/8] dpaa_eth: add support for DPAA Ethernet Madalin Bucur
2015-11-02 19:51 ` Joe Perches
2015-11-03 7:55 ` Joakim Tjernlund
2015-11-03 9:37 ` Madalin-Cristian Bucur
2015-11-03 11:23 ` Joakim Tjernlund [this message]
2015-11-03 13:21 ` Madalin-Cristian Bucur
2015-11-11 3:35 ` Scott Wood
2015-11-02 17:31 ` [net-next v4 3/8] dpaa_eth: add support for S/G frames Madalin Bucur
2015-11-02 20:07 ` Joe Perches
2015-11-03 9:41 ` Madalin-Cristian Bucur
2015-11-02 21:03 ` Joe Perches
2015-11-02 17:31 ` [net-next v4 4/8] dpaa_eth: add driver's Tx queue selection Madalin Bucur
2015-12-02 21:40 ` Scott Wood
2015-12-03 10:02 ` Madalin-Cristian Bucur
2015-12-03 19:37 ` Scott Wood
2015-11-02 17:31 ` [net-next v4 5/8] dpaa_eth: add ethtool functionality Madalin Bucur
2015-11-02 17:31 ` [net-next v4 6/8] dpaa_eth: add ethtool statistics Madalin Bucur
2015-11-02 20:39 ` Joe Perches
2015-11-02 17:31 ` [net-next v4 7/8] dpaa_eth: add sysfs exports Madalin Bucur
2015-11-02 17:31 ` [net-next v4 8/8] dpaa_eth: add trace points Madalin Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446549794.21216.56.camel@transmode.se \
--to=joakim.tjernlund@transmode.se \
--cc=Igal.Liberman@freescale.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=madalin.bucur@freescale.com \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=ppc@mindchasers.com \
--cc=roy.pledge@freescale.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).