From: Michael Chan <mchan@broadcom.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <davem@davemloft.net>,
Eddie Wai <eddie.wai@broadcom.com>,
Jeffrey Huang <huangjw@broadcom.com>,
"Prashant Sreedharan" <prashant@broadcom.com>
Subject: Re: [PATCH] bnxt_en: add VXLAN dependency
Date: Wed, 4 Nov 2015 08:07:53 -0800 [thread overview]
Message-ID: <1446653274.3700.5.camel@LTIRV-MCHAN1.corp.ad.broadcom.com> (raw)
In-Reply-To: <10667823.xAtO4QOJMM@wuerfel>
On Wed, 2015-11-04 at 16:00 +0100, Arnd Bergmann wrote:
> VXLAN may be a loadable module, and this driver cannot be built-in
> in that case, or we get a link error:
>
> drivers/built-in.o: In function `__bnxt_open_nic':
> drivers/net/ethernet/broadcom/bnxt/bnxt.c:4581: undefined reference to `vxlan_get_rx_port'
>
> This adds a Kconfig dependency that ensures that either VXLAN is
> disabled (which the driver handles correctly), or we depend on
> VXLAN itself and disallow built-in compilation when VXLAN is
> a module.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks.
Acked-by: Michael Chan <mchan@broadcom.com>
> Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
>
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index 67a7d520d9f5..8550df189ceb 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -173,6 +173,7 @@ config SYSTEMPORT
> config BNXT
> tristate "Broadcom NetXtreme-C/E support"
> depends on PCI
> + depends on VXLAN || VXLAN=n
> select FW_LOADER
> select LIBCRC32C
> ---help---
>
next prev parent reply other threads:[~2015-11-04 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-04 15:00 [PATCH] bnxt_en: add VXLAN dependency Arnd Bergmann
2015-11-04 16:07 ` Michael Chan [this message]
2015-11-05 5:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446653274.3700.5.camel@LTIRV-MCHAN1.corp.ad.broadcom.com \
--to=mchan@broadcom.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=eddie.wai@broadcom.com \
--cc=huangjw@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).