* [PATCH] bnxt_en: add VXLAN dependency
@ 2015-11-04 15:00 Arnd Bergmann
2015-11-04 16:07 ` Michael Chan
2015-11-05 5:00 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2015-11-04 15:00 UTC (permalink / raw)
To: netdev
Cc: linux-kernel, linux-arm-kernel, davem, Eddie Wai, Jeffrey Huang,
Prashant Sreedharan, Michael Chan
VXLAN may be a loadable module, and this driver cannot be built-in
in that case, or we get a link error:
drivers/built-in.o: In function `__bnxt_open_nic':
drivers/net/ethernet/broadcom/bnxt/bnxt.c:4581: undefined reference to `vxlan_get_rx_port'
This adds a Kconfig dependency that ensures that either VXLAN is
disabled (which the driver handles correctly), or we depend on
VXLAN itself and disallow built-in compilation when VXLAN is
a module.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
index 67a7d520d9f5..8550df189ceb 100644
--- a/drivers/net/ethernet/broadcom/Kconfig
+++ b/drivers/net/ethernet/broadcom/Kconfig
@@ -173,6 +173,7 @@ config SYSTEMPORT
config BNXT
tristate "Broadcom NetXtreme-C/E support"
depends on PCI
+ depends on VXLAN || VXLAN=n
select FW_LOADER
select LIBCRC32C
---help---
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bnxt_en: add VXLAN dependency
2015-11-04 15:00 [PATCH] bnxt_en: add VXLAN dependency Arnd Bergmann
@ 2015-11-04 16:07 ` Michael Chan
2015-11-05 5:00 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Michael Chan @ 2015-11-04 16:07 UTC (permalink / raw)
To: Arnd Bergmann
Cc: netdev, linux-kernel, linux-arm-kernel, davem, Eddie Wai,
Jeffrey Huang, Prashant Sreedharan
On Wed, 2015-11-04 at 16:00 +0100, Arnd Bergmann wrote:
> VXLAN may be a loadable module, and this driver cannot be built-in
> in that case, or we get a link error:
>
> drivers/built-in.o: In function `__bnxt_open_nic':
> drivers/net/ethernet/broadcom/bnxt/bnxt.c:4581: undefined reference to `vxlan_get_rx_port'
>
> This adds a Kconfig dependency that ensures that either VXLAN is
> disabled (which the driver handles correctly), or we depend on
> VXLAN itself and disallow built-in compilation when VXLAN is
> a module.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks.
Acked-by: Michael Chan <mchan@broadcom.com>
> Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
>
> diff --git a/drivers/net/ethernet/broadcom/Kconfig b/drivers/net/ethernet/broadcom/Kconfig
> index 67a7d520d9f5..8550df189ceb 100644
> --- a/drivers/net/ethernet/broadcom/Kconfig
> +++ b/drivers/net/ethernet/broadcom/Kconfig
> @@ -173,6 +173,7 @@ config SYSTEMPORT
> config BNXT
> tristate "Broadcom NetXtreme-C/E support"
> depends on PCI
> + depends on VXLAN || VXLAN=n
> select FW_LOADER
> select LIBCRC32C
> ---help---
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bnxt_en: add VXLAN dependency
2015-11-04 15:00 [PATCH] bnxt_en: add VXLAN dependency Arnd Bergmann
2015-11-04 16:07 ` Michael Chan
@ 2015-11-05 5:00 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-11-05 5:00 UTC (permalink / raw)
To: arnd
Cc: netdev, linux-kernel, linux-arm-kernel, eddie.wai, huangjw,
prashant, mchan
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 04 Nov 2015 16:00:32 +0100
> VXLAN may be a loadable module, and this driver cannot be built-in
> in that case, or we get a link error:
>
> drivers/built-in.o: In function `__bnxt_open_nic':
> drivers/net/ethernet/broadcom/bnxt/bnxt.c:4581: undefined reference to `vxlan_get_rx_port'
>
> This adds a Kconfig dependency that ensures that either VXLAN is
> disabled (which the driver handles correctly), or we depend on
> VXLAN itself and disallow built-in compilation when VXLAN is
> a module.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c0c050c58d84 ("bnxt_en: New Broadcom ethernet driver.")
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-05 5:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-04 15:00 [PATCH] bnxt_en: add VXLAN dependency Arnd Bergmann
2015-11-04 16:07 ` Michael Chan
2015-11-05 5:00 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).