[PATCH 0/2] ACPI / scan: Fix and cleanup related to acpi_bus_get

linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 0/2] ACPI / scan: Fix and cleanup related to acpi_bus_get_device()
@ 2013-01-30 22:02 Rafael J. Wysocki
  2013-01-30 22:03 ` [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device() Rafael J. Wysocki
  2013-01-30 22:04 ` [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent() Rafael J. Wysocki
  0 siblings, 2 replies; 26+ messages in thread
From: Rafael J. Wysocki @ 2013-01-30 22:02 UTC (permalink / raw)
  To: ACPI Devel Maling List; +Cc: LKML, Mika Westerberg, Yinghai Lu, Toshi Kani

Hi All,

One fix and one cleanup related to acpi_bus_get_device() follow:

[1/2] Fix acpi_bus_get_device() check in acpi_match_device()
[2/2] Clean up acpi_bus_get_parent()

On top of linux-pm/linux-next.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device()
  2013-01-30 22:02 [PATCH 0/2] ACPI / scan: Fix and cleanup related to acpi_bus_get_device() Rafael J. Wysocki
@ 2013-01-30 22:03 ` Rafael J. Wysocki
  2013-01-31  3:04   ` Yasuaki Ishimatsu
                     ` (3 more replies)
  2013-01-30 22:04 ` [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent() Rafael J. Wysocki
  1 sibling, 4 replies; 26+ messages in thread
From: Rafael J. Wysocki @ 2013-01-30 22:03 UTC (permalink / raw)
  To: ACPI Devel Maling List; +Cc: LKML, Mika Westerberg, Yinghai Lu, Toshi Kani

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Since acpi_bus_get_device() returns int and not acpi_status, change
acpi_match_device() so that it doesn't apply ACPI_FAILURE() to the
return value of acpi_bus_get_device().

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/scan.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux-pm/drivers/acpi/scan.c
===================================================================
--- linux-pm.orig/drivers/acpi/scan.c
+++ linux-pm/drivers/acpi/scan.c
@@ -491,9 +491,9 @@ const struct acpi_device_id *acpi_match_
 					       const struct device *dev)
 {
 	struct acpi_device *adev;
+	acpi_handle handle = ACPI_HANDLE(dev);
 
-	if (!ids || !ACPI_HANDLE(dev)
-	    || ACPI_FAILURE(acpi_bus_get_device(ACPI_HANDLE(dev), &adev)))
+	if (!ids || !handle || acpi_bus_get_device(handle, &adev))
 		return NULL;
 
 	return __acpi_match_device(adev, ids);


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device()
  2013-01-30 22:03 ` [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device() Rafael J. Wysocki
@ 2013-01-31  3:04   ` Yasuaki Ishimatsu
  2013-01-31  3:12   ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-01-31  3:04 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: ACPI Devel Maling List, LKML, Mika Westerberg, Yinghai Lu, Toshi Kani

2013/01/31 7:03, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Since acpi_bus_get_device() returns int and not acpi_status, change
> acpi_match_device() so that it doesn't apply ACPI_FAILURE() to the
> return value of acpi_bus_get_device().
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---

I have no objection.
Acked-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>

>   drivers/acpi/scan.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-pm/drivers/acpi/scan.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/scan.c
> +++ linux-pm/drivers/acpi/scan.c
> @@ -491,9 +491,9 @@ const struct acpi_device_id *acpi_match_
>   					       const struct device *dev)
>   {
>   	struct acpi_device *adev;
> +	acpi_handle handle = ACPI_HANDLE(dev);
>
> -	if (!ids || !ACPI_HANDLE(dev)
> -	    || ACPI_FAILURE(acpi_bus_get_device(ACPI_HANDLE(dev), &adev)))
> +	if (!ids || !handle || acpi_bus_get_device(handle, &adev))
>   		return NULL;
>
>   	return __acpi_match_device(adev, ids);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 0/4] Fix acpi_bus_get_device() check
  2013-01-30 22:03 ` [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device() Rafael J. Wysocki
  2013-01-31  3:04   ` Yasuaki Ishimatsu
@ 2013-01-31  3:12   ` Yasuaki Ishimatsu
  2013-01-31  3:14     ` Yasuaki Ishimatsu
                       ` (3 more replies)
  2013-01-31  8:45   ` [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device() Mika Westerberg
  2013-01-31 18:38   ` Yinghai Lu
  3 siblings, 4 replies; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-01-31  3:12 UTC (permalink / raw)
  To: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani

Some functions use ACPI_SUCCESS/FAILURE for checking return value of
acpi_bus_get_device().

Following patches change not to apply ACPI_SUCCESS/FAILURE to the
return value of acpi_bus_get_device().

[PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c
[PATCH 2/4] ACPI/dock: Fix acpi_bus_get_device() check in drivers/acpi/ddock.c
[PATCH 3/4] PNPACPI: Fix acpi_bus_get_device() check in drivers/pnp/pnpacpi/core.c
[PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c

2013/01/31 7:03, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Since acpi_bus_get_device() returns int and not acpi_status, change
> acpi_match_device() so that it doesn't apply ACPI_FAILURE() to the
> return value of acpi_bus_get_device().
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>   drivers/acpi/scan.c |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-pm/drivers/acpi/scan.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/scan.c
> +++ linux-pm/drivers/acpi/scan.c
> @@ -491,9 +491,9 @@ const struct acpi_device_id *acpi_match_
>   					       const struct device *dev)
>   {
>   	struct acpi_device *adev;
> +	acpi_handle handle = ACPI_HANDLE(dev);
>
> -	if (!ids || !ACPI_HANDLE(dev)
> -	    || ACPI_FAILURE(acpi_bus_get_device(ACPI_HANDLE(dev), &adev)))
> +	if (!ids || !handle || acpi_bus_get_device(handle, &adev))
>   		return NULL;
>
>   	return __acpi_match_device(adev, ids);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 0/4] Fix acpi_bus_get_device() check
  2013-01-31  3:12   ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
@ 2013-01-31  3:14     ` Yasuaki Ishimatsu
  2013-01-31  3:22       ` [RESEND PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c Yasuaki Ishimatsu
  2013-01-31  3:15     ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
                       ` (2 subsequent siblings)
  3 siblings, 1 reply; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-01-31  3:14 UTC (permalink / raw)
  To: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani

acpi_bus_get_device() returns int not acpi_status.

The patch change not to apply ACPI_FAILURE() to the return value of
acpi_bus_get_device().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
  drivers/acpi/device_pm.c |    6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux-pm/drivers/acpi/device_pm.c
===================================================================
--- linux-pm.orig/drivers/acpi/device_pm.c	2013-01-31 11:04:30.000000000 +0900
+++ linux-pm/drivers/acpi/device_pm.c	2013-01-31 11:28:51.366849592 +0900
@@ -213,7 +213,7 @@ int acpi_pm_device_sleep_state(struct de
  	acpi_handle handle = DEVICE_ACPI_HANDLE(dev);
  	struct acpi_device *adev;
  
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &adev))) {
+	if (!handle || acpi_bus_get_device(handle, &adev)) {
  		dev_dbg(dev, "ACPI handle without context in %s!\n", __func__);
  		return -ENODEV;
  	}
@@ -290,7 +290,7 @@ int acpi_pm_device_run_wake(struct devic
  		return -EINVAL;
  
  	handle = DEVICE_ACPI_HANDLE(phys_dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &adev))) {
+	if (!handle || acpi_bus_get_device(handle, &adev)) {
  		dev_dbg(phys_dev, "ACPI handle without context in %s!\n",
  			__func__);
  		return -ENODEV;
@@ -334,7 +334,7 @@ int acpi_pm_device_sleep_wake(struct dev
  		return -EINVAL;
  
  	handle = DEVICE_ACPI_HANDLE(dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &adev))) {
+	if (!handle || acpi_bus_get_device(handle, &adev)) {
  		dev_dbg(dev, "ACPI handle without context in %s!\n", __func__);
  		return -ENODEV;
  	}


^ permalink raw reply	[flat|nested] 26+ messages in thread

* [RESEND PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c
  2013-01-31  3:14     ` Yasuaki Ishimatsu
@ 2013-01-31  3:22       ` Yasuaki Ishimatsu
  2013-01-31 20:21         ` Rafael J. Wysocki
  0 siblings, 1 reply; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-01-31  3:22 UTC (permalink / raw)
  To: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani

I fogot to change subject. So I resend a patch.

---
acpi_bus_get_device() returns int not acpi_status.

The patch change not to apply ACPI_FAILURE() to the return value of
acpi_bus_get_device().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
  drivers/acpi/device_pm.c |    6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

Index: linux-pm/drivers/acpi/device_pm.c
===================================================================
--- linux-pm.orig/drivers/acpi/device_pm.c	2013-01-31 11:04:30.000000000 +0900
+++ linux-pm/drivers/acpi/device_pm.c	2013-01-31 11:28:51.366849592 +0900
@@ -213,7 +213,7 @@ int acpi_pm_device_sleep_state(struct de
  	acpi_handle handle = DEVICE_ACPI_HANDLE(dev);
  	struct acpi_device *adev;
  
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &adev))) {
+	if (!handle || acpi_bus_get_device(handle, &adev)) {
  		dev_dbg(dev, "ACPI handle without context in %s!\n", __func__);
  		return -ENODEV;
  	}
@@ -290,7 +290,7 @@ int acpi_pm_device_run_wake(struct devic
  		return -EINVAL;
  
  	handle = DEVICE_ACPI_HANDLE(phys_dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &adev))) {
+	if (!handle || acpi_bus_get_device(handle, &adev)) {
  		dev_dbg(phys_dev, "ACPI handle without context in %s!\n",
  			__func__);
  		return -ENODEV;
@@ -334,7 +334,7 @@ int acpi_pm_device_sleep_wake(struct dev
  		return -EINVAL;
  
  	handle = DEVICE_ACPI_HANDLE(dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &adev))) {
+	if (!handle || acpi_bus_get_device(handle, &adev)) {
  		dev_dbg(dev, "ACPI handle without context in %s!\n", __func__);
  		return -ENODEV;
  	}


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [RESEND PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c
  2013-01-31  3:22       ` [RESEND PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c Yasuaki Ishimatsu
@ 2013-01-31 20:21         ` Rafael J. Wysocki
  2013-01-31 23:43           ` Yasuaki Ishimatsu
  0 siblings, 1 reply; 26+ messages in thread
From: Rafael J. Wysocki @ 2013-01-31 20:21 UTC (permalink / raw)
  To: Yasuaki Ishimatsu
  Cc: ACPI Devel Maling List, LKML, Mika Westerberg, Yinghai Lu, Toshi Kani

On Thursday, January 31, 2013 12:22:14 PM Yasuaki Ishimatsu wrote:
> I fogot to change subject. So I resend a patch.

I have applied patches [1-3/4] to my bleeding-edge branch, but please note that
something (probably your MUA) added a space in front of every line originally
starting with a space.

Thanks,
Rafael


> ---
> acpi_bus_get_device() returns int not acpi_status.
> 
> The patch change not to apply ACPI_FAILURE() to the return value of
> acpi_bus_get_device().
> 
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> ---
>   drivers/acpi/device_pm.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> Index: linux-pm/drivers/acpi/device_pm.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/device_pm.c	2013-01-31 11:04:30.000000000 +0900
> +++ linux-pm/drivers/acpi/device_pm.c	2013-01-31 11:28:51.366849592 +0900
> @@ -213,7 +213,7 @@ int acpi_pm_device_sleep_state(struct de
>   	acpi_handle handle = DEVICE_ACPI_HANDLE(dev);
>   	struct acpi_device *adev;
>   
> -	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &adev))) {
> +	if (!handle || acpi_bus_get_device(handle, &adev)) {
>   		dev_dbg(dev, "ACPI handle without context in %s!\n", __func__);
>   		return -ENODEV;
>   	}
> @@ -290,7 +290,7 @@ int acpi_pm_device_run_wake(struct devic
>   		return -EINVAL;
>   
>   	handle = DEVICE_ACPI_HANDLE(phys_dev);
> -	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &adev))) {
> +	if (!handle || acpi_bus_get_device(handle, &adev)) {
>   		dev_dbg(phys_dev, "ACPI handle without context in %s!\n",
>   			__func__);
>   		return -ENODEV;
> @@ -334,7 +334,7 @@ int acpi_pm_device_sleep_wake(struct dev
>   		return -EINVAL;
>   
>   	handle = DEVICE_ACPI_HANDLE(dev);
> -	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &adev))) {
> +	if (!handle || acpi_bus_get_device(handle, &adev)) {
>   		dev_dbg(dev, "ACPI handle without context in %s!\n", __func__);
>   		return -ENODEV;
>   	}
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [RESEND PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c
  2013-01-31 20:21         ` Rafael J. Wysocki
@ 2013-01-31 23:43           ` Yasuaki Ishimatsu
  2013-02-01 22:30             ` Rafael J. Wysocki
  0 siblings, 1 reply; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-01-31 23:43 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: ACPI Devel Maling List, LKML, Mika Westerberg, Yinghai Lu, Toshi Kani

Hi Rafael,

2013/02/01 5:21, Rafael J. Wysocki wrote:
> On Thursday, January 31, 2013 12:22:14 PM Yasuaki Ishimatsu wrote:
>> I fogot to change subject. So I resend a patch.
>
> I have applied patches [1-3/4] to my bleeding-edge branch,

Thanks.

> but please note that
> something (probably your MUA) added a space in front of every line originally
> starting with a space.

I apologize for bothering you.

Thanks,
Yasuaki Ishimatsu

>
> Thanks,
> Rafael
>
>
>> ---
>> acpi_bus_get_device() returns int not acpi_status.
>>
>> The patch change not to apply ACPI_FAILURE() to the return value of
>> acpi_bus_get_device().
>>
>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>> ---
>>    drivers/acpi/device_pm.c |    6 +++---
>>    1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> Index: linux-pm/drivers/acpi/device_pm.c
>> ===================================================================
>> --- linux-pm.orig/drivers/acpi/device_pm.c	2013-01-31 11:04:30.000000000 +0900
>> +++ linux-pm/drivers/acpi/device_pm.c	2013-01-31 11:28:51.366849592 +0900
>> @@ -213,7 +213,7 @@ int acpi_pm_device_sleep_state(struct de
>>    	acpi_handle handle = DEVICE_ACPI_HANDLE(dev);
>>    	struct acpi_device *adev;
>>
>> -	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &adev))) {
>> +	if (!handle || acpi_bus_get_device(handle, &adev)) {
>>    		dev_dbg(dev, "ACPI handle without context in %s!\n", __func__);
>>    		return -ENODEV;
>>    	}
>> @@ -290,7 +290,7 @@ int acpi_pm_device_run_wake(struct devic
>>    		return -EINVAL;
>>
>>    	handle = DEVICE_ACPI_HANDLE(phys_dev);
>> -	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &adev))) {
>> +	if (!handle || acpi_bus_get_device(handle, &adev)) {
>>    		dev_dbg(phys_dev, "ACPI handle without context in %s!\n",
>>    			__func__);
>>    		return -ENODEV;
>> @@ -334,7 +334,7 @@ int acpi_pm_device_sleep_wake(struct dev
>>    		return -EINVAL;
>>
>>    	handle = DEVICE_ACPI_HANDLE(dev);
>> -	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &adev))) {
>> +	if (!handle || acpi_bus_get_device(handle, &adev)) {
>>    		dev_dbg(dev, "ACPI handle without context in %s!\n", __func__);
>>    		return -ENODEV;
>>    	}
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html



^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [RESEND PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c
  2013-01-31 23:43           ` Yasuaki Ishimatsu
@ 2013-02-01 22:30             ` Rafael J. Wysocki
  0 siblings, 0 replies; 26+ messages in thread
From: Rafael J. Wysocki @ 2013-02-01 22:30 UTC (permalink / raw)
  To: Yasuaki Ishimatsu
  Cc: ACPI Devel Maling List, LKML, Mika Westerberg, Yinghai Lu, Toshi Kani

On Friday, February 01, 2013 08:43:09 AM Yasuaki Ishimatsu wrote:
> Hi Rafael,
> 
> 2013/02/01 5:21, Rafael J. Wysocki wrote:
> > On Thursday, January 31, 2013 12:22:14 PM Yasuaki Ishimatsu wrote:
> >> I fogot to change subject. So I resend a patch.
> >
> > I have applied patches [1-3/4] to my bleeding-edge branch,
> 
> Thanks.
> 
> > but please note that
> > something (probably your MUA) added a space in front of every line originally
> > starting with a space.
> 
> I apologize for bothering you.

No problem.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 0/4] Fix acpi_bus_get_device() check
  2013-01-31  3:12   ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
  2013-01-31  3:14     ` Yasuaki Ishimatsu
@ 2013-01-31  3:15     ` Yasuaki Ishimatsu
  2013-01-31  3:23       ` [RESEND PATCH 2/4] ACPI/dock: Fix acpi_bus_get_device() check in drivers/acpi/ddock.c Yasuaki Ishimatsu
  2013-01-31  3:16     ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
  2013-01-31  3:19     ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
  3 siblings, 1 reply; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-01-31  3:15 UTC (permalink / raw)
  To: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani

acpi_bus_get_device() returns int not acpi_status.

The patch change not to apply ACPI_SUCCESS() to the return value of
acpi_bus_get_device().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
  drivers/acpi/dock.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pm/drivers/acpi/dock.c
===================================================================
--- linux-pm.orig/drivers/acpi/dock.c	2013-01-31 11:39:40.574849906 +0900
+++ linux-pm/drivers/acpi/dock.c	2013-01-31 11:50:11.329850213 +0900
@@ -836,7 +836,7 @@ static ssize_t show_docked(struct device
  
  	struct dock_station *dock_station = dev->platform_data;
  
-	if (ACPI_SUCCESS(acpi_bus_get_device(dock_station->handle, &tmp)))
+	if (!acpi_bus_get_device(dock_station->handle, &tmp))
  		return snprintf(buf, PAGE_SIZE, "1\n");
  	return snprintf(buf, PAGE_SIZE, "0\n");
  }


^ permalink raw reply	[flat|nested] 26+ messages in thread

* [RESEND PATCH 2/4] ACPI/dock: Fix acpi_bus_get_device() check in drivers/acpi/ddock.c
  2013-01-31  3:15     ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
@ 2013-01-31  3:23       ` Yasuaki Ishimatsu
  0 siblings, 0 replies; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-01-31  3:23 UTC (permalink / raw)
  To: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani

I forgot to change subject. So I resend a patch.

---
acpi_bus_get_device() returns int not acpi_status.

The patch change not to apply ACPI_SUCCESS() to the return value of
acpi_bus_get_device().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
  drivers/acpi/dock.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pm/drivers/acpi/dock.c
===================================================================
--- linux-pm.orig/drivers/acpi/dock.c	2013-01-31 11:39:40.574849906 +0900
+++ linux-pm/drivers/acpi/dock.c	2013-01-31 11:50:11.329850213 +0900
@@ -836,7 +836,7 @@ static ssize_t show_docked(struct device
  
  	struct dock_station *dock_station = dev->platform_data;
  
-	if (ACPI_SUCCESS(acpi_bus_get_device(dock_station->handle, &tmp)))
+	if (!acpi_bus_get_device(dock_station->handle, &tmp))
  		return snprintf(buf, PAGE_SIZE, "1\n");
  	return snprintf(buf, PAGE_SIZE, "0\n");
  }


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 0/4] Fix acpi_bus_get_device() check
  2013-01-31  3:12   ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
  2013-01-31  3:14     ` Yasuaki Ishimatsu
  2013-01-31  3:15     ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
@ 2013-01-31  3:16     ` Yasuaki Ishimatsu
  2013-01-31  3:26       ` [RESEND PATCH 3/4] PNPACPI: Fix acpi_bus_get_device() check in drivers/pnp/pnpacpi/core.c Yasuaki Ishimatsu
  2013-01-31  3:19     ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
  3 siblings, 1 reply; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-01-31  3:16 UTC (permalink / raw)
  To: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani

acpi_bus_get_device() returns int not acpi_status.

The patch change not to apply ACPI_FAILURE() to the return value of
acpi_bus_get_device().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
  drivers/pnp/pnpacpi/core.c |   10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

Index: linux-pm/drivers/pnp/pnpacpi/core.c
===================================================================
--- linux-pm.orig/drivers/pnp/pnpacpi/core.c	2013-01-31 11:04:43.000000000 +0900
+++ linux-pm/drivers/pnp/pnpacpi/core.c	2013-01-31 11:38:47.659849883 +0900
@@ -90,7 +90,7 @@ static int pnpacpi_set_resources(struct
  	pnp_dbg(&dev->dev, "set resources\n");
  
  	handle = DEVICE_ACPI_HANDLE(&dev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return -ENODEV;
  	}
@@ -123,7 +123,7 @@ static int pnpacpi_disable_resources(str
  	dev_dbg(&dev->dev, "disable resources\n");
  
  	handle = DEVICE_ACPI_HANDLE(&dev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return 0;
  	}
@@ -145,7 +145,7 @@ static bool pnpacpi_can_wakeup(struct pn
  	acpi_handle handle;
  
  	handle = DEVICE_ACPI_HANDLE(&dev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return false;
  	}
@@ -160,7 +160,7 @@ static int pnpacpi_suspend(struct pnp_de
  	int error = 0;
  
  	handle = DEVICE_ACPI_HANDLE(&dev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return 0;
  	}
@@ -197,7 +197,7 @@ static int pnpacpi_resume(struct pnp_dev
  	acpi_handle handle = DEVICE_ACPI_HANDLE(&dev->dev);
  	int error = 0;
  
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return -ENODEV;
  	}


^ permalink raw reply	[flat|nested] 26+ messages in thread

* [RESEND PATCH 3/4] PNPACPI: Fix acpi_bus_get_device() check in drivers/pnp/pnpacpi/core.c
  2013-01-31  3:16     ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
@ 2013-01-31  3:26       ` Yasuaki Ishimatsu
  0 siblings, 0 replies; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-01-31  3:26 UTC (permalink / raw)
  To: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani

I forgot to chnage subject. So I resend a patch.

---
acpi_bus_get_device() returns int not acpi_status.

The patch change not to apply ACPI_FAILURE() to the return value of
acpi_bus_get_device().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
  drivers/pnp/pnpacpi/core.c |   10 +++++-----
  1 file changed, 5 insertions(+), 5 deletions(-)

Index: linux-pm/drivers/pnp/pnpacpi/core.c
===================================================================
--- linux-pm.orig/drivers/pnp/pnpacpi/core.c	2013-01-31 11:04:43.000000000 +0900
+++ linux-pm/drivers/pnp/pnpacpi/core.c	2013-01-31 11:38:47.659849883 +0900
@@ -90,7 +90,7 @@ static int pnpacpi_set_resources(struct
  	pnp_dbg(&dev->dev, "set resources\n");
  
  	handle = DEVICE_ACPI_HANDLE(&dev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return -ENODEV;
  	}
@@ -123,7 +123,7 @@ static int pnpacpi_disable_resources(str
  	dev_dbg(&dev->dev, "disable resources\n");
  
  	handle = DEVICE_ACPI_HANDLE(&dev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return 0;
  	}
@@ -145,7 +145,7 @@ static bool pnpacpi_can_wakeup(struct pn
  	acpi_handle handle;
  
  	handle = DEVICE_ACPI_HANDLE(&dev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return false;
  	}
@@ -160,7 +160,7 @@ static int pnpacpi_suspend(struct pnp_de
  	int error = 0;
  
  	handle = DEVICE_ACPI_HANDLE(&dev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return 0;
  	}
@@ -197,7 +197,7 @@ static int pnpacpi_resume(struct pnp_dev
  	acpi_handle handle = DEVICE_ACPI_HANDLE(&dev->dev);
  	int error = 0;
  
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev))) {
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev)) {
  		dev_dbg(&dev->dev, "ACPI device not found in %s!\n", __func__);
  		return -ENODEV;
  	}


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 0/4] Fix acpi_bus_get_device() check
  2013-01-31  3:12   ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
                       ` (2 preceding siblings ...)
  2013-01-31  3:16     ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
@ 2013-01-31  3:19     ` Yasuaki Ishimatsu
  2013-01-31  3:27       ` [RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c Yasuaki Ishimatsu
  3 siblings, 1 reply; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-01-31  3:19 UTC (permalink / raw)
  To: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani, daniel.vetter, airlied, dri-devel

acpi_bus_get_device() returns int not acpi_status.

The patch change not to apply ACPI_FAILURE() to the return value of
acpi_bus_get_device().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
  drivers/gpu/drm/i915/intel_opregion.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pm/drivers/gpu/drm/i915/intel_opregion.c
===================================================================
--- linux-pm.orig/drivers/gpu/drm/i915/intel_opregion.c	2013-01-31 11:39:37.075849905 +0900
+++ linux-pm/drivers/gpu/drm/i915/intel_opregion.c	2013-01-31 11:52:18.796850274 +0900
@@ -347,7 +347,7 @@ static void intel_didl_outputs(struct dr
  	int i = 0;
  
  	handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev)))
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev))
  		return;
  
  	if (acpi_is_video_device(acpi_dev))


^ permalink raw reply	[flat|nested] 26+ messages in thread

* [RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c
  2013-01-31  3:19     ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
@ 2013-01-31  3:27       ` Yasuaki Ishimatsu
  2013-01-31 10:03         ` Daniel Vetter
  0 siblings, 1 reply; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-01-31  3:27 UTC (permalink / raw)
  To: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani, daniel.vetter, airlied, dri-devel

I forgot to change subject. So I resend a patch.

---
acpi_bus_get_device() returns int not acpi_status.

The patch change not to apply ACPI_FAILURE() to the return value of
acpi_bus_get_device().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
  drivers/gpu/drm/i915/intel_opregion.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pm/drivers/gpu/drm/i915/intel_opregion.c
===================================================================
--- linux-pm.orig/drivers/gpu/drm/i915/intel_opregion.c	2013-01-31 11:39:37.075849905 +0900
+++ linux-pm/drivers/gpu/drm/i915/intel_opregion.c	2013-01-31 11:52:18.796850274 +0900
@@ -347,7 +347,7 @@ static void intel_didl_outputs(struct dr
  	int i = 0;
  
  	handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev)))
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev))
  		return;
  
  	if (acpi_is_video_device(acpi_dev))


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c
  2013-01-31  3:27       ` [RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c Yasuaki Ishimatsu
@ 2013-01-31 10:03         ` Daniel Vetter
  2013-02-01  0:50           ` [UPDATE][PATCH " Yasuaki Ishimatsu
  0 siblings, 1 reply; 26+ messages in thread
From: Daniel Vetter @ 2013-01-31 10:03 UTC (permalink / raw)
  To: Yasuaki Ishimatsu
  Cc: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani, daniel.vetter, airlied, dri-devel

On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote:
> I forgot to change subject. So I resend a patch.
> 
> ---
> acpi_bus_get_device() returns int not acpi_status.
> 
> The patch change not to apply ACPI_FAILURE() to the return value of
> acpi_bus_get_device().
> 
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>

I've tried to apply this to drm-intel-next-queued, but git am didn't
really like your patch - it failed to apply. Can you please rebase to the
drm-intel-next-queued branch from

git://people.freedesktop.org/~danvet/drm-intel

and please resubmit the patch, preferrably formatted with git
format-patch?

Thanks, Daniel

> ---
>  drivers/gpu/drm/i915/intel_opregion.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-pm/drivers/gpu/drm/i915/intel_opregion.c
> ===================================================================
> --- linux-pm.orig/drivers/gpu/drm/i915/intel_opregion.c	2013-01-31 11:39:37.075849905 +0900
> +++ linux-pm/drivers/gpu/drm/i915/intel_opregion.c	2013-01-31 11:52:18.796850274 +0900
> @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct dr
>  	int i = 0;
>  	handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev);
> -	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev)))
> +	if (!handle || acpi_bus_get_device(handle, &acpi_dev))
>  		return;
>  	if (acpi_is_video_device(acpi_dev))
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [UPDATE][PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c
  2013-01-31 10:03         ` Daniel Vetter
@ 2013-02-01  0:50           ` Yasuaki Ishimatsu
  2013-02-01  0:53             ` Yasuaki Ishimatsu
  0 siblings, 1 reply; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-02-01  0:50 UTC (permalink / raw)
  To: daniel
  Cc: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani, dri-devel

2013/01/31 19:03, Daniel Vetter wrote:
> On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote:
>> I forgot to change subject. So I resend a patch.
>>
>> ---
>> acpi_bus_get_device() returns int not acpi_status.
>>
>> The patch change not to apply ACPI_FAILURE() to the return value of
>> acpi_bus_get_device().
>>
>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>
> I've tried to apply this to drm-intel-next-queued, but git am didn't
> really like your patch - it failed to apply. Can you please rebase to the
> drm-intel-next-queued branch from
>
> git://people.freedesktop.org/~danvet/drm-intel
>
> and please resubmit the patch, preferrably formatted with git
> format-patch?

My mailer added a space in the patch. I updated the patch.
How abot it?

---
acpi_bus_get_device() returns int not acpi_status.

The patch change not to apply ACPI_FAILURE() to the return value of
acpi_bus_get_device().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
  drivers/gpu/drm/i915/intel_opregion.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index 7741c22..4d33874 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -347,7 +347,7 @@ static void intel_didl_outputs(struct drm_device *dev)
  	int i = 0;
  
  	handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev)))
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev))
  		return;
  
  	if (acpi_is_video_device(acpi_dev))


^ permalink raw reply related	[flat|nested] 26+ messages in thread

* Re: [UPDATE][PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c
  2013-02-01  0:50           ` [UPDATE][PATCH " Yasuaki Ishimatsu
@ 2013-02-01  0:53             ` Yasuaki Ishimatsu
  2013-02-01  1:14               ` Yasuaki Ishimatsu
  0 siblings, 1 reply; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-02-01  0:53 UTC (permalink / raw)
  To: daniel
  Cc: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani, dri-devel

2013/02/01 9:50, Yasuaki Ishimatsu wrote:
> 2013/01/31 19:03, Daniel Vetter wrote:
>> On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote:
>>> I forgot to change subject. So I resend a patch.
>>>
>>> ---
>>> acpi_bus_get_device() returns int not acpi_status.
>>>
>>> The patch change not to apply ACPI_FAILURE() to the return value of
>>> acpi_bus_get_device().
>>>
>>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>>
>> I've tried to apply this to drm-intel-next-queued, but git am didn't
>> really like your patch - it failed to apply. Can you please rebase to the
>> drm-intel-next-queued branch from
>>
>> git://people.freedesktop.org/~danvet/drm-intel
>>
>> and please resubmit the patch, preferrably formatted with git
>> format-patch?
>
> My mailer added a space in the patch. I updated the patch.
> How abot it?
>
> ---
> acpi_bus_get_device() returns int not acpi_status.
>
> The patch change not to apply ACPI_FAILURE() to the return value of
> acpi_bus_get_device().
>
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> ---
>   drivers/gpu/drm/i915/intel_opregion.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index 7741c22..4d33874 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct drm_device *dev)
>       int i = 0;
>
>       handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev);
> -    if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev)))
> +    if (!handle || acpi_bus_get_device(handle, &acpi_dev))
>           return;
>
>       if (acpi_is_video_device(acpi_dev))
>

Oops. My mailer added a space again...
I'll check my mailer again.

Thanks,
Yasuaki Ishimatsu

> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [UPDATE][PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c
  2013-02-01  0:53             ` Yasuaki Ishimatsu
@ 2013-02-01  1:14               ` Yasuaki Ishimatsu
  2013-02-01 10:03                 ` Daniel Vetter
  0 siblings, 1 reply; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-02-01  1:14 UTC (permalink / raw)
  To: daniel
  Cc: Rafael J. Wysocki, ACPI Devel Maling List, LKML, Mika Westerberg,
	Yinghai Lu, Toshi Kani, dri-devel

[-- Attachment #1: Type: text/plain, Size: 2509 bytes --]

2013/02/01 9:53, Yasuaki Ishimatsu wrote:
> 2013/02/01 9:50, Yasuaki Ishimatsu wrote:
>> 2013/01/31 19:03, Daniel Vetter wrote:
>>> On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote:
>>>> I forgot to change subject. So I resend a patch.
>>>>
>>>> ---
>>>> acpi_bus_get_device() returns int not acpi_status.
>>>>
>>>> The patch change not to apply ACPI_FAILURE() to the return value of
>>>> acpi_bus_get_device().
>>>>
>>>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>>>
>>> I've tried to apply this to drm-intel-next-queued, but git am didn't
>>> really like your patch - it failed to apply. Can you please rebase to the
>>> drm-intel-next-queued branch from
>>>
>>> git://people.freedesktop.org/~danvet/drm-intel
>>>
>>> and please resubmit the patch, preferrably formatted with git
>>> format-patch?
>>
>> My mailer added a space in the patch. I updated the patch.
>> How abot it?
>>
>> ---
>> acpi_bus_get_device() returns int not acpi_status.
>>
>> The patch change not to apply ACPI_FAILURE() to the return value of
>> acpi_bus_get_device().
>>
>> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
>> ---
>>   drivers/gpu/drm/i915/intel_opregion.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
>> index 7741c22..4d33874 100644
>> --- a/drivers/gpu/drm/i915/intel_opregion.c
>> +++ b/drivers/gpu/drm/i915/intel_opregion.c
>> @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct drm_device *dev)
>>       int i = 0;
>>
>>       handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev);
>> -    if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev)))
>> +    if (!handle || acpi_bus_get_device(handle, &acpi_dev))
>>           return;
>>
>>       if (acpi_is_video_device(acpi_dev))
>>
>
> Oops. My mailer added a space again...
> I'll check my mailer again.

I do not understand why space was added to the patch.
So I attached the patch. Please check it.

Thanks,
Yasuaki Ishimatsu

>
> Thanks,
> Yasuaki Ishimatsu
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


[-- Attachment #2: 0001-RESEND-PATCH-4-4-GPU-i915-Fix-acpi_bus_get_device-ch.patch --]
[-- Type: text/x-patch, Size: 841 bytes --]

acpi_bus_get_device() returns int not acpi_status.

The patch change not to apply ACPI_FAILURE() to the return value of
acpi_bus_get_device().

Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
 drivers/gpu/drm/i915/intel_opregion.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
index 7741c22..4d33874 100644
--- a/drivers/gpu/drm/i915/intel_opregion.c
+++ b/drivers/gpu/drm/i915/intel_opregion.c
@@ -347,7 +347,7 @@ static void intel_didl_outputs(struct drm_device *dev)
 	int i = 0;
 
 	handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev);
-	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev)))
+	if (!handle || acpi_bus_get_device(handle, &acpi_dev))
 		return;
 
 	if (acpi_is_video_device(acpi_dev))


^ permalink raw reply related	[flat|nested] 26+ messages in thread

* Re: [UPDATE][PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c
  2013-02-01  1:14               ` Yasuaki Ishimatsu
@ 2013-02-01 10:03                 ` Daniel Vetter
  0 siblings, 0 replies; 26+ messages in thread
From: Daniel Vetter @ 2013-02-01 10:03 UTC (permalink / raw)
  To: Yasuaki Ishimatsu
  Cc: daniel, Rafael J. Wysocki, ACPI Devel Maling List, LKML,
	Mika Westerberg, Yinghai Lu, Toshi Kani, dri-devel

On Fri, Feb 01, 2013 at 10:14:20AM +0900, Yasuaki Ishimatsu wrote:
> 2013/02/01 9:53, Yasuaki Ishimatsu wrote:
> >2013/02/01 9:50, Yasuaki Ishimatsu wrote:
> >>2013/01/31 19:03, Daniel Vetter wrote:
> >>>On Thu, Jan 31, 2013 at 12:27:26PM +0900, Yasuaki Ishimatsu wrote:
> >>>>I forgot to change subject. So I resend a patch.
> >>>>
> >>>>---
> >>>>acpi_bus_get_device() returns int not acpi_status.
> >>>>
> >>>>The patch change not to apply ACPI_FAILURE() to the return value of
> >>>>acpi_bus_get_device().
> >>>>
> >>>>Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> >>>
> >>>I've tried to apply this to drm-intel-next-queued, but git am didn't
> >>>really like your patch - it failed to apply. Can you please rebase to the
> >>>drm-intel-next-queued branch from
> >>>
> >>>git://people.freedesktop.org/~danvet/drm-intel
> >>>
> >>>and please resubmit the patch, preferrably formatted with git
> >>>format-patch?
> >>
> >>My mailer added a space in the patch. I updated the patch.
> >>How abot it?
> >>
> >>---
> >>acpi_bus_get_device() returns int not acpi_status.
> >>
> >>The patch change not to apply ACPI_FAILURE() to the return value of
> >>acpi_bus_get_device().
> >>
> >>Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> >>---
> >>  drivers/gpu/drm/i915/intel_opregion.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >>diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> >>index 7741c22..4d33874 100644
> >>--- a/drivers/gpu/drm/i915/intel_opregion.c
> >>+++ b/drivers/gpu/drm/i915/intel_opregion.c
> >>@@ -347,7 +347,7 @@ static void intel_didl_outputs(struct drm_device *dev)
> >>      int i = 0;
> >>
> >>      handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev);
> >>-    if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev)))
> >>+    if (!handle || acpi_bus_get_device(handle, &acpi_dev))
> >>          return;
> >>
> >>      if (acpi_is_video_device(acpi_dev))
> >>
> >
> >Oops. My mailer added a space again...
> >I'll check my mailer again.
> 
> I do not understand why space was added to the patch.
> So I attached the patch. Please check it.

Yeah, worked this time. Queued for -next, thanks for the patch.
-Daniel

> 
> Thanks,
> Yasuaki Ishimatsu
> 
> >
> >Thanks,
> >Yasuaki Ishimatsu
> >
> >>--
> >>To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> >>the body of a message to majordomo@vger.kernel.org
> >>More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> >
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> >the body of a message to majordomo@vger.kernel.org
> >More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

> acpi_bus_get_device() returns int not acpi_status.
> 
> The patch change not to apply ACPI_FAILURE() to the return value of
> acpi_bus_get_device().
> 
> Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
> ---
>  drivers/gpu/drm/i915/intel_opregion.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_opregion.c b/drivers/gpu/drm/i915/intel_opregion.c
> index 7741c22..4d33874 100644
> --- a/drivers/gpu/drm/i915/intel_opregion.c
> +++ b/drivers/gpu/drm/i915/intel_opregion.c
> @@ -347,7 +347,7 @@ static void intel_didl_outputs(struct drm_device *dev)
>  	int i = 0;
>  
>  	handle = DEVICE_ACPI_HANDLE(&dev->pdev->dev);
> -	if (!handle || ACPI_FAILURE(acpi_bus_get_device(handle, &acpi_dev)))
> +	if (!handle || acpi_bus_get_device(handle, &acpi_dev))
>  		return;
>  
>  	if (acpi_is_video_device(acpi_dev))
> 


-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device()
  2013-01-30 22:03 ` [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device() Rafael J. Wysocki
  2013-01-31  3:04   ` Yasuaki Ishimatsu
  2013-01-31  3:12   ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
@ 2013-01-31  8:45   ` Mika Westerberg
  2013-01-31 18:38   ` Yinghai Lu
  3 siblings, 0 replies; 26+ messages in thread
From: Mika Westerberg @ 2013-01-31  8:45 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: ACPI Devel Maling List, LKML, Yinghai Lu, Toshi Kani

On Wed, Jan 30, 2013 at 11:03:07PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Since acpi_bus_get_device() returns int and not acpi_status, change
> acpi_match_device() so that it doesn't apply ACPI_FAILURE() to the
> return value of acpi_bus_get_device().
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device()
  2013-01-30 22:03 ` [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device() Rafael J. Wysocki
                     ` (2 preceding siblings ...)
  2013-01-31  8:45   ` [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device() Mika Westerberg
@ 2013-01-31 18:38   ` Yinghai Lu
  3 siblings, 0 replies; 26+ messages in thread
From: Yinghai Lu @ 2013-01-31 18:38 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: ACPI Devel Maling List, LKML, Mika Westerberg, Toshi Kani

On Wed, Jan 30, 2013 at 2:03 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Since acpi_bus_get_device() returns int and not acpi_status, change
> acpi_match_device() so that it doesn't apply ACPI_FAILURE() to the
> return value of acpi_bus_get_device().
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/acpi/scan.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-pm/drivers/acpi/scan.c
> ===================================================================
> --- linux-pm.orig/drivers/acpi/scan.c
> +++ linux-pm/drivers/acpi/scan.c
> @@ -491,9 +491,9 @@ const struct acpi_device_id *acpi_match_
>                                                const struct device *dev)
>  {
>         struct acpi_device *adev;
> +       acpi_handle handle = ACPI_HANDLE(dev);
>
> -       if (!ids || !ACPI_HANDLE(dev)
> -           || ACPI_FAILURE(acpi_bus_get_device(ACPI_HANDLE(dev), &adev)))
> +       if (!ids || !handle || acpi_bus_get_device(handle, &adev))
>                 return NULL;
>
>         return __acpi_match_device(adev, ids);
>

Acked-by: Yinghai Lu <yinghai@kernel.org>

^ permalink raw reply	[flat|nested] 26+ messages in thread

* [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent()
  2013-01-30 22:02 [PATCH 0/2] ACPI / scan: Fix and cleanup related to acpi_bus_get_device() Rafael J. Wysocki
  2013-01-30 22:03 ` [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device() Rafael J. Wysocki
@ 2013-01-30 22:04 ` Rafael J. Wysocki
  2013-01-31  3:41   ` Yasuaki Ishimatsu
                     ` (2 more replies)
  1 sibling, 3 replies; 26+ messages in thread
From: Rafael J. Wysocki @ 2013-01-30 22:04 UTC (permalink / raw)
  To: ACPI Devel Maling List; +Cc: LKML, Mika Westerberg, Yinghai Lu, Toshi Kani

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Make acpi_bus_get_parent() more straightforward and remove an
unnecessary local variable ret from it.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/scan.c |   16 +++++-----------
 1 file changed, 5 insertions(+), 11 deletions(-)

Index: test/drivers/acpi/scan.c
===================================================================
--- test.orig/drivers/acpi/scan.c
+++ test/drivers/acpi/scan.c
@@ -871,29 +871,23 @@ EXPORT_SYMBOL(acpi_bus_unregister_driver
    -------------------------------------------------------------------------- */
 static struct acpi_device *acpi_bus_get_parent(acpi_handle handle)
 {
+	struct acpi_device *device = NULL;
 	acpi_status status;
-	int ret;
-	struct acpi_device *device;
 
 	/*
 	 * Fixed hardware devices do not appear in the namespace and do not
 	 * have handles, but we fabricate acpi_devices for them, so we have
 	 * to deal with them specially.
 	 */
-	if (handle == NULL)
+	if (!handle)
 		return acpi_root;
 
 	do {
 		status = acpi_get_parent(handle, &handle);
-		if (status == AE_NULL_ENTRY)
-			return NULL;
 		if (ACPI_FAILURE(status))
-			return acpi_root;
-
-		ret = acpi_bus_get_device(handle, &device);
-		if (ret == 0)
-			return device;
-	} while (1);
+			return status == AE_NULL_ENTRY ? NULL : acpi_root;
+	} while (acpi_bus_get_device(handle, &device));
+	return device;
 }
 
 acpi_status


^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent()
  2013-01-30 22:04 ` [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent() Rafael J. Wysocki
@ 2013-01-31  3:41   ` Yasuaki Ishimatsu
  2013-01-31  8:46   ` Mika Westerberg
  2013-01-31 18:43   ` Yinghai Lu
  2 siblings, 0 replies; 26+ messages in thread
From: Yasuaki Ishimatsu @ 2013-01-31  3:41 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: ACPI Devel Maling List, LKML, Mika Westerberg, Yinghai Lu, Toshi Kani

2013/01/31 7:04, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Make acpi_bus_get_parent() more straightforward and remove an
> unnecessary local variable ret from it.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---

Acked-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>

>   drivers/acpi/scan.c |   16 +++++-----------
>   1 file changed, 5 insertions(+), 11 deletions(-)
>
> Index: test/drivers/acpi/scan.c
> ===================================================================
> --- test.orig/drivers/acpi/scan.c
> +++ test/drivers/acpi/scan.c
> @@ -871,29 +871,23 @@ EXPORT_SYMBOL(acpi_bus_unregister_driver
>      -------------------------------------------------------------------------- */
>   static struct acpi_device *acpi_bus_get_parent(acpi_handle handle)
>   {
> +	struct acpi_device *device = NULL;
>   	acpi_status status;
> -	int ret;
> -	struct acpi_device *device;
>
>   	/*
>   	 * Fixed hardware devices do not appear in the namespace and do not
>   	 * have handles, but we fabricate acpi_devices for them, so we have
>   	 * to deal with them specially.
>   	 */
> -	if (handle == NULL)
> +	if (!handle)
>   		return acpi_root;
>
>   	do {
>   		status = acpi_get_parent(handle, &handle);
> -		if (status == AE_NULL_ENTRY)
> -			return NULL;
>   		if (ACPI_FAILURE(status))
> -			return acpi_root;
> -
> -		ret = acpi_bus_get_device(handle, &device);
> -		if (ret == 0)
> -			return device;
> -	} while (1);
> +			return status == AE_NULL_ENTRY ? NULL : acpi_root;
> +	} while (acpi_bus_get_device(handle, &device));
> +	return device;
>   }
>
>   acpi_status
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent()
  2013-01-30 22:04 ` [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent() Rafael J. Wysocki
  2013-01-31  3:41   ` Yasuaki Ishimatsu
@ 2013-01-31  8:46   ` Mika Westerberg
  2013-01-31 18:43   ` Yinghai Lu
  2 siblings, 0 replies; 26+ messages in thread
From: Mika Westerberg @ 2013-01-31  8:46 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: ACPI Devel Maling List, LKML, Yinghai Lu, Toshi Kani

On Wed, Jan 30, 2013 at 11:04:03PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Make acpi_bus_get_parent() more straightforward and remove an
> unnecessary local variable ret from it.
> 
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>

^ permalink raw reply	[flat|nested] 26+ messages in thread

* Re: [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent()
  2013-01-30 22:04 ` [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent() Rafael J. Wysocki
  2013-01-31  3:41   ` Yasuaki Ishimatsu
  2013-01-31  8:46   ` Mika Westerberg
@ 2013-01-31 18:43   ` Yinghai Lu
  2 siblings, 0 replies; 26+ messages in thread
From: Yinghai Lu @ 2013-01-31 18:43 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: ACPI Devel Maling List, LKML, Mika Westerberg, Toshi Kani

On Wed, Jan 30, 2013 at 2:04 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Make acpi_bus_get_parent() more straightforward and remove an
> unnecessary local variable ret from it.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/acpi/scan.c |   16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)
>
> Index: test/drivers/acpi/scan.c
> ===================================================================
> --- test.orig/drivers/acpi/scan.c
> +++ test/drivers/acpi/scan.c
> @@ -871,29 +871,23 @@ EXPORT_SYMBOL(acpi_bus_unregister_driver
>     -------------------------------------------------------------------------- */
>  static struct acpi_device *acpi_bus_get_parent(acpi_handle handle)
>  {
> +       struct acpi_device *device = NULL;
>         acpi_status status;
> -       int ret;
> -       struct acpi_device *device;
>
>         /*
>          * Fixed hardware devices do not appear in the namespace and do not
>          * have handles, but we fabricate acpi_devices for them, so we have
>          * to deal with them specially.
>          */
> -       if (handle == NULL)
> +       if (!handle)
>                 return acpi_root;
>
>         do {
>                 status = acpi_get_parent(handle, &handle);
> -               if (status == AE_NULL_ENTRY)
> -                       return NULL;
>                 if (ACPI_FAILURE(status))
> -                       return acpi_root;
> -
> -               ret = acpi_bus_get_device(handle, &device);
> -               if (ret == 0)
> -                       return device;
> -       } while (1);
> +                       return status == AE_NULL_ENTRY ? NULL : acpi_root;
> +       } while (acpi_bus_get_device(handle, &device));
> +       return device;
>  }

Acked-by: Yinghai Lu <yinghai@kernel.org>

>
>  acpi_status
>

^ permalink raw reply	[flat|nested] 26+ messages in thread

end of thread, other threads:[~2013-02-01 22:23 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-30 22:02 [PATCH 0/2] ACPI / scan: Fix and cleanup related to acpi_bus_get_device() Rafael J. Wysocki
2013-01-30 22:03 ` [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device() Rafael J. Wysocki
2013-01-31  3:04   ` Yasuaki Ishimatsu
2013-01-31  3:12   ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
2013-01-31  3:14     ` Yasuaki Ishimatsu
2013-01-31  3:22       ` [RESEND PATCH 1/4] ACPI/PM: Fix acpi_bus_get_device() check in drivers/acpi/device_pm.c Yasuaki Ishimatsu
2013-01-31 20:21         ` Rafael J. Wysocki
2013-01-31 23:43           ` Yasuaki Ishimatsu
2013-02-01 22:30             ` Rafael J. Wysocki
2013-01-31  3:15     ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
2013-01-31  3:23       ` [RESEND PATCH 2/4] ACPI/dock: Fix acpi_bus_get_device() check in drivers/acpi/ddock.c Yasuaki Ishimatsu
2013-01-31  3:16     ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
2013-01-31  3:26       ` [RESEND PATCH 3/4] PNPACPI: Fix acpi_bus_get_device() check in drivers/pnp/pnpacpi/core.c Yasuaki Ishimatsu
2013-01-31  3:19     ` [PATCH 0/4] Fix acpi_bus_get_device() check Yasuaki Ishimatsu
2013-01-31  3:27       ` [RESEND PATCH 4/4] GPU/i915: Fix acpi_bus_get_device() check in drivers/gpu/drm/i915/intel_opregion.c Yasuaki Ishimatsu
2013-01-31 10:03         ` Daniel Vetter
2013-02-01  0:50           ` [UPDATE][PATCH " Yasuaki Ishimatsu
2013-02-01  0:53             ` Yasuaki Ishimatsu
2013-02-01  1:14               ` Yasuaki Ishimatsu
2013-02-01 10:03                 ` Daniel Vetter
2013-01-31  8:45   ` [PATCH 1/2] ACPI / scan: Fix acpi_bus_get_device() check in acpi_match_device() Mika Westerberg
2013-01-31 18:38   ` Yinghai Lu
2013-01-30 22:04 ` [PATCH 2/2] ACPI / scan: Clean up acpi_bus_get_parent() Rafael J. Wysocki
2013-01-31  3:41   ` Yasuaki Ishimatsu
2013-01-31  8:46   ` Mika Westerberg
2013-01-31 18:43   ` Yinghai Lu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).