[PATCH] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list

[PATCH] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list

[Josh Boyer]

Like the Yoga 900 models the Lenovo Yoga 700 does not have a
hw rfkill switch, and trying to read the hw rfkill switch through the
ideapad module causes it to always reported blocking breaking wifi.

This commit adds the Lenovo Yoga 700 to the no_hw_rfkill dmi list, fixing
the wifi breakage.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1295272
Tested-by: <dinyar.rabady+spam@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
---

This applies to the for-next branch of the platform-x86-drivers tree


 drivers/platform/x86/ideapad-laptop.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index d28db0e793df..51178626305d 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -900,6 +900,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
 		},
 	},
 	{
+		.ident = "Lenogo Yoga 700",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 700"),
+		},
+	},
+	{
 		.ident = "Lenovo Yoga 900",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-- 
2.5.0

Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list

[Josh Boyer]

On Mon, Jan 18, 2016 at 2:32 PM, Josh Boyer <jwboyer@fedoraproject.org> wrote:
> Like the Yoga 900 models the Lenovo Yoga 700 does not have a
> hw rfkill switch, and trying to read the hw rfkill switch through the
> ideapad module causes it to always reported blocking breaking wifi.
>
> This commit adds the Lenovo Yoga 700 to the no_hw_rfkill dmi list, fixing
> the wifi breakage.
>
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1295272
> Tested-by: <dinyar.rabady+spam@gmail.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> ---
>
> This applies to the for-next branch of the platform-x86-drivers tree

Just another note that this is actually a new separate entry.  The
changelog and DMI information look similar to the patch that was just
merged into Linus' tree, but they are different.  This patch isn't a
resend.

josh

>
>
>  drivers/platform/x86/ideapad-laptop.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index d28db0e793df..51178626305d 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -900,6 +900,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
>                 },
>         },
>         {
> +               .ident = "Lenogo Yoga 700",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> +                       DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 700"),
> +               },
> +       },
> +       {
>                 .ident = "Lenovo Yoga 900",
>                 .matches = {
>                         DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
> --
> 2.5.0
>

Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list

[Darren Hart]

On Wed, Jan 20, 2016 at 09:18:10AM -0500, Josh Boyer wrote:
> On Mon, Jan 18, 2016 at 2:32 PM, Josh Boyer <jwboyer@fedoraproject.org> wrote:
> > Like the Yoga 900 models the Lenovo Yoga 700 does not have a
> > hw rfkill switch, and trying to read the hw rfkill switch through the
> > ideapad module causes it to always reported blocking breaking wifi.
> >
> > This commit adds the Lenovo Yoga 700 to the no_hw_rfkill dmi list, fixing
> > the wifi breakage.
> >
> > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1295272
> > Tested-by: <dinyar.rabady+spam@gmail.com>
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> > ---
> >
> > This applies to the for-next branch of the platform-x86-drivers tree
> 
> Just another note that this is actually a new separate entry.  The
> changelog and DMI information look similar to the patch that was just
> merged into Linus' tree, but they are different.  This patch isn't a
> resend.

Yup, understood - I just couldn't include it in yesterday's pull request as it
came in too late. As a DMI match, it will still make the 4.5 series.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list

[Josh Boyer]

On Wed, Jan 20, 2016 at 11:47 AM, Darren Hart <dvhart@infradead.org> wrote:
> On Wed, Jan 20, 2016 at 09:18:10AM -0500, Josh Boyer wrote:
>> On Mon, Jan 18, 2016 at 2:32 PM, Josh Boyer <jwboyer@fedoraproject.org> wrote:
>> > Like the Yoga 900 models the Lenovo Yoga 700 does not have a
>> > hw rfkill switch, and trying to read the hw rfkill switch through the
>> > ideapad module causes it to always reported blocking breaking wifi.
>> >
>> > This commit adds the Lenovo Yoga 700 to the no_hw_rfkill dmi list, fixing
>> > the wifi breakage.
>> >
>> > BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1295272
>> > Tested-by: <dinyar.rabady+spam@gmail.com>
>> > Cc: stable@vger.kernel.org
>> > Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
>> > ---
>> >
>> > This applies to the for-next branch of the platform-x86-drivers tree
>>
>> Just another note that this is actually a new separate entry.  The
>> changelog and DMI information look similar to the patch that was just
>> merged into Linus' tree, but they are different.  This patch isn't a
>> resend.
>
> Yup, understood - I just couldn't include it in yesterday's pull request as it
> came in too late. As a DMI match, it will still make the 4.5 series.

Yep, no worries.  Just wanted to make sure people didn't think it was
a duplicate.

josh

Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list

[Darren Hart]

On Mon, Jan 18, 2016 at 02:32:53PM -0500, Josh Boyer wrote:
> Like the Yoga 900 models the Lenovo Yoga 700 does not have a
> hw rfkill switch, and trying to read the hw rfkill switch through the
> ideapad module causes it to always reported blocking breaking wifi.
> 
> This commit adds the Lenovo Yoga 700 to the no_hw_rfkill dmi list, fixing
> the wifi breakage.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1295272
> Tested-by: <dinyar.rabady+spam@gmail.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>

Queued to testing, thank you.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list

[Darren Hart]

On Mon, Jan 18, 2016 at 02:32:53PM -0500, Josh Boyer wrote:
> Like the Yoga 900 models the Lenovo Yoga 700 does not have a
> hw rfkill switch, and trying to read the hw rfkill switch through the
> ideapad module causes it to always reported blocking breaking wifi.
> 
> This commit adds the Lenovo Yoga 700 to the no_hw_rfkill dmi list, fixing
> the wifi breakage.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1295272
> Tested-by: <dinyar.rabady+spam@gmail.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> ---
> 
> This applies to the for-next branch of the platform-x86-drivers tree
> 
> 
>  drivers/platform/x86/ideapad-laptop.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> index d28db0e793df..51178626305d 100644
> --- a/drivers/platform/x86/ideapad-laptop.c
> +++ b/drivers/platform/x86/ideapad-laptop.c
> @@ -900,6 +900,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
>  		},
>  	},
>  	{
> +		.ident = "Lenogo Yoga 700",

Josh,

Is this a typo? "Lenogo"? Please tell me it's a typo.... :-)

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list

[Josh Boyer]

On Sat, Jan 23, 2016 at 2:27 AM, Darren Hart <dvhart@infradead.org> wrote:
> On Mon, Jan 18, 2016 at 02:32:53PM -0500, Josh Boyer wrote:
>> Like the Yoga 900 models the Lenovo Yoga 700 does not have a
>> hw rfkill switch, and trying to read the hw rfkill switch through the
>> ideapad module causes it to always reported blocking breaking wifi.
>>
>> This commit adds the Lenovo Yoga 700 to the no_hw_rfkill dmi list, fixing
>> the wifi breakage.
>>
>> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1295272
>> Tested-by: <dinyar.rabady+spam@gmail.com>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
>> ---
>>
>> This applies to the for-next branch of the platform-x86-drivers tree
>>
>>
>>  drivers/platform/x86/ideapad-laptop.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
>> index d28db0e793df..51178626305d 100644
>> --- a/drivers/platform/x86/ideapad-laptop.c
>> +++ b/drivers/platform/x86/ideapad-laptop.c
>> @@ -900,6 +900,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
>>               },
>>       },
>>       {
>> +             .ident = "Lenogo Yoga 700",
>
> Josh,
>
> Is this a typo? "Lenogo"? Please tell me it's a typo.... :-)

Ugh, yes.  A typo.  One that apparently doesn't matter in
functionality because the tester used this exact patch and things
work, but embarrassing either way.

Do you need me to send a v2, or is that something you can fixup?

josh

[PATCH v2] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list

[Josh Boyer]

Like the Yoga 900 models the Lenovo Yoga 700 does not have a
hw rfkill switch, and trying to read the hw rfkill switch through the
ideapad module causes it to always reported blocking breaking wifi.

This commit adds the Lenovo Yoga 700 to the no_hw_rfkill dmi list, fixing
the wifi breakage.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1295272
Tested-by: <dinyar.rabady+spam@gmail.com>
Cc: stable@vger.kernel.org
Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
---

v2: Fix Lenogo typo in ident structure member

 drivers/platform/x86/ideapad-laptop.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index d28db0e793df..d78ee151c9e4 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -900,6 +900,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
 		},
 	},
 	{
+		.ident = "Lenovo Yoga 700",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
+			DMI_MATCH(DMI_PRODUCT_VERSION, "Lenovo YOGA 700"),
+		},
+	},
+	{
 		.ident = "Lenovo Yoga 900",
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"),
-- 
2.5.0

Re: [PATCH] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list

[Darren Hart]

On Sat, Jan 23, 2016 at 07:57:23AM -0500, Josh Boyer wrote:
> On Sat, Jan 23, 2016 at 2:27 AM, Darren Hart <dvhart@infradead.org> wrote:
> > On Mon, Jan 18, 2016 at 02:32:53PM -0500, Josh Boyer wrote:
> >> Like the Yoga 900 models the Lenovo Yoga 700 does not have a
> >> hw rfkill switch, and trying to read the hw rfkill switch through the
> >> ideapad module causes it to always reported blocking breaking wifi.
> >>
> >> This commit adds the Lenovo Yoga 700 to the no_hw_rfkill dmi list, fixing
> >> the wifi breakage.
> >>
> >> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1295272
> >> Tested-by: <dinyar.rabady+spam@gmail.com>
> >> Cc: stable@vger.kernel.org
> >> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
> >> ---
> >>
> >> This applies to the for-next branch of the platform-x86-drivers tree
> >>
> >>
> >>  drivers/platform/x86/ideapad-laptop.c | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>
> >> diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
> >> index d28db0e793df..51178626305d 100644
> >> --- a/drivers/platform/x86/ideapad-laptop.c
> >> +++ b/drivers/platform/x86/ideapad-laptop.c
> >> @@ -900,6 +900,13 @@ static const struct dmi_system_id no_hw_rfkill_list[] = {
> >>               },
> >>       },
> >>       {
> >> +             .ident = "Lenogo Yoga 700",
> >
> > Josh,
> >
> > Is this a typo? "Lenogo"? Please tell me it's a typo.... :-)
> 
> Ugh, yes.  A typo.  One that apparently doesn't matter in
> functionality because the tester used this exact patch and things
> work, but embarrassing either way.
> 
> Do you need me to send a v2, or is that something you can fixup?

Normally I could have just fixed it up. I had some emergency travel on Friday
until now, so couldn't get back to it. Thank you for resending.

-- 
Darren Hart
Intel Open Source Technology Center

Re: [PATCH v2] ideapad-laptop: Add Lenovo Yoga 700 to no_hw_rfkill dmi list

[Darren Hart]

On Sun, Jan 24, 2016 at 10:46:42AM -0500, Josh Boyer wrote:
> Like the Yoga 900 models the Lenovo Yoga 700 does not have a
> hw rfkill switch, and trying to read the hw rfkill switch through the
> ideapad module causes it to always reported blocking breaking wifi.
> 
> This commit adds the Lenovo Yoga 700 to the no_hw_rfkill dmi list, fixing
> the wifi breakage.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1295272
> Tested-by: <dinyar.rabady+spam@gmail.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>

Queued, thank you Josh.

-- 
Darren Hart
Intel Open Source Technology Center