* [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.
@ 2016-02-18 1:06 Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
` (6 more replies)
0 siblings, 7 replies; 19+ messages in thread
From: Zhao Qiang @ 2016-02-18 1:06 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, linux-kernel, devicetree, linuxppc-dev, Zhao Qiang
Add IC, SI and SIRAM document of QE to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- Add interrupt-controller in Required properties
- delete address-cells and size-cells for qe-si and qe-siram
.../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 ++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
index 4f89302..84052a7 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
@@ -69,6 +69,56 @@ Example:
};
};
+* Interrupt Controller (IC)
+
+Required properties:
+- compatible : should be "fsl,qe-ic".
+- reg : Address range of IC register set.
+- interrupts : interrupts generated by the device.
+- interrupt-controller : this device is a interrupt controller.
+
+Example:
+
+ qeic: interrupt-controller@80 {
+ interrupt-controller;
+ compatible = "fsl,qe-ic";
+ #address-cells = <0>;
+ #interrupt-cells = <1>;
+ reg = <0x80 0x80>;
+ interrupts = <95 2 0 0 94 2 0 0>; //high:79 low:78
+ };
+
+* Serial Interface Block (SI)
+
+The SI manages the routing of eight TDM lines to the QE block serial drivers
+, the MCC and the UCCs, for receive and transmit.
+
+Required properties:
+- compatible : should be "fsl,qe-si".
+- reg : Address range of SI register set.
+
+Example:
+
+ si1: si@700 {
+ compatible = "fsl,qe-si";
+ reg = <0x700 0x80>;
+ };
+
+* Serial Interface Block RAM(SIRAM)
+
+store the routing entries of SI
+
+Required properties:
+- compatible : should be "fsl,qe-siram".
+- reg : Address range of SI RAM.
+
+Example:
+
+ siram1: siram@1000 {
+ compatible = "fsl,qe-siram";
+ reg = <0x1000 0x800>;
+ };
+
* QE Firmware Node
This node defines a firmware binary that is embedded in the device tree, for
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v2 2/7] QE: Add ucc hdlc document to bindings
2016-02-18 1:06 [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
@ 2016-02-18 1:06 ` Zhao Qiang
2016-02-23 20:21 ` Rob Herring
2016-02-18 1:06 ` [PATCH v2 3/7] QE: Add uqe_serial " Zhao Qiang
` (5 subsequent siblings)
6 siblings, 1 reply; 19+ messages in thread
From: Zhao Qiang @ 2016-02-18 1:06 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, linux-kernel, devicetree, linuxppc-dev, Zhao Qiang
Add ucc hdlc document to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- use ucc-hdlc instead of ucc_hdlc
- add more information to properties.
.../bindings/powerpc/fsl/cpm_qe/network.txt | 93 ++++++++++++++++++++++
1 file changed, 93 insertions(+)
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
index 29b28b8..936158c 100644
--- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
+++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
@@ -41,3 +41,96 @@ Example:
fsl,mdio-pin = <12>;
fsl,mdc-pin = <13>;
};
+
+* HDLC
+
+Currently defined compatibles:
+- fsl,ucc-hdlc
+
+Properties for fsl,ucc-hdlc:
+- rx-clock-name
+- tx-clock-name
+ Usage: required
+ Value type: <string>
+ Definition : should be "brg1"-"brg16" for internal clock source,
+ should be "clk1"-"clk28" for external clock source.
+
+- fsl,rx-sync-clock
+ Usage: required
+ Value type: <string>
+ Definition : should be "none" when using internal clock source,
+ should be "rsync_pin" when using external clock source.
+
+- fsl,tx-sync-clock
+ Usage: required
+ Value type: <string>
+ Definition : should be "none" when using internal clock source,
+ should be "tsync_pin" when using external clock source.
+
+- fsl,tx-timeslot
+- fsl,rx-timeslot
+ Usage: required
+ Value type: <u32>
+ Definition : time slot for TDM operation. Indicates which time slots
+ used for transmitting and receiving.
+
+- fsl,tdm-framer-type
+ Usage: required
+ Value type: <string>
+ Definition : "e1" or "t1"
+
+- fsl,tdm-mode
+ Usage: required
+ Value type: <string>
+ Definition : "normal" or "internal-loopback"
+
+- fsl,tdm-id
+ Usage: required
+ Value type: <u32>
+ Definition : number of TDM ID
+
+- fsl,siram-entry-id
+ Usage: required
+ Value type: <u32>
+ Definition : should be 0,2,4...64. the number of TDM entry.
+
+- fsl,tdm-interface
+ Usage: optional
+ Value type: <empty>
+ Definition : Specify that hdlc is based on tdm-interface
+
+Example:
+
+ ucc@2000 {
+ compatible = "fsl,ucc-hdlc";
+ rx-clock-name = "clk8";
+ tx-clock-name = "clk9";
+ fsl,rx-sync-clock = "rsync_pin";
+ fsl,tx-sync-clock = "tsync_pin";
+ fsl,tx-timeslot = <0xfffffffe>;
+ fsl,rx-timeslot = <0xfffffffe>;
+ fsl,tdm-framer-type = "e1";
+ fsl,tdm-mode = "normal";
+ fsl,tdm-id = <0>;
+ fsl,siram-entry-id = <0>;
+ fsl,tdm-interface;
+ };
+fsl,siram-entry-id : SI RAM entry ID for the TDM
+fsl,tdm-interface : hdlc is based on tdm-interface
+
+Example:
+
+ ucc@2000 {
+ compatible = "fsl,ucc-hdlc";
+ rx-clock-name = "clk8";
+ tx-clock-name = "clk9";
+ fsl,rx-sync-clock = "rsync_pin";
+ fsl,tx-sync-clock = "tsync_pin";
+ fsl,tx-timeslot = <0xfffffffe>;
+ fsl,rx-timeslot = <0xfffffffe>;
+ fsl,tdm-framer-type = "e1";
+ fsl,tdm-mode = "normal";
+ fsl,tdm-id = <0>;
+ fsl,siram-entry-id = <0>;
+ fsl,tdm-interface;
+ };
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v2 3/7] QE: Add uqe_serial document to bindings
2016-02-18 1:06 [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
@ 2016-02-18 1:06 ` Zhao Qiang
2016-02-23 20:23 ` Rob Herring
2016-02-18 1:06 ` [PATCH v2 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl Zhao Qiang
` (4 subsequent siblings)
6 siblings, 1 reply; 19+ messages in thread
From: Zhao Qiang @ 2016-02-18 1:06 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, linux-kernel, devicetree, linuxppc-dev, Zhao Qiang
Add uqe_serial document to
Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- modify tx/rx-clock-name specification
.../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
new file mode 100644
index 0000000..436c71c
--- /dev/null
+++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
@@ -0,0 +1,19 @@
+* Serial
+
+Currently defined compatibles:
+- ucc_uart
+
+Properties for ucc_uart:
+port-number : port number of UCC-UART
+tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source,
+ should be "clk1"-"clk28" for external clock source.
+
+Example:
+
+ ucc_serial: ucc@2200 {
+ device_type = "serial";
+ compatible = "ucc_uart";
+ port-number = <1>;
+ rx-clock-name = "brg2";
+ tx-clock-name = "brg2";
+ };
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v2 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl
2016-02-18 1:06 [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 3/7] QE: Add uqe_serial " Zhao Qiang
@ 2016-02-18 1:06 ` Zhao Qiang
2016-02-23 20:24 ` Rob Herring
2016-02-18 1:06 ` [PATCH v2 5/7] T104xD4RDB: Add qe node to t104xd4rdb Zhao Qiang
` (3 subsequent siblings)
6 siblings, 1 reply; 19+ messages in thread
From: Zhao Qiang @ 2016-02-18 1:06 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, linux-kernel, devicetree, linuxppc-dev, Zhao Qiang
cpm_qe is supported on both powerpc and arm.
and the QE code has been moved from arch/powerpc into
drivers/soc/fsl, so move cpm_qe binding from powerpc/fsl
to soc/fsl
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- new added
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/brg.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/i2c.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/pic.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/usb.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/gpio.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/network.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe.txt | 0
.../devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/firmware.txt | 0
.../devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/par_io.txt | 0
.../devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/pincfg.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/ucc.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/usb.txt | 0
Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/serial.txt | 0
.../devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/uqe_serial.txt | 0
15 files changed, 0 insertions(+), 0 deletions(-)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/brg.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/i2c.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/pic.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/usb.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/gpio.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/network.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/firmware.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/par_io.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/pincfg.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/ucc.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/usb.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/serial.txt (100%)
rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/uqe_serial.txt (100%)
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/brg.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/brg.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/brg.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/brg.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/i2c.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/i2c.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/i2c.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/i2c.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/pic.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/pic.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/pic.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/pic.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/usb.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/usb.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/cpm/usb.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/cpm/usb.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/gpio.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/gpio.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/gpio.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/gpio.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/network.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/network.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/firmware.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/firmware.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/firmware.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/firmware.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/par_io.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/par_io.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/par_io.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/pincfg.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/pincfg.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/pincfg.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/pincfg.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/ucc.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/ucc.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/ucc.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/ucc.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/usb.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/usb.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/usb.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/qe/usb.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/serial.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/serial.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/serial.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/serial.txt
diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/uqe_serial.txt
similarity index 100%
rename from Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
rename to Documentation/devicetree/bindings/soc/fsl/cpm_qe/uqe_serial.txt
--
2.1.0.27.g96db324
^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH v2 5/7] T104xD4RDB: Add qe node to t104xd4rdb
2016-02-18 1:06 [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
` (2 preceding siblings ...)
2016-02-18 1:06 ` [PATCH v2 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl Zhao Qiang
@ 2016-02-18 1:06 ` Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 6/7] T104xRDB: Add qe node to t104xrdb Zhao Qiang
` (2 subsequent siblings)
6 siblings, 0 replies; 19+ messages in thread
From: Zhao Qiang @ 2016-02-18 1:06 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, linux-kernel, devicetree, linuxppc-dev, Zhao Qiang
add qe node to t104xd4rdb.dtsi and t1040si-post.dtsi.
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- rebase
arch/powerpc/boot/dts/fsl/t1040si-post.dtsi | 45 +++++++++++++++++++++++++++++
arch/powerpc/boot/dts/fsl/t104xd4rdb.dtsi | 40 +++++++++++++++++++++++++
2 files changed, 85 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
index e0f4da5..012f813 100644
--- a/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t1040si-post.dtsi
@@ -673,3 +673,48 @@
};
};
};
+
+&qe {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ device_type = "qe";
+ compatible = "fsl,qe";
+ fsl,qe-num-riscs = <1>;
+ fsl,qe-num-snums = <28>;
+
+ qeic: interrupt-controller@80 {
+ interrupt-controller;
+ compatible = "fsl,qe-ic";
+ #address-cells = <0>;
+ #interrupt-cells = <1>;
+ reg = <0x80 0x80>;
+ interrupts = <95 2 0 0 94 2 0 0>; //high:79 low:78
+ };
+
+ ucc@2000 {
+ cell-index = <1>;
+ reg = <0x2000 0x200>;
+ interrupts = <32>;
+ interrupt-parent = <&qeic>;
+ };
+
+ ucc@2200 {
+ cell-index = <3>;
+ reg = <0x2200 0x200>;
+ interrupts = <34>;
+ interrupt-parent = <&qeic>;
+ };
+
+ muram@10000 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "fsl,qe-muram", "fsl,cpm-muram";
+ ranges = <0x0 0x10000 0x6000>;
+
+ data-only@0 {
+ compatible = "fsl,qe-muram-data",
+ "fsl,cpm-muram-data";
+ reg = <0x0 0x6000>;
+ };
+ };
+};
diff --git a/arch/powerpc/boot/dts/fsl/t104xd4rdb.dtsi b/arch/powerpc/boot/dts/fsl/t104xd4rdb.dtsi
index 3f6d7c6..2e24322 100644
--- a/arch/powerpc/boot/dts/fsl/t104xd4rdb.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t104xd4rdb.dtsi
@@ -212,4 +212,44 @@
0 0x00010000>;
};
};
+
+ qe: qe@ffe140000 {
+ ranges = <0x0 0xf 0xfe140000 0x40000>;
+ reg = <0xf 0xfe140000 0 0x480>;
+ brg-frequency = <0>;
+ bus-frequency = <0>;
+
+ si1: si@700 {
+ compatible = "fsl,qe-si";
+ reg = <0x700 0x80>;
+ };
+
+ siram1: siram@1000 {
+ compatible = "fsl,qe-siram";
+ reg = <0x1000 0x800>;
+ };
+
+ ucc_hdlc: ucc@2000 {
+ compatible = "fsl,ucc-hdlc";
+ rx-clock-name = "clk8";
+ tx-clock-name = "clk9";
+ fsl,rx-sync-clock = "rsync_pin";
+ fsl,tx-sync-clock = "tsync_pin";
+ fsl,tx-timeslot = <0xfffffffe>;
+ fsl,rx-timeslot = <0xfffffffe>;
+ fsl,tdm-framer-type = "e1";
+ fsl,tdm-mode = "normal";
+ fsl,tdm-id = <0>;
+ fsl,siram-entry-id = <0>;
+ fsl,tdm-interface;
+ };
+
+ ucc_serial: ucc@2200 {
+ device_type = "serial";
+ compatible = "ucc_uart";
+ port-number = <1>;
+ rx-clock-name = "brg2";
+ tx-clock-name = "brg2";
+ };
+ };
};
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v2 6/7] T104xRDB: Add qe node to t104xrdb
2016-02-18 1:06 [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
` (3 preceding siblings ...)
2016-02-18 1:06 ` [PATCH v2 5/7] T104xD4RDB: Add qe node to t104xd4rdb Zhao Qiang
@ 2016-02-18 1:06 ` Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 7/7] T104xQDS: Add qe node to t104xqds Zhao Qiang
2016-02-23 20:15 ` [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Rob Herring
6 siblings, 0 replies; 19+ messages in thread
From: Zhao Qiang @ 2016-02-18 1:06 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, linux-kernel, devicetree, linuxppc-dev, Zhao Qiang
add qe node to t104xrdb.dtsi
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- rebase
arch/powerpc/boot/dts/fsl/t104xrdb.dtsi | 40 +++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi b/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
index 830ea48..3b08601 100644
--- a/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t104xrdb.dtsi
@@ -186,4 +186,44 @@
0 0x00010000>;
};
};
+
+ qe: qe@ffe140000 {
+ ranges = <0x0 0xf 0xfe140000 0x40000>;
+ reg = <0xf 0xfe140000 0 0x480>;
+ brg-frequency = <0>;
+ bus-frequency = <0>;
+
+ si1: si@700 {
+ compatible = "fsl,qe-si";
+ reg = <0x700 0x80>;
+ };
+
+ siram1: siram@1000 {
+ compatible = "fsl,qe-siram";
+ reg = <0x1000 0x800>;
+ };
+
+ ucc_hdlc: ucc@2000 {
+ compatible = "fsl,ucc-hdlc";
+ rx-clock-name = "clk8";
+ tx-clock-name = "clk9";
+ fsl,rx-sync-clock = "rsync_pin";
+ fsl,tx-sync-clock = "tsync_pin";
+ fsl,tx-timeslot = <0xfffffffe>;
+ fsl,rx-timeslot = <0xfffffffe>;
+ fsl,tdm-framer-type = "e1";
+ fsl,tdm-mode = "normal";
+ fsl,tdm-id = <0>;
+ fsl,siram-entry-id = <0>;
+ fsl,tdm-interface;
+ };
+
+ ucc_serial: ucc@2200 {
+ device_type = "serial";
+ compatible = "ucc_uart";
+ port-number = <1>;
+ rx-clock-name = "brg2";
+ tx-clock-name = "brg2";
+ };
+ };
};
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH v2 7/7] T104xQDS: Add qe node to t104xqds
2016-02-18 1:06 [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
` (4 preceding siblings ...)
2016-02-18 1:06 ` [PATCH v2 6/7] T104xRDB: Add qe node to t104xrdb Zhao Qiang
@ 2016-02-18 1:06 ` Zhao Qiang
2016-02-23 20:15 ` [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Rob Herring
6 siblings, 0 replies; 19+ messages in thread
From: Zhao Qiang @ 2016-02-18 1:06 UTC (permalink / raw)
To: robh+dt
Cc: oss, leoyang.li, linux-kernel, devicetree, linuxppc-dev, Zhao Qiang
add qe node to t104xqds.dtsi
Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
---
Changes for v2
- rebase
arch/powerpc/boot/dts/fsl/t104xqds.dtsi | 40 +++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
diff --git a/arch/powerpc/boot/dts/fsl/t104xqds.dtsi b/arch/powerpc/boot/dts/fsl/t104xqds.dtsi
index 1498d1e..1a8e60d 100644
--- a/arch/powerpc/boot/dts/fsl/t104xqds.dtsi
+++ b/arch/powerpc/boot/dts/fsl/t104xqds.dtsi
@@ -190,4 +190,44 @@
0 0x00010000>;
};
};
+
+ qe: qe@ffe140000 {
+ ranges = <0x0 0xf 0xfe140000 0x40000>;
+ reg = <0xf 0xfe140000 0 0x480>;
+ brg-frequency = <0>;
+ bus-frequency = <0>;
+
+ si1: si@700 {
+ compatible = "fsl,qe-si";
+ reg = <0x700 0x80>;
+ };
+
+ siram1: siram@1000 {
+ compatible = "fsl,qe-siram";
+ reg = <0x1000 0x800>;
+ };
+
+ ucc_hdlc: ucc@2000 {
+ compatible = "fsl,ucc-hdlc";
+ rx-clock-name = "clk8";
+ tx-clock-name = "clk9";
+ fsl,rx-sync-clock = "rsync_pin";
+ fsl,tx-sync-clock = "tsync_pin";
+ fsl,tx-timeslot = <0xfffffffe>;
+ fsl,rx-timeslot = <0xfffffffe>;
+ fsl,tdm-framer-type = "e1";
+ fsl,tdm-mode = "normal";
+ fsl,tdm-id = <0>;
+ fsl,siram-entry-id = <0>;
+ fsl,tdm-interface;
+ };
+
+ ucc_serial: ucc@2200 {
+ device_type = "serial";
+ compatible = "ucc_uart";
+ port-number = <1>;
+ rx-clock-name = "brg2";
+ tx-clock-name = "brg2";
+ };
+ };
};
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 19+ messages in thread
* Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.
2016-02-18 1:06 [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
` (5 preceding siblings ...)
2016-02-18 1:06 ` [PATCH v2 7/7] T104xQDS: Add qe node to t104xqds Zhao Qiang
@ 2016-02-23 20:15 ` Rob Herring
2016-02-23 20:20 ` Scott Wood
6 siblings, 1 reply; 19+ messages in thread
From: Rob Herring @ 2016-02-23 20:15 UTC (permalink / raw)
To: Zhao Qiang; +Cc: oss, leoyang.li, linux-kernel, devicetree, linuxppc-dev
On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> Add IC, SI and SIRAM document of QE to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2
> - Add interrupt-controller in Required properties
> - delete address-cells and size-cells for qe-si and qe-siram
>
> .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50 ++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> index 4f89302..84052a7 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> @@ -69,6 +69,56 @@ Example:
> };
> };
>
> +* Interrupt Controller (IC)
> +
> +Required properties:
> +- compatible : should be "fsl,qe-ic".
> +- compatible : should be "fsl,qe-si".
> +- compatible : should be "fsl,qe-siram".
These compatible strings are all a bit generic and should have SoC
specific compatible strings.
Rob
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.
2016-02-23 20:15 ` [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Rob Herring
@ 2016-02-23 20:20 ` Scott Wood
2016-02-25 3:10 ` Qiang Zhao
0 siblings, 1 reply; 19+ messages in thread
From: Scott Wood @ 2016-02-23 20:20 UTC (permalink / raw)
To: Rob Herring, Zhao Qiang
Cc: leoyang.li, linux-kernel, devicetree, linuxppc-dev
On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
> On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> > Add IC, SI and SIRAM document of QE to
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> >
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> > Changes for v2
> > - Add interrupt-controller in Required properties
> > - delete address-cells and size-cells for qe-si and qe-siram
> >
> > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50
> > ++++++++++++++++++++++
> > 1 file changed, 50 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > index 4f89302..84052a7 100644
> > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > @@ -69,6 +69,56 @@ Example:
> > };
> > };
> >
> > +* Interrupt Controller (IC)
> > +
> > +Required properties:
> > +- compatible : should be "fsl,qe-ic".
>
> > +- compatible : should be "fsl,qe-si".
>
> > +- compatible : should be "fsl,qe-siram".
>
> These compatible strings are all a bit generic and should have SoC
> specific compatible strings.
I don't know about si/siram, but "fsl,qe-ic" has been around since 2008, so it
should be documented even if a more specific compatible is also added.
-Scott
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 2/7] QE: Add ucc hdlc document to bindings
2016-02-18 1:06 ` [PATCH v2 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
@ 2016-02-23 20:21 ` Rob Herring
2016-02-25 4:37 ` Qiang Zhao
0 siblings, 1 reply; 19+ messages in thread
From: Rob Herring @ 2016-02-23 20:21 UTC (permalink / raw)
To: Zhao Qiang; +Cc: oss, leoyang.li, linux-kernel, devicetree, linuxppc-dev
On Thu, Feb 18, 2016 at 09:06:07AM +0800, Zhao Qiang wrote:
> Add ucc hdlc document to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
Not a very useful description.
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2
> - use ucc-hdlc instead of ucc_hdlc
> - add more information to properties.
>
> .../bindings/powerpc/fsl/cpm_qe/network.txt | 93 ++++++++++++++++++++++
> 1 file changed, 93 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
> index 29b28b8..936158c 100644
> --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
> @@ -41,3 +41,96 @@ Example:
> fsl,mdio-pin = <12>;
> fsl,mdc-pin = <13>;
> };
> +
> +* HDLC
> +
> +Currently defined compatibles:
> +- fsl,ucc-hdlc
> +
> +Properties for fsl,ucc-hdlc:
> +- rx-clock-name
> +- tx-clock-name
> + Usage: required
> + Value type: <string>
> + Definition : should be "brg1"-"brg16" for internal clock source,
> + should be "clk1"-"clk28" for external clock source.
> +
> +- fsl,rx-sync-clock
> + Usage: required
> + Value type: <string>
> + Definition : should be "none" when using internal clock source,
> + should be "rsync_pin" when using external clock source.
Why not a boolean property here?
> +
> +- fsl,tx-sync-clock
> + Usage: required
> + Value type: <string>
> + Definition : should be "none" when using internal clock source,
> + should be "tsync_pin" when using external clock source.
And here.
> +
> +- fsl,tx-timeslot
> +- fsl,rx-timeslot
Perhaps append "-mask"
> + Usage: required
> + Value type: <u32>
> + Definition : time slot for TDM operation. Indicates which time slots
> + used for transmitting and receiving.
> +
> +- fsl,tdm-framer-type
> + Usage: required
> + Value type: <string>
> + Definition : "e1" or "t1"
Boolean?
> +
> +- fsl,tdm-mode
> + Usage: required
> + Value type: <string>
> + Definition : "normal" or "internal-loopback"
Boolean?
> +
> +- fsl,tdm-id
> + Usage: required
> + Value type: <u32>
> + Definition : number of TDM ID
> +
> +- fsl,siram-entry-id
> + Usage: required
> + Value type: <u32>
> + Definition : should be 0,2,4...64. the number of TDM entry.
> +
> +- fsl,tdm-interface
> + Usage: optional
> + Value type: <empty>
> + Definition : Specify that hdlc is based on tdm-interface
> +
> +Example:
> +
> + ucc@2000 {
> + compatible = "fsl,ucc-hdlc";
> + rx-clock-name = "clk8";
> + tx-clock-name = "clk9";
> + fsl,rx-sync-clock = "rsync_pin";
> + fsl,tx-sync-clock = "tsync_pin";
> + fsl,tx-timeslot = <0xfffffffe>;
> + fsl,rx-timeslot = <0xfffffffe>;
> + fsl,tdm-framer-type = "e1";
> + fsl,tdm-mode = "normal";
> + fsl,tdm-id = <0>;
> + fsl,siram-entry-id = <0>;
> + fsl,tdm-interface;
> + };
> +fsl,siram-entry-id : SI RAM entry ID for the TDM
> +fsl,tdm-interface : hdlc is based on tdm-interface
Should be deleted?
> +
> +Example:
> +
> + ucc@2000 {
> + compatible = "fsl,ucc-hdlc";
> + rx-clock-name = "clk8";
> + tx-clock-name = "clk9";
> + fsl,rx-sync-clock = "rsync_pin";
> + fsl,tx-sync-clock = "tsync_pin";
> + fsl,tx-timeslot = <0xfffffffe>;
> + fsl,rx-timeslot = <0xfffffffe>;
> + fsl,tdm-framer-type = "e1";
> + fsl,tdm-mode = "normal";
> + fsl,tdm-id = <0>;
> + fsl,siram-entry-id = <0>;
> + fsl,tdm-interface;
> + };
> --
> 2.1.0.27.g96db324
>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 3/7] QE: Add uqe_serial document to bindings
2016-02-18 1:06 ` [PATCH v2 3/7] QE: Add uqe_serial " Zhao Qiang
@ 2016-02-23 20:23 ` Rob Herring
2016-02-23 20:27 ` Scott Wood
2016-02-25 4:44 ` Qiang Zhao
0 siblings, 2 replies; 19+ messages in thread
From: Rob Herring @ 2016-02-23 20:23 UTC (permalink / raw)
To: Zhao Qiang; +Cc: oss, leoyang.li, linux-kernel, devicetree, linuxppc-dev
On Thu, Feb 18, 2016 at 09:06:08AM +0800, Zhao Qiang wrote:
> Add uqe_serial document to
> Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2
> - modify tx/rx-clock-name specification
>
> .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
>
> diff --git a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> new file mode 100644
> index 0000000..436c71c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> @@ -0,0 +1,19 @@
> +* Serial
> +
> +Currently defined compatibles:
> +- ucc_uart
> +
> +Properties for ucc_uart:
> +port-number : port number of UCC-UART
How is this used?
> +tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source,
> + should be "clk1"-"clk28" for external clock source.
Perhaps you should be using the clock binding here and in other
bindings?
> +
> +Example:
> +
> + ucc_serial: ucc@2200 {
> + device_type = "serial";
> + compatible = "ucc_uart";
> + port-number = <1>;
> + rx-clock-name = "brg2";
> + tx-clock-name = "brg2";
> + };
> --
> 2.1.0.27.g96db324
>
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl
2016-02-18 1:06 ` [PATCH v2 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl Zhao Qiang
@ 2016-02-23 20:24 ` Rob Herring
0 siblings, 0 replies; 19+ messages in thread
From: Rob Herring @ 2016-02-23 20:24 UTC (permalink / raw)
To: Zhao Qiang; +Cc: oss, leoyang.li, linux-kernel, devicetree, linuxppc-dev
On Thu, Feb 18, 2016 at 09:06:09AM +0800, Zhao Qiang wrote:
> cpm_qe is supported on both powerpc and arm.
> and the QE code has been moved from arch/powerpc into
> drivers/soc/fsl, so move cpm_qe binding from powerpc/fsl
> to soc/fsl
>
> Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> ---
> Changes for v2
> - new added
>
> Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm.txt | 0
> Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/brg.txt | 0
> Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/i2c.txt | 0
> Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/pic.txt | 0
> Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/usb.txt | 0
> Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/gpio.txt | 0
> Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/network.txt | 0
> Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe.txt | 0
> .../devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/firmware.txt | 0
> .../devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/par_io.txt | 0
> .../devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/pincfg.txt | 0
> Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/ucc.txt | 0
> Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/usb.txt | 0
> Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/serial.txt | 0
> .../devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/uqe_serial.txt | 0
> 15 files changed, 0 insertions(+), 0 deletions(-)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/brg.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/i2c.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/pic.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/cpm/usb.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/gpio.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/network.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/firmware.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/par_io.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/pincfg.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/ucc.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/qe/usb.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/serial.txt (100%)
> rename Documentation/devicetree/bindings/{powerpc => soc}/fsl/cpm_qe/uqe_serial.txt (100%)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 3/7] QE: Add uqe_serial document to bindings
2016-02-23 20:23 ` Rob Herring
@ 2016-02-23 20:27 ` Scott Wood
2016-02-25 4:44 ` Qiang Zhao
1 sibling, 0 replies; 19+ messages in thread
From: Scott Wood @ 2016-02-23 20:27 UTC (permalink / raw)
To: Rob Herring, Zhao Qiang
Cc: leoyang.li, linux-kernel, devicetree, linuxppc-dev
On Tue, 2016-02-23 at 14:23 -0600, Rob Herring wrote:
> On Thu, Feb 18, 2016 at 09:06:08AM +0800, Zhao Qiang wrote:
> > Add uqe_serial document to
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> >
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> > Changes for v2
> > - modify tx/rx-clock-name specification
> >
> > .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19
> > +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > new file mode 100644
> > index 0000000..436c71c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > @@ -0,0 +1,19 @@
> > +* Serial
> > +
> > +Currently defined compatibles:
> > +- ucc_uart
> > +
> > +Properties for ucc_uart:
> > +port-number : port number of UCC-UART
>
> How is this used?
>
> > +tx/rx-clock-name : should be "brg1"-"brg16" for internal clock source,
> > + should be "clk1"-"clk28" for external clock source.
>
> Perhaps you should be using the clock binding here and in other
> bindings?
These properties are required by the underlying UCC binding
(Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe/ucc.txt) and predate
the clock binding.
-Scott
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.
2016-02-23 20:20 ` Scott Wood
@ 2016-02-25 3:10 ` Qiang Zhao
2016-02-25 3:11 ` Scott Wood
0 siblings, 1 reply; 19+ messages in thread
From: Qiang Zhao @ 2016-02-25 3:10 UTC (permalink / raw)
To: Scott Wood, Rob Herring
Cc: Yang-Leo Li, linux-kernel, devicetree, linuxppc-dev
On Wed, 2016-02-24 at 04:20 AM, Scott Wood wrote:
> -----Original Message-----
> From: Scott Wood [mailto:oss@buserror.net]
> Sent: Wednesday, February 24, 2016 4:20 AM
> To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com>
> Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree
> bindings.
>
> On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
> > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> > > Add IC, SI and SIRAM document of QE to
> > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > >
> > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > ---
> > > Changes for v2
> > > - Add interrupt-controller in Required properties
> > > - delete address-cells and size-cells for qe-si and qe-siram
> > >
> > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50
> > > ++++++++++++++++++++++
> > > 1 file changed, 50 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > index 4f89302..84052a7 100644
> > > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > @@ -69,6 +69,56 @@ Example:
> > > };
> > > };
> > >
> > > +* Interrupt Controller (IC)
> > > +
> > > +Required properties:
> > > +- compatible : should be "fsl,qe-ic".
> >
> > > +- compatible : should be "fsl,qe-si".
> >
> > > +- compatible : should be "fsl,qe-siram".
> >
> > These compatible strings are all a bit generic and should have SoC
> > specific compatible strings.
>
> I don't know about si/siram, but "fsl,qe-ic" has been around since 2008, so it
> should be documented even if a more specific compatible is also added.
Agree, and si/siram are also has been around since 2008.
In addition, I don’t think it is needed to add specific compatible, because they are
the same in qe-supported soc.
BR
-Zhao
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.
2016-02-25 3:10 ` Qiang Zhao
@ 2016-02-25 3:11 ` Scott Wood
2016-02-25 5:55 ` Qiang Zhao
0 siblings, 1 reply; 19+ messages in thread
From: Scott Wood @ 2016-02-25 3:11 UTC (permalink / raw)
To: Qiang Zhao, Rob Herring
Cc: Yang-Leo Li, linux-kernel, devicetree, linuxppc-dev
On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote:
> On Wed, 2016-02-24 at 04:20 AM, Scott Wood wrote:
> > -----Original Message-----
> > From: Scott Wood [mailto:oss@buserror.net]
> > Sent: Wednesday, February 24, 2016 4:20 AM
> > To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com>
> > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device
> > tree
> > bindings.
> >
> > On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
> > > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> > > > Add IC, SI and SIRAM document of QE to
> > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > >
> > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > > ---
> > > > Changes for v2
> > > > - Add interrupt-controller in Required properties
> > > > - delete address-cells and size-cells for qe-si and qe-siram
> > > >
> > > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50
> > > > ++++++++++++++++++++++
> > > > 1 file changed, 50 insertions(+)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > index 4f89302..84052a7 100644
> > > > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > @@ -69,6 +69,56 @@ Example:
> > > > };
> > > > };
> > > >
> > > > +* Interrupt Controller (IC)
> > > > +
> > > > +Required properties:
> > > > +- compatible : should be "fsl,qe-ic".
> > >
> > > > +- compatible : should be "fsl,qe-si".
> > >
> > > > +- compatible : should be "fsl,qe-siram".
> > >
> > > These compatible strings are all a bit generic and should have SoC
> > > specific compatible strings.
> >
> > I don't know about si/siram, but "fsl,qe-ic" has been around since 2008,
> > so it
> > should be documented even if a more specific compatible is also added.
>
> Agree, and si/siram are also has been around since 2008.
Where? I couldn't find them when grepping.
> In addition, I don’t think it is needed to add specific compatible, because
> they are
> the same in qe-supported soc.
How do we know that they are 100% the same?
-Scott
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 2/7] QE: Add ucc hdlc document to bindings
2016-02-23 20:21 ` Rob Herring
@ 2016-02-25 4:37 ` Qiang Zhao
0 siblings, 0 replies; 19+ messages in thread
From: Qiang Zhao @ 2016-02-25 4:37 UTC (permalink / raw)
To: Rob Herring; +Cc: oss, Yang-Leo Li, linux-kernel, devicetree, linuxppc-dev
On Wen, Feb 24, 2016 at 04:22AM, Rob Herring wrote:
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Wednesday, February 24, 2016 4:22 AM
> To: Qiang Zhao <qiang.zhao@nxp.com>
> Cc: oss@buserror.net; Yang-Leo Li <leoyang.li@nxp.com>; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; linuxppc-
> dev@lists.ozlabs.org
> Subject: Re: [PATCH v2 2/7] QE: Add ucc hdlc document to bindings
>
> On Thu, Feb 18, 2016 at 09:06:07AM +0800, Zhao Qiang wrote:
> > Add ucc hdlc document to
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
>
> Not a very useful description.
Could you give a example for me?
>
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> > Changes for v2
> > - use ucc-hdlc instead of ucc_hdlc
> > - add more information to properties.
> >
> > .../bindings/powerpc/fsl/cpm_qe/network.txt | 93
> ++++++++++++++++++++++
> > 1 file changed, 93 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
> > index 29b28b8..936158c 100644
> > --- a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
> > +++
> b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/network.txt
> > @@ -41,3 +41,96 @@ Example:
> > fsl,mdio-pin = <12>;
> > fsl,mdc-pin = <13>;
> > };
> > +
> > +* HDLC
> > +
> > +Currently defined compatibles:
> > +- fsl,ucc-hdlc
> > +
> > +Properties for fsl,ucc-hdlc:
> > +- rx-clock-name
> > +- tx-clock-name
> > + Usage: required
> > + Value type: <string>
> > + Definition : should be "brg1"-"brg16" for internal clock source,
> > + should be "clk1"-"clk28" for external clock source.
> > +
> > +- fsl,rx-sync-clock
> > + Usage: required
> > + Value type: <string>
> > + Definition : should be "none" when using internal clock source,
> > + should be "rsync_pin" when using external clock source.
>
> Why not a boolean property here?
fsl,rx-sync-clock should have other values.
But now we just use rsync_pin and none.
> > +
> > +- fsl,tx-timeslot
> > +- fsl,rx-timeslot
>
> Perhaps append "-mask"
Agree, I will modify in next version.
>
> > + Usage: required
> > + Value type: <u32>
> > + Definition : time slot for TDM operation. Indicates which time slots
> > + used for transmitting and receiving.
> > +
> > +- fsl,tdm-framer-type
> > + Usage: required
> > + Value type: <string>
> > + Definition : "e1" or "t1"
>
> Boolean?
We just support e1 and t1, in fact, there are more TDM framer types.
>
> > +
> > +- fsl,tdm-mode
> > + Usage: required
> > + Value type: <string>
> > + Definition : "normal" or "internal-loopback"
>
> Boolean?
It can be Boolean.
BR
-Zhao
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 3/7] QE: Add uqe_serial document to bindings
2016-02-23 20:23 ` Rob Herring
2016-02-23 20:27 ` Scott Wood
@ 2016-02-25 4:44 ` Qiang Zhao
1 sibling, 0 replies; 19+ messages in thread
From: Qiang Zhao @ 2016-02-25 4:44 UTC (permalink / raw)
To: Rob Herring; +Cc: oss, Yang-Leo Li, linux-kernel, devicetree, linuxppc-dev
On Wed, Feb 24, 2016 at 04:24AM, Rob Herring wrote:
> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: Wednesday, February 24, 2016 4:24 AM
> To: Qiang Zhao <qiang.zhao@nxp.com>
> Cc: oss@buserror.net; Yang-Leo Li <leoyang.li@nxp.com>; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org; linuxppc-
> dev@lists.ozlabs.org
> Subject: Re: [PATCH v2 3/7] QE: Add uqe_serial document to bindings
>
> On Thu, Feb 18, 2016 at 09:06:08AM +0800, Zhao Qiang wrote:
> > Add uqe_serial document to
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> >
> > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > ---
> > Changes for v2
> > - modify tx/rx-clock-name specification
> >
> > .../bindings/powerpc/fsl/cpm_qe/uqe_serial.txt | 19
> +++++++++++++++++++
> > 1 file changed, 19 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> >
> > diff --git
> > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.txt
> > new file mode 100644
> > index 0000000..436c71c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/uqe_serial.
> > +++ txt
> > @@ -0,0 +1,19 @@
> > +* Serial
> > +
> > +Currently defined compatibles:
> > +- ucc_uart
> > +
> > +Properties for ucc_uart:
> > +port-number : port number of UCC-UART
>
> How is this used?
It used for uart port index.
BR
-Zhao
^ permalink raw reply [flat|nested] 19+ messages in thread
* RE: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.
2016-02-25 3:11 ` Scott Wood
@ 2016-02-25 5:55 ` Qiang Zhao
2016-02-25 5:56 ` Scott Wood
0 siblings, 1 reply; 19+ messages in thread
From: Qiang Zhao @ 2016-02-25 5:55 UTC (permalink / raw)
To: Scott Wood, Rob Herring
Cc: Yang-Leo Li, linux-kernel, devicetree, linuxppc-dev
On Thu, 2016-02-25 at 11:12 AM, Scott Wood wrote:
> -----Original Message-----
> From: Scott Wood [mailto:oss@buserror.net]
> Sent: Thursday, February 25, 2016 11:12 AM
> To: Qiang Zhao <qiang.zhao@nxp.com>; Rob Herring <robh@kernel.org>
> Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree
> bindings.
>
> On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote:
> > On Wed, 2016-02-24 at 04:20 AM, Scott Wood wrote:
> > > -----Original Message-----
> > > From: Scott Wood [mailto:oss@buserror.net]
> > > Sent: Wednesday, February 24, 2016 4:20 AM
> > > To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com>
> > > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> > > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to
> > > device tree bindings.
> > >
> > > On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
> > > > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> > > > > Add IC, SI and SIRAM document of QE to
> > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > >
> > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > > > ---
> > > > > Changes for v2
> > > > > - Add interrupt-controller in Required properties
> > > > > - delete address-cells and size-cells for qe-si and qe-siram
> > > > >
> > > > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50
> > > > > ++++++++++++++++++++++
> > > > > 1 file changed, 50 insertions(+)
> > > > >
> > > > > diff --git
> > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > index 4f89302..84052a7 100644
> > > > > ---
> > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.tx
> > > > > +++ t
> > > > > @@ -69,6 +69,56 @@ Example:
> > > > > };
> > > > > };
> > > > >
> > > > > +* Interrupt Controller (IC)
> > > > > +
> > > > > +Required properties:
> > > > > +- compatible : should be "fsl,qe-ic".
> > > >
> > > > > +- compatible : should be "fsl,qe-si".
> > > >
> > > > > +- compatible : should be "fsl,qe-siram".
> > > >
> > > > These compatible strings are all a bit generic and should have SoC
> > > > specific compatible strings.
> > >
> > > I don't know about si/siram, but "fsl,qe-ic" has been around since
> > > 2008, so it should be documented even if a more specific compatible
> > > is also added.
> >
> > Agree, and si/siram are also has been around since 2008.
>
> Where? I couldn't find them when grepping.
Sorry, I make a mistake, they have not been in upstream.
>
> > In addition, I don’t think it is needed to add specific compatible,
> > because they are the same in qe-supported soc.
>
> How do we know that they are 100% the same?
You mean it will be changed in later version?
BR
-Zhao
^ permalink raw reply [flat|nested] 19+ messages in thread
* Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings.
2016-02-25 5:55 ` Qiang Zhao
@ 2016-02-25 5:56 ` Scott Wood
0 siblings, 0 replies; 19+ messages in thread
From: Scott Wood @ 2016-02-25 5:56 UTC (permalink / raw)
To: Qiang Zhao, Rob Herring
Cc: Yang-Leo Li, linux-kernel, devicetree, linuxppc-dev
On Thu, 2016-02-25 at 05:55 +0000, Qiang Zhao wrote:
> On Thu, 2016-02-25 at 11:12 AM, Scott Wood wrote:
> > -----Original Message-----
> > From: Scott Wood [mailto:oss@buserror.net]
> > Sent: Thursday, February 25, 2016 11:12 AM
> > To: Qiang Zhao <qiang.zhao@nxp.com>; Rob Herring <robh@kernel.org>
> > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device
> > tree
> > bindings.
> >
> > On Thu, 2016-02-25 at 03:10 +0000, Qiang Zhao wrote:
> > > On Wed, 2016-02-24 at 04:20 AM, Scott Wood wrote:
> > > > -----Original Message-----
> > > > From: Scott Wood [mailto:oss@buserror.net]
> > > > Sent: Wednesday, February 24, 2016 4:20 AM
> > > > To: Rob Herring <robh@kernel.org>; Qiang Zhao <qiang.zhao@nxp.com>
> > > > Cc: Yang-Leo Li <leoyang.li@nxp.com>; linux-kernel@vger.kernel.org;
> > > > devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > Subject: Re: [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to
> > > > device tree bindings.
> > > >
> > > > On Tue, 2016-02-23 at 14:15 -0600, Rob Herring wrote:
> > > > > On Thu, Feb 18, 2016 at 09:06:06AM +0800, Zhao Qiang wrote:
> > > > > > Add IC, SI and SIRAM document of QE to
> > > > > > Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > >
> > > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com>
> > > > > > ---
> > > > > > Changes for v2
> > > > > > - Add interrupt-controller in Required properties
> > > > > > - delete address-cells and size-cells for qe-si and qe-siram
> > > > > >
> > > > > > .../devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt | 50
> > > > > > ++++++++++++++++++++++
> > > > > > 1 file changed, 50 insertions(+)
> > > > > >
> > > > > > diff --git
> > > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > > b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > > index 4f89302..84052a7 100644
> > > > > > ---
> > > > > > a/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.txt
> > > > > > +++ b/Documentation/devicetree/bindings/powerpc/fsl/cpm_qe/qe.tx
> > > > > > +++ t
> > > > > > @@ -69,6 +69,56 @@ Example:
> > > > > > };
> > > > > > };
> > > > > >
> > > > > > +* Interrupt Controller (IC)
> > > > > > +
> > > > > > +Required properties:
> > > > > > +- compatible : should be "fsl,qe-ic".
> > > > >
> > > > > > +- compatible : should be "fsl,qe-si".
> > > > >
> > > > > > +- compatible : should be "fsl,qe-siram".
> > > > >
> > > > > These compatible strings are all a bit generic and should have SoC
> > > > > specific compatible strings.
> > > >
> > > > I don't know about si/siram, but "fsl,qe-ic" has been around since
> > > > 2008, so it should be documented even if a more specific compatible
> > > > is also added.
> > >
> > > Agree, and si/siram are also has been around since 2008.
> >
> > Where? I couldn't find them when grepping.
>
> Sorry, I make a mistake, they have not been in upstream.
>
> >
> > > In addition, I don’t think it is needed to add specific compatible,
> > > because they are the same in qe-supported soc.
> >
> > How do we know that they are 100% the same?
>
> You mean it will be changed in later version?
That's always a possibility, but even on current chips, what bit of
documentation are you referring to that confirms it's the exact same logic?
-Scott
^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2016-02-25 5:56 UTC | newest]
Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-18 1:06 [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 2/7] QE: Add ucc hdlc document to bindings Zhao Qiang
2016-02-23 20:21 ` Rob Herring
2016-02-25 4:37 ` Qiang Zhao
2016-02-18 1:06 ` [PATCH v2 3/7] QE: Add uqe_serial " Zhao Qiang
2016-02-23 20:23 ` Rob Herring
2016-02-23 20:27 ` Scott Wood
2016-02-25 4:44 ` Qiang Zhao
2016-02-18 1:06 ` [PATCH v2 4/7] bindings: move cpm_qe binding from powerpc/fsl to soc/fsl Zhao Qiang
2016-02-23 20:24 ` Rob Herring
2016-02-18 1:06 ` [PATCH v2 5/7] T104xD4RDB: Add qe node to t104xd4rdb Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 6/7] T104xRDB: Add qe node to t104xrdb Zhao Qiang
2016-02-18 1:06 ` [PATCH v2 7/7] T104xQDS: Add qe node to t104xqds Zhao Qiang
2016-02-23 20:15 ` [PATCH v2 1/7] QE: Add IC, SI and SIRAM document to device tree bindings Rob Herring
2016-02-23 20:20 ` Scott Wood
2016-02-25 3:10 ` Qiang Zhao
2016-02-25 3:11 ` Scott Wood
2016-02-25 5:55 ` Qiang Zhao
2016-02-25 5:56 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).