From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "sergei.shtylyov@cogentembedded.com"
<sergei.shtylyov@cogentembedded.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Vineet.Gupta1@synopsys.com" <Vineet.Gupta1@synopsys.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"robh@kernel.org" <robh@kernel.org>,
"preid@electromag.com.au" <preid@electromag.com.au>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts
Date: Thu, 17 Mar 2016 12:10:37 +0000 [thread overview]
Message-ID: <1458216636.14496.19.camel@synopsys.com> (raw)
In-Reply-To: <56EA9C0D.1090000@cogentembedded.com>
Hi Sergei,
On Thu, 2016-03-17 at 14:59 +0300, Sergei Shtylyov wrote:
> Hello.
>
> On 3/17/2016 2:41 PM, Vineet Gupta wrote:
>
> >
> > >
> > > >
> > > > >
> > > > > Following commit broke DW GMAC functionality on AXS10x boards:
> > > > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461e
> > > > > d763
> > > > Note that scripts/checkpatch.pl now enforces certain format for citing
> > > > commits: commit <12-digit SHA1> ("<commit summary>").
> >
> > >
> > > Frankly I haven't run that patch through checkpatch due to patch
> > > simplicity.
> > >
> > > But I'll try to not do any assumptions from now on and will try to
> > > use checkpatch for each and every thing I send :)
> > >
> > > Thanks for spotting all his!
> > >
> Sorry for not reporting everything on the 1st review.
>
> >
> > >
> > > -Alexey
> > Sergei, do you mind providing a Ack/Reviewed-by on the patch below
> >
>
> Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> The patch here is white space damaged however: tabs were converted to
> spaces. :-(
Well, I'm not really sure why that substitution happened because my local patch
is indeed with tabs.
That's an output of checkpatch:
------------------------>8------------------------
./scripts/checkpatch.pl 0001-ARC-axs10x-add-Ethernet-PHY-description-in-.dts.patch
[1]+ Done gedit 0001-ARC-axs10x-add-Ethernet-PHY-description-in-.dts.patch
WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit e34d65696d2e
("stmmac: create of compatible mdio bus for stmmac driver")'
#7:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
total: 1 errors, 1 warnings, 14 lines checked
0001-ARC-axs10x-add-Ethernet-PHY-description-in-.dts.patch has style problems, please review.
------------------------>8------------------------
If there were spaces we would see tons of:
------------------------>8------------------------
ERROR: code indent should use tabs where possible
#43: FILE: arch/arc/boot/dts/axs10x_mb.dtsi:50:
+ mdio0 {$
------------------------>8------------------------
which I didn't see.
-Alexey
next prev parent reply other threads:[~2016-03-17 12:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 9:41 [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin
2016-03-17 10:58 ` Sergei Shtylyov
2016-03-17 11:13 ` Vineet Gupta
2016-03-17 11:37 ` Alexey Brodkin
2016-03-17 11:41 ` Vineet Gupta
2016-03-17 11:59 ` Sergei Shtylyov
2016-03-17 12:10 ` Alexey Brodkin [this message]
2016-03-17 12:16 ` Vineet Gupta
2016-04-06 9:12 ` Vineet Gupta
2016-04-06 14:56 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1458216636.14496.19.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=preid@electromag.com.au \
--cc=robh@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).