From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
<linux-snps-arc@lists.infradead.org>
Cc: Rob Herring <robh@kernel.org>,
Phil Reid <preid@electromag.com.au>,
"David S. Miller" <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
Gabriel Fernandez <gabriel.fernandez@linaro.org>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts
Date: Wed, 6 Apr 2016 16:56:48 +0200 [thread overview]
Message-ID: <570523B0.6070600@st.com> (raw)
In-Reply-To: <5704D2ED.4060507@synopsys.com>
On 4/6/2016 11:12 AM, Vineet Gupta wrote:
> Hi,
>
> On Thursday 17 March 2016 03:11 PM, Alexey Brodkin wrote:
>> Following commit broke DW GMAC functionality on AXS10x boards:
>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
>>
>> That's what happens on eth0 up:
>> --------------------------->8------------------------
>> libphy: PHY stmmac-0:ffffffff not found
>> eth0: Could not attach to PHY
>> stmmac_open: Cannot attach to PHY (error: -19)
>> --------------------------->8------------------------
>>
>> Simplest solution is to add PHY description in board's .dts.
>> And so we do here.
>>
>> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Phil Reid <preid@electromag.com.au>
>> Cc: David S. Miller <davem@davemloft.net>
>> Cc: linux-kernel@vger.kernel.org
>> Cc: netdev@vger.kernel.org
>> Cc: stable@vger.kernel.org # 4.5.x
>> Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>> ---
>>
>> Changes v1 -> v2:
>> * PHY node name changed to match real PHY number being used (Sergei)
>>
>> arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
>> index 44a578c..ab5d570 100644
>> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
>> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
>> @@ -47,6 +47,14 @@
>> clocks = <&apbclk>;
>> clock-names = "stmmaceth";
>> max-speed = <100>;
>> + mdio0 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "snps,dwmac-mdio";
>> + phy1: ethernet-phy@1 {
>> + reg = <1>;
>> + };
>> + };
>> };
>>
>> ehci@0x40000 {
>
>
> So above DT fix for ARC went into 4.6-rc1 and ethernet was still broken on axs103
> board.
>
> ---------->8-------------
> libphy: PHY stmmac-0:ffffffff not found
> eth0: Could not attach to PHY
> stmmac_open: Cannot attach to PHY (error: -19)
> ---------->8-------------
>
> On 4.6-rc2 if I revert the DT change, ethernet works again.
>
> @Giuseppe, @Phil, @Gabriel, I see you have made changes in that area. I presume
> that above revert is the right/sufficient thing or do we need to do something else
> as well.
hmm I think so, we pushed all the changes in net-next to fix the MDIO
initialization according to the different DT parameter settings. So
unless there is some other case to cover, I think that the best
approach is to do the revert.
pls, let me know
peppe
>
> TIA,
> -Vineet
>
>
prev parent reply other threads:[~2016-04-06 14:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 9:41 [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin
2016-03-17 10:58 ` Sergei Shtylyov
2016-03-17 11:13 ` Vineet Gupta
2016-03-17 11:37 ` Alexey Brodkin
2016-03-17 11:41 ` Vineet Gupta
2016-03-17 11:59 ` Sergei Shtylyov
2016-03-17 12:10 ` Alexey Brodkin
2016-03-17 12:16 ` Vineet Gupta
2016-04-06 9:12 ` Vineet Gupta
2016-04-06 14:56 ` Giuseppe CAVALLARO [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570523B0.6070600@st.com \
--to=peppe.cavallaro@st.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=davem@davemloft.net \
--cc=gabriel.fernandez@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=preid@electromag.com.au \
--cc=robh@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).