From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: "robh@kernel.org" <robh@kernel.org>,
"preid@electromag.com.au" <preid@electromag.com.au>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts
Date: Thu, 17 Mar 2016 14:59:09 +0300 [thread overview]
Message-ID: <56EA9C0D.1090000@cogentembedded.com> (raw)
In-Reply-To: <C2D7FE5348E1B147BCA15975FBA23075F4E903EF@us01wembx1.internal.synopsys.com>
Hello.
On 3/17/2016 2:41 PM, Vineet Gupta wrote:
>>>> Following commit broke DW GMAC functionality on AXS10x boards:
>>>> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
>>> Note that scripts/checkpatch.pl now enforces certain format for citing
>>> commits: commit <12-digit SHA1> ("<commit summary>").
>> Frankly I haven't run that patch through checkpatch due to patch
>> simplicity.
>>
>> But I'll try to not do any assumptions from now on and will try to
>> use checkpatch for each and every thing I send :)
>>
>> Thanks for spotting all his!
>>
Sorry for not reporting everything on the 1st review.
>> -Alexey
>
> Sergei, do you mind providing a Ack/Reviewed-by on the patch below
>
Reviewed-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
The patch here is white space damaged however: tabs were converted to
spaces. :-(
MBR, Sergei
next prev parent reply other threads:[~2016-03-17 11:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 9:41 [PATCH v2] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin
2016-03-17 10:58 ` Sergei Shtylyov
2016-03-17 11:13 ` Vineet Gupta
2016-03-17 11:37 ` Alexey Brodkin
2016-03-17 11:41 ` Vineet Gupta
2016-03-17 11:59 ` Sergei Shtylyov [this message]
2016-03-17 12:10 ` Alexey Brodkin
2016-03-17 12:16 ` Vineet Gupta
2016-04-06 9:12 ` Vineet Gupta
2016-04-06 14:56 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EA9C0D.1090000@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=preid@electromag.com.au \
--cc=robh@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).