* [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards
@ 2016-04-18 7:44 Krzysztof Kozlowski
2016-04-18 16:52 ` Javier Martinez Canillas
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-18 7:44 UTC (permalink / raw)
To: Kukjin Kim, Krzysztof Kozlowski, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Bartlomiej Zolnierkiewicz
The bindings like s2mps11,buck6-ramp-enable or s2mps11,buck2-ramp-delay
where ignored. They were never parse by s2mps11 regulator driver. Also
the values used in these bindings were equal to default reset values of
S2MPS11 device. It is safe to remove them.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
arch/arm/boot/dts/exynos5420-arndale-octa.dts | 7 -------
arch/arm/boot/dts/exynos5420-smdk5420.dts | 7 -------
arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 7 -------
3 files changed, 21 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5420-arndale-octa.dts b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
index a103ce8c3985..60bc861d0f9d 100644
--- a/arch/arm/boot/dts/exynos5420-arndale-octa.dts
+++ b/arch/arm/boot/dts/exynos5420-arndale-octa.dts
@@ -75,13 +75,6 @@
s2mps11_pmic@66 {
compatible = "samsung,s2mps11-pmic";
reg = <0x66>;
- s2mps11,buck2-ramp-delay = <12>;
- s2mps11,buck34-ramp-delay = <12>;
- s2mps11,buck16-ramp-delay = <12>;
- s2mps11,buck6-ramp-enable = <1>;
- s2mps11,buck2-ramp-enable = <1>;
- s2mps11,buck3-ramp-enable = <1>;
- s2mps11,buck4-ramp-enable = <1>;
interrupt-parent = <&gpx3>;
interrupts = <2 IRQ_TYPE_EDGE_FALLING>;
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index 49920b4330ed..2e748d19322f 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -140,13 +140,6 @@
s2mps11_pmic@66 {
compatible = "samsung,s2mps11-pmic";
reg = <0x66>;
- s2mps11,buck2-ramp-delay = <12>;
- s2mps11,buck34-ramp-delay = <12>;
- s2mps11,buck16-ramp-delay = <12>;
- s2mps11,buck6-ramp-enable = <1>;
- s2mps11,buck2-ramp-enable = <1>;
- s2mps11,buck3-ramp-enable = <1>;
- s2mps11,buck4-ramp-enable = <1>;
s2mps11_osc: clocks {
#clock-cells = <1>;
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
index 0e71d4253205..20fa7612080d 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
@@ -92,13 +92,6 @@
s2mps11_pmic@66 {
compatible = "samsung,s2mps11-pmic";
reg = <0x66>;
- s2mps11,buck2-ramp-delay = <12>;
- s2mps11,buck34-ramp-delay = <12>;
- s2mps11,buck16-ramp-delay = <12>;
- s2mps11,buck6-ramp-enable = <1>;
- s2mps11,buck2-ramp-enable = <1>;
- s2mps11,buck3-ramp-enable = <1>;
- s2mps11,buck4-ramp-enable = <1>;
samsung,s2mps11-acokb-ground;
interrupt-parent = <&gpx0>;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards
2016-04-18 7:44 [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards Krzysztof Kozlowski
@ 2016-04-18 16:52 ` Javier Martinez Canillas
2016-04-19 5:46 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-04-18 16:52 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kukjin Kim, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Bartlomiej Zolnierkiewicz
Hello Krzysztof,
On 04/18/2016 03:44 AM, Krzysztof Kozlowski wrote:
> The bindings like s2mps11,buck6-ramp-enable or s2mps11,buck2-ramp-delay
> where ignored. They were never parse by s2mps11 regulator driver. Also
> the values used in these bindings were equal to default reset values of
> S2MPS11 device. It is safe to remove them.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
The patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
On a related note, the s5m8767 regulator driver parses similar DT properties
("s5m8767,pmic-buck-ramp-delay", "s5m8767,pmic-buck2-ramp-enable", etc) that
are not in Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt.
So those should either be added to the binding doc or removed from the driver
if are not correct (I don't have documentation for the s5m8767 PMIC but the
DT properties are not use by any DTS in mainline using the s5m8767 PMIC).
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards
2016-04-18 16:52 ` Javier Martinez Canillas
@ 2016-04-19 5:46 ` Krzysztof Kozlowski
2016-04-19 20:13 ` Javier Martinez Canillas
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2016-04-19 5:46 UTC (permalink / raw)
To: Javier Martinez Canillas, Kukjin Kim, devicetree,
linux-arm-kernel, linux-samsung-soc, linux-kernel
Cc: Bartlomiej Zolnierkiewicz
On 04/18/2016 06:52 PM, Javier Martinez Canillas wrote:
> Hello Krzysztof,
>
> On 04/18/2016 03:44 AM, Krzysztof Kozlowski wrote:
>> The bindings like s2mps11,buck6-ramp-enable or s2mps11,buck2-ramp-delay
>> where ignored. They were never parse by s2mps11 regulator driver. Also
>> the values used in these bindings were equal to default reset values of
>> S2MPS11 device. It is safe to remove them.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>
> The patch looks good to me.
>
> Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Thanks.
>
> On a related note, the s5m8767 regulator driver parses similar DT properties
> ("s5m8767,pmic-buck-ramp-delay", "s5m8767,pmic-buck2-ramp-enable", etc) that
> are not in Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt.
>
> So those should either be added to the binding doc or removed from the driver
> if are not correct (I don't have documentation for the s5m8767 PMIC but the
> DT properties are not use by any DTS in mainline using the s5m8767 PMIC).
That's the grey area. :) I mean that instead of making these implemented
bindings an interface, they should rather be converted to standard
regulator bindings. However the device is quite old, not used on newer
boards, so there is no interest in improving this. In the same time
removal of this code is not strictly necessary. Its existence does not hurt.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards
2016-04-19 5:46 ` Krzysztof Kozlowski
@ 2016-04-19 20:13 ` Javier Martinez Canillas
0 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2016-04-19 20:13 UTC (permalink / raw)
To: Krzysztof Kozlowski, Kukjin Kim, devicetree, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cc: Bartlomiej Zolnierkiewicz
Hello Krzysztof,
On 04/19/2016 01:46 AM, Krzysztof Kozlowski wrote:
> On 04/18/2016 06:52 PM, Javier Martinez Canillas wrote:
[snip]
>>
>> On a related note, the s5m8767 regulator driver parses similar DT properties
>> ("s5m8767,pmic-buck-ramp-delay", "s5m8767,pmic-buck2-ramp-enable", etc) that
>> are not in Documentation/devicetree/bindings/regulator/samsung,s5m8767.txt.
>>
>> So those should either be added to the binding doc or removed from the driver
>> if are not correct (I don't have documentation for the s5m8767 PMIC but the
>> DT properties are not use by any DTS in mainline using the s5m8767 PMIC).
>
> That's the grey area. :) I mean that instead of making these implemented
> bindings an interface, they should rather be converted to standard
> regulator bindings. However the device is quite old, not used on newer
> boards, so there is no interest in improving this. In the same time
> removal of this code is not strictly necessary. Its existence does not hurt.
>
Fair enough.
> Best regards,
> Krzysztof
>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-19 20:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-18 7:44 [PATCH] ARM: dts: exynos: Remove unsupported s2mps11 regulator bindings from Exynos5420 boards Krzysztof Kozlowski
2016-04-18 16:52 ` Javier Martinez Canillas
2016-04-19 5:46 ` Krzysztof Kozlowski
2016-04-19 20:13 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).