* [PATCH] drivers/hwtracing: add missing header dependencies
@ 2016-09-06 7:56 Baoyou Xie
2016-09-06 15:27 ` Mathieu Poirier
0 siblings, 1 reply; 2+ messages in thread
From: Baoyou Xie @ 2016-09-06 7:56 UTC (permalink / raw)
To: mathieu.poirier
Cc: linux-arm-kernel, linux-kernel, arnd, baoyou.xie, xie.baoyou
We get 1 warning when building kernel with W=1:
drivers/hwtracing/coresight/coresight-etm-perf.c:345:5: warning: no previous prototype for 'etm_perf_symlink' [-Wmissing-prototypes]
In fact, this function is declared in coresight-etm-perf.h, so this patch
add missing header dependencies.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/hwtracing/coresight/coresight-etm-perf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
index 755125f..d936e82 100644
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -28,6 +28,7 @@
#include <linux/workqueue.h>
#include "coresight-priv.h"
+#include "coresight-etm-perf.h"
static struct pmu etm_pmu;
static bool etm_perf_up;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/hwtracing: add missing header dependencies
2016-09-06 7:56 [PATCH] drivers/hwtracing: add missing header dependencies Baoyou Xie
@ 2016-09-06 15:27 ` Mathieu Poirier
0 siblings, 0 replies; 2+ messages in thread
From: Mathieu Poirier @ 2016-09-06 15:27 UTC (permalink / raw)
To: Baoyou Xie; +Cc: linux-arm-kernel, linux-kernel, Arnd Bergmann, xie.baoyou
On 6 September 2016 at 01:56, Baoyou Xie <baoyou.xie@linaro.org> wrote:
> We get 1 warning when building kernel with W=1:
> drivers/hwtracing/coresight/coresight-etm-perf.c:345:5: warning: no previous prototype for 'etm_perf_symlink' [-Wmissing-prototypes]
>
> In fact, this function is declared in coresight-etm-perf.h, so this patch
> add missing header dependencies.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/hwtracing/coresight/coresight-etm-perf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
> index 755125f..d936e82 100644
> --- a/drivers/hwtracing/coresight/coresight-etm-perf.c
> +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
> @@ -28,6 +28,7 @@
> #include <linux/workqueue.h>
>
> #include "coresight-priv.h"
> +#include "coresight-etm-perf.h"
I already fixed this one in my next branch - it will show up in the 4.9 cycle.
Thanks for the submission,
Mathieu
>
> static struct pmu etm_pmu;
> static bool etm_perf_up;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-06 15:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-06 7:56 [PATCH] drivers/hwtracing: add missing header dependencies Baoyou Xie
2016-09-06 15:27 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).