From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: [RFC PATCH 1/2] ASoC: core: Print one-time messages if missing resources when binding DAIs
Date: Wed, 19 Oct 2016 14:21:05 -0300 [thread overview]
Message-ID: <1476897666-13974-2-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1476897666-13974-1-git-send-email-javier@osg.samsung.com>
If snd_soc_find_dai() doesn't find a DAI in soc_bind_dai_link(), a
error message is printed and an -EPROBE_DEFER errno code returned to
the caller.
But since many probe retries can happen before a resource is available,
the printed messages can spam the kernel log buffer and slow the boot.
The information is useful to know that a dependency was not meet and a
defer happened, but isn't necessary to print it on each probe deferral.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
sound/soc/soc-core.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index c0bbcd903261..4679c07e0ff6 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -1013,8 +1013,8 @@ static int soc_bind_dai_link(struct snd_soc_card *card,
cpu_dai_component.dai_name = dai_link->cpu_dai_name;
rtd->cpu_dai = snd_soc_find_dai(&cpu_dai_component);
if (!rtd->cpu_dai) {
- dev_err(card->dev, "ASoC: CPU DAI %s not registered\n",
- dai_link->cpu_dai_name);
+ dev_err_once(card->dev, "ASoC: CPU DAI %s not registered\n",
+ dai_link->cpu_dai_name);
goto _err_defer;
}
@@ -1025,8 +1025,9 @@ static int soc_bind_dai_link(struct snd_soc_card *card,
for (i = 0; i < rtd->num_codecs; i++) {
codec_dais[i] = snd_soc_find_dai(&codecs[i]);
if (!codec_dais[i]) {
- dev_err(card->dev, "ASoC: CODEC DAI %s not registered\n",
- codecs[i].dai_name);
+ dev_err_once(card->dev,
+ "ASoC: CODEC DAI %s not registered\n",
+ codecs[i].dai_name);
goto _err_defer;
}
}
@@ -1054,8 +1055,8 @@ static int soc_bind_dai_link(struct snd_soc_card *card,
rtd->platform = platform;
}
if (!rtd->platform) {
- dev_err(card->dev, "ASoC: platform %s not registered\n",
- dai_link->platform_name);
+ dev_err_once(card->dev, "ASoC: platform %s not registered\n",
+ dai_link->platform_name);
goto _err_defer;
}
--
2.7.4
next prev parent reply other threads:[~2016-10-19 17:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 17:21 [RFC PATCH 0/2] ASoC: Prevent the snow ASoC driver to spam due probe deferrals Javier Martinez Canillas
2016-10-19 17:21 ` Javier Martinez Canillas [this message]
2016-10-24 17:21 ` [RFC PATCH 1/2] ASoC: core: Print one-time messages if missing resources when binding DAIs Mark Brown
2016-10-24 18:39 ` Javier Martinez Canillas
2016-10-19 17:21 ` [RFC PATCH 2/2] ASoC: samsung: Print a one-time message if the snow driver's probe defers Javier Martinez Canillas
2016-10-19 18:12 ` Krzysztof Kozlowski
2016-10-19 18:16 ` Javier Martinez Canillas
2016-10-20 9:12 ` [alsa-devel] " Sylwester Nawrocki
2016-10-20 10:41 ` Javier Martinez Canillas
2016-10-20 11:27 ` Sylwester Nawrocki
2016-10-20 11:37 ` Javier Martinez Canillas
2016-10-27 15:38 ` Javier Martinez Canillas
2016-10-27 15:48 ` Sylwester Nawrocki
2016-10-27 15:51 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476897666-13974-2-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).