From: Javier Martinez Canillas <javier@osg.samsung.com>
To: linux-kernel@vger.kernel.org
Cc: Javier Martinez Canillas <javier@osg.samsung.com>,
Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: [RFC PATCH 2/2] ASoC: samsung: Print a one-time message if the snow driver's probe defers
Date: Wed, 19 Oct 2016 14:21:06 -0300 [thread overview]
Message-ID: <1476897666-13974-3-git-send-email-javier@osg.samsung.com> (raw)
In-Reply-To: <1476897666-13974-1-git-send-email-javier@osg.samsung.com>
If the snd_soc_register_card() fails due a missing resource and the probe
has to be deferred, the driver prints an error message.
But since many probe retries can happen before a resource is available,
the printed messages can spam the kernel log buffer and slow the boot.
The information is useful to know that a dependency was not meet and a
defer happened, but isn't necessary to print it on each probe deferral.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
sound/soc/samsung/snow.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/sound/soc/samsung/snow.c b/sound/soc/samsung/snow.c
index d8ac907bbb0d..068bfb78a668 100644
--- a/sound/soc/samsung/snow.c
+++ b/sound/soc/samsung/snow.c
@@ -103,7 +103,13 @@ static int snow_probe(struct platform_device *pdev)
ret = devm_snd_soc_register_card(&pdev->dev, card);
if (ret) {
- dev_err(&pdev->dev, "snd_soc_register_card failed (%d)\n", ret);
+ if (ret == -EPROBE_DEFER)
+ dev_err_once(&pdev->dev,
+ "snd_soc_register_card deferred (%d)\n",
+ ret);
+ else
+ dev_err(&pdev->dev,
+ "snd_soc_register_card failed (%d)\n", ret);
return ret;
}
--
2.7.4
next prev parent reply other threads:[~2016-10-19 17:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 17:21 [RFC PATCH 0/2] ASoC: Prevent the snow ASoC driver to spam due probe deferrals Javier Martinez Canillas
2016-10-19 17:21 ` [RFC PATCH 1/2] ASoC: core: Print one-time messages if missing resources when binding DAIs Javier Martinez Canillas
2016-10-24 17:21 ` Mark Brown
2016-10-24 18:39 ` Javier Martinez Canillas
2016-10-19 17:21 ` Javier Martinez Canillas [this message]
2016-10-19 18:12 ` [RFC PATCH 2/2] ASoC: samsung: Print a one-time message if the snow driver's probe defers Krzysztof Kozlowski
2016-10-19 18:16 ` Javier Martinez Canillas
2016-10-20 9:12 ` [alsa-devel] " Sylwester Nawrocki
2016-10-20 10:41 ` Javier Martinez Canillas
2016-10-20 11:27 ` Sylwester Nawrocki
2016-10-20 11:37 ` Javier Martinez Canillas
2016-10-27 15:38 ` Javier Martinez Canillas
2016-10-27 15:48 ` Sylwester Nawrocki
2016-10-27 15:51 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476897666-13974-3-git-send-email-javier@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=s.nawrocki@samsung.com \
--cc=sbkim73@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).