From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [RFC PATCH 1/2] ASoC: core: Print one-time messages if missing resources when binding DAIs
Date: Mon, 24 Oct 2016 15:39:00 -0300 [thread overview]
Message-ID: <31474093-6389-629a-73f0-d60cc8d15d3c@osg.samsung.com> (raw)
In-Reply-To: <20161024172121.GF17252@sirena.org.uk>
Hello Mark,
On 10/24/2016 02:21 PM, Mark Brown wrote:
> On Wed, Oct 19, 2016 at 02:21:05PM -0300, Javier Martinez Canillas wrote:
>> If snd_soc_find_dai() doesn't find a DAI in soc_bind_dai_link(), a
>> error message is printed and an -EPROBE_DEFER errno code returned to
>> the caller.
>
>> But since many probe retries can happen before a resource is available,
>> the printed messages can spam the kernel log buffer and slow the boot.
>
>> The information is useful to know that a dependency was not meet and a
>> defer happened, but isn't necessary to print it on each probe deferral.
>
> This then turns any subsequent failure into a silent one which isn't
> great for diagnostics. It'd be better to look into trying to avoid the
> retries in the first place, Raphael's dependency graph stuff looks very
> promising here.
>
Ok, thanks for your feedback. I'll also investigate why the number of
probes/retries increased that much from v4.8.
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-10-24 18:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 17:21 [RFC PATCH 0/2] ASoC: Prevent the snow ASoC driver to spam due probe deferrals Javier Martinez Canillas
2016-10-19 17:21 ` [RFC PATCH 1/2] ASoC: core: Print one-time messages if missing resources when binding DAIs Javier Martinez Canillas
2016-10-24 17:21 ` Mark Brown
2016-10-24 18:39 ` Javier Martinez Canillas [this message]
2016-10-19 17:21 ` [RFC PATCH 2/2] ASoC: samsung: Print a one-time message if the snow driver's probe defers Javier Martinez Canillas
2016-10-19 18:12 ` Krzysztof Kozlowski
2016-10-19 18:16 ` Javier Martinez Canillas
2016-10-20 9:12 ` [alsa-devel] " Sylwester Nawrocki
2016-10-20 10:41 ` Javier Martinez Canillas
2016-10-20 11:27 ` Sylwester Nawrocki
2016-10-20 11:37 ` Javier Martinez Canillas
2016-10-27 15:38 ` Javier Martinez Canillas
2016-10-27 15:48 ` Sylwester Nawrocki
2016-10-27 15:51 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31474093-6389-629a-73f0-d60cc8d15d3c@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).