* [PATCH 1/1 linux-next] xfs: remove unnecessary return
@ 2016-12-10 6:52 Fabian Frederick
2016-12-15 4:17 ` Eric Sandeen
0 siblings, 1 reply; 3+ messages in thread
From: Fabian Frederick @ 2016-12-10 6:52 UTC (permalink / raw)
To: Dave Chinner, Eric Sandeen; +Cc: linux-xfs, linux-kernel, fabf
Commit f7a136aee3c1
("xfs: several xattr functions can be void")
updated 2 end of function return 0 to return in void
functions. Remove it.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
fs/xfs/xfs_attr_list.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
index 97c45b6..5aa46c3 100644
--- a/fs/xfs/xfs_attr_list.c
+++ b/fs/xfs/xfs_attr_list.c
@@ -433,7 +433,6 @@ xfs_attr3_leaf_list_int(
cursor->offset++;
}
trace_xfs_attr_list_leaf_end(context);
- return;
}
/*
@@ -543,7 +542,6 @@ xfs_attr_put_listent(
alist->al_offset[context->count++] = context->firstu;
alist->al_count = context->count;
trace_xfs_attr_list_add(context);
- return;
}
/*
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1 linux-next] xfs: remove unnecessary return
2016-12-10 6:52 [PATCH 1/1 linux-next] xfs: remove unnecessary return Fabian Frederick
@ 2016-12-15 4:17 ` Eric Sandeen
2016-12-15 17:53 ` Eric Sandeen
0 siblings, 1 reply; 3+ messages in thread
From: Eric Sandeen @ 2016-12-15 4:17 UTC (permalink / raw)
To: Fabian Frederick, Dave Chinner, Eric Sandeen; +Cc: linux-xfs, linux-kernel
On 12/10/16 12:52 AM, Fabian Frederick wrote:
> Commit f7a136aee3c1
> ("xfs: several xattr functions can be void")
>
> updated 2 end of function return 0 to return in void
> functions. Remove it.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Oh, sure. :)
Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> fs/xfs/xfs_attr_list.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
> index 97c45b6..5aa46c3 100644
> --- a/fs/xfs/xfs_attr_list.c
> +++ b/fs/xfs/xfs_attr_list.c
> @@ -433,7 +433,6 @@ xfs_attr3_leaf_list_int(
> cursor->offset++;
> }
> trace_xfs_attr_list_leaf_end(context);
> - return;
> }
>
> /*
> @@ -543,7 +542,6 @@ xfs_attr_put_listent(
> alist->al_offset[context->count++] = context->firstu;
> alist->al_count = context->count;
> trace_xfs_attr_list_add(context);
> - return;
> }
>
> /*
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1 linux-next] xfs: remove unnecessary return
2016-12-15 4:17 ` Eric Sandeen
@ 2016-12-15 17:53 ` Eric Sandeen
0 siblings, 0 replies; 3+ messages in thread
From: Eric Sandeen @ 2016-12-15 17:53 UTC (permalink / raw)
To: Fabian Frederick, Dave Chinner, Eric Sandeen; +Cc: linux-xfs, linux-kernel
On 12/14/16 10:17 PM, Eric Sandeen wrote:
> On 12/10/16 12:52 AM, Fabian Frederick wrote:
>> Commit f7a136aee3c1
>> ("xfs: several xattr functions can be void")
>>
>> updated 2 end of function return 0 to return in void
>> functions. Remove it.
>>
>> Signed-off-by: Fabian Frederick <fabf@skynet.be>
>
> Oh, sure. :)
>
> Reviewed-by: Eric Sandeen <sandeen@sandeen.net>
On second thought, it seems to be quite common in
xfs to have a last "return;" in void functions:
# grep -n -B1 ^} fs/xfs/*.c fs/xfs/*/*.c | grep "return;" | wc -l
14
so it's really just a style issue, and probably no reason
to change it in just these 2 cases... *shrug* dchinner, take
it or leave it as you see fit. :)
-Eric
>> ---
>> fs/xfs/xfs_attr_list.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/fs/xfs/xfs_attr_list.c b/fs/xfs/xfs_attr_list.c
>> index 97c45b6..5aa46c3 100644
>> --- a/fs/xfs/xfs_attr_list.c
>> +++ b/fs/xfs/xfs_attr_list.c
>> @@ -433,7 +433,6 @@ xfs_attr3_leaf_list_int(
>> cursor->offset++;
>> }
>> trace_xfs_attr_list_leaf_end(context);
>> - return;
>> }
>>
>> /*
>> @@ -543,7 +542,6 @@ xfs_attr_put_listent(
>> alist->al_offset[context->count++] = context->firstu;
>> alist->al_count = context->count;
>> trace_xfs_attr_list_add(context);
>> - return;
>> }
>>
>> /*
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-15 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-10 6:52 [PATCH 1/1 linux-next] xfs: remove unnecessary return Fabian Frederick
2016-12-15 4:17 ` Eric Sandeen
2016-12-15 17:53 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).