* [PATCH] usbip: vudc: check for NULL before use @ 2016-12-18 22:44 Sudip Mukherjee 2016-12-20 14:31 ` Shuah Khan 0 siblings, 1 reply; 6+ messages in thread From: Sudip Mukherjee @ 2016-12-18 22:44 UTC (permalink / raw) To: Valentina Manea, Shuah Khan, Greg Kroah-Hartman Cc: linux-kernel, linux-usb, Sudip Mukherjee to_vep() is doing a container_of() on _ep. It is better to do the NULL check first and then use it. Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> --- drivers/usb/usbip/vudc_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c index 968471b..32ea604 100644 --- a/drivers/usb/usbip/vudc_dev.c +++ b/drivers/usb/usbip/vudc_dev.c @@ -388,10 +388,10 @@ static int vep_dequeue(struct usb_ep *_ep, struct usb_request *_req) unsigned long flags; int ret = 0; - ep = to_vep(_ep); if (!_ep) return -EINVAL; + ep = to_vep(_ep); udc = ep_to_vudc(ep); if (!udc->driver) return -ESHUTDOWN; -- 1.9.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] usbip: vudc: check for NULL before use 2016-12-18 22:44 [PATCH] usbip: vudc: check for NULL before use Sudip Mukherjee @ 2016-12-20 14:31 ` Shuah Khan 2016-12-21 13:33 ` Sudip Mukherjee 0 siblings, 1 reply; 6+ messages in thread From: Shuah Khan @ 2016-12-20 14:31 UTC (permalink / raw) To: Sudip Mukherjee, Valentina Manea, Greg Kroah-Hartman Cc: linux-kernel, linux-usb, Shuah Khan, Shuah Khan On 12/18/2016 03:44 PM, Sudip Mukherjee wrote: > to_vep() is doing a container_of() on _ep. It is better to do the NULL > check first and then use it. > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > --- > drivers/usb/usbip/vudc_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c > index 968471b..32ea604 100644 > --- a/drivers/usb/usbip/vudc_dev.c > +++ b/drivers/usb/usbip/vudc_dev.c > @@ -388,10 +388,10 @@ static int vep_dequeue(struct usb_ep *_ep, struct usb_request *_req) > unsigned long flags; > int ret = 0; > > - ep = to_vep(_ep); > if (!_ep) > return -EINVAL; Hmm. Linus's latest checks _ep and _req. Are you sure you are working with the latest tree? > > + ep = to_vep(_ep); > udc = ep_to_vudc(ep); > if (!udc->driver) > return -ESHUTDOWN; > thanks, -- Shuah ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usbip: vudc: check for NULL before use 2016-12-20 14:31 ` Shuah Khan @ 2016-12-21 13:33 ` Sudip Mukherjee 2016-12-21 14:38 ` Shuah Khan 0 siblings, 1 reply; 6+ messages in thread From: Sudip Mukherjee @ 2016-12-21 13:33 UTC (permalink / raw) To: Shuah Khan Cc: Valentina Manea, Greg Kroah-Hartman, linux-kernel, linux-usb, Shuah Khan On Tue, Dec 20, 2016 at 07:31:44AM -0700, Shuah Khan wrote: > On 12/18/2016 03:44 PM, Sudip Mukherjee wrote: > > to_vep() is doing a container_of() on _ep. It is better to do the NULL > > check first and then use it. > > > > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > > --- > > drivers/usb/usbip/vudc_dev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c > > index 968471b..32ea604 100644 > > --- a/drivers/usb/usbip/vudc_dev.c > > +++ b/drivers/usb/usbip/vudc_dev.c > > @@ -388,10 +388,10 @@ static int vep_dequeue(struct usb_ep *_ep, struct usb_request *_req) > > unsigned long flags; > > int ret = 0; > > > > - ep = to_vep(_ep); > > if (!_ep) > > return -EINVAL; > > Hmm. Linus's latest checks _ep and _req. Are you sure you are working > with the latest tree? I checked with next-20161221 and its still there. regards sudip ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usbip: vudc: check for NULL before use 2016-12-21 13:33 ` Sudip Mukherjee @ 2016-12-21 14:38 ` Shuah Khan 2016-12-21 15:02 ` Krzysztof Opasiak 2016-12-21 16:11 ` Sudip Mukherjee 0 siblings, 2 replies; 6+ messages in thread From: Shuah Khan @ 2016-12-21 14:38 UTC (permalink / raw) To: Sudip Mukherjee Cc: Shuah Khan, Valentina Manea, Greg Kroah-Hartman, LKML, linux-usb, Shuah Khan, Shuah Khan Hi Sudip, On Wed, Dec 21, 2016 at 6:33 AM, Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > On Tue, Dec 20, 2016 at 07:31:44AM -0700, Shuah Khan wrote: >> On 12/18/2016 03:44 PM, Sudip Mukherjee wrote: >> > to_vep() is doing a container_of() on _ep. It is better to do the NULL >> > check first and then use it. >> > >> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> >> > --- >> > drivers/usb/usbip/vudc_dev.c | 2 +- >> > 1 file changed, 1 insertion(+), 1 deletion(-) >> > >> > diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c >> > index 968471b..32ea604 100644 >> > --- a/drivers/usb/usbip/vudc_dev.c >> > +++ b/drivers/usb/usbip/vudc_dev.c >> > @@ -388,10 +388,10 @@ static int vep_dequeue(struct usb_ep *_ep, struct usb_request *_req) >> > unsigned long flags; >> > int ret = 0; >> > >> > - ep = to_vep(_ep); >> > if (!_ep) >> > return -EINVAL; >> >> Hmm. Linus's latest checks _ep and _req. Are you sure you are working >> with the latest tree? > > I checked with next-20161221 and its still there. This is for vep_dequeue() - Are you sure both linux-next and Linus's tree show the following: http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/usb/usbip/vudc_dev.c static int vep_dequeue(struct usb_ep *_ep, struct usb_request *_req) { struct vep *ep; struct vrequest *req; struct vudc *udc; struct vrequest *lst; unsigned long flags; int ret = -EINVAL; if (!_ep || !_req) return ret; ep = to_vep(_ep); req = to_vrequest(_req); udc = req->udc; if (!udc->driver) return -ESHUTDOWN; There are other routines in this file that don't check null. I am confused. thanks, -- Shuah ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usbip: vudc: check for NULL before use 2016-12-21 14:38 ` Shuah Khan @ 2016-12-21 15:02 ` Krzysztof Opasiak 2016-12-21 16:11 ` Sudip Mukherjee 1 sibling, 0 replies; 6+ messages in thread From: Krzysztof Opasiak @ 2016-12-21 15:02 UTC (permalink / raw) To: Shuah Khan, Sudip Mukherjee, Felipe Balbi Cc: Shuah Khan, Valentina Manea, Greg Kroah-Hartman, LKML, linux-usb, Shuah Khan, Krzysztof Opasiak Hi, On 12/21/2016 03:38 PM, Shuah Khan wrote: > Hi Sudip, > > On Wed, Dec 21, 2016 at 6:33 AM, Sudip Mukherjee > <sudipm.mukherjee@gmail.com> wrote: >> On Tue, Dec 20, 2016 at 07:31:44AM -0700, Shuah Khan wrote: >>> On 12/18/2016 03:44 PM, Sudip Mukherjee wrote: >>>> to_vep() is doing a container_of() on _ep. It is better to do the NULL >>>> check first and then use it. >>>> >>>> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> >>>> --- >>>> drivers/usb/usbip/vudc_dev.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c >>>> index 968471b..32ea604 100644 >>>> --- a/drivers/usb/usbip/vudc_dev.c >>>> +++ b/drivers/usb/usbip/vudc_dev.c >>>> @@ -388,10 +388,10 @@ static int vep_dequeue(struct usb_ep *_ep, struct usb_request *_req) >>>> unsigned long flags; >>>> int ret = 0; >>>> >>>> - ep = to_vep(_ep); >>>> if (!_ep) >>>> return -EINVAL; >>> >>> Hmm. Linus's latest checks _ep and _req. Are you sure you are working >>> with the latest tree? >> >> I checked with next-20161221 and its still there. > > This is for vep_dequeue() - Are you sure both linux-next and Linus's tree show > the following: > > http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/usb/usbip/vudc_dev.c > > static int vep_dequeue(struct usb_ep *_ep, struct usb_request *_req) > { > struct vep *ep; > struct vrequest *req; > struct vudc *udc; > struct vrequest *lst; > unsigned long flags; > int ret = -EINVAL; > > if (!_ep || !_req) > return ret; > > ep = to_vep(_ep); > req = to_vrequest(_req); > udc = req->udc; > > if (!udc->driver) > return -ESHUTDOWN; > > There are other routines in this file that don't check null. I am confused. > generally this file contains implementation of gadget/endpoint callbacks. Those methods will be called by udc-core with values passed from USB gadget (usually directly from function). I check other udc in kernel and there is no agreement if we should check in those callbacks if our params are NULL or not. I have also run through udc-core implementation and generally it doesn't check if params are NULL or not and just dereference some of them and pass them to our callbacks. I think that the best option is just to ask Felipe (USB gadget maintainer) if we should check this or not. @Felipe Should each UDC check if values passed to gadget/endpoint callbacks is not NULL or just simply dereference them? Best regards, -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usbip: vudc: check for NULL before use 2016-12-21 14:38 ` Shuah Khan 2016-12-21 15:02 ` Krzysztof Opasiak @ 2016-12-21 16:11 ` Sudip Mukherjee 1 sibling, 0 replies; 6+ messages in thread From: Sudip Mukherjee @ 2016-12-21 16:11 UTC (permalink / raw) To: Shuah Khan Cc: Shuah Khan, Valentina Manea, Greg Kroah-Hartman, LKML, linux-usb, Shuah Khan On Wed, Dec 21, 2016 at 07:38:21AM -0700, Shuah Khan wrote: > Hi Sudip, > > On Wed, Dec 21, 2016 at 6:33 AM, Sudip Mukherjee > <sudipm.mukherjee@gmail.com> wrote: > > On Tue, Dec 20, 2016 at 07:31:44AM -0700, Shuah Khan wrote: > >> On 12/18/2016 03:44 PM, Sudip Mukherjee wrote: > >> > to_vep() is doing a container_of() on _ep. It is better to do the NULL > >> > check first and then use it. > >> > > >> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > >> > --- > >> > drivers/usb/usbip/vudc_dev.c | 2 +- > >> > 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > >> > diff --git a/drivers/usb/usbip/vudc_dev.c b/drivers/usb/usbip/vudc_dev.c > >> > index 968471b..32ea604 100644 > >> > --- a/drivers/usb/usbip/vudc_dev.c > >> > +++ b/drivers/usb/usbip/vudc_dev.c > >> > @@ -388,10 +388,10 @@ static int vep_dequeue(struct usb_ep *_ep, struct usb_request *_req) > >> > unsigned long flags; > >> > int ret = 0; > >> > > >> > - ep = to_vep(_ep); > >> > if (!_ep) > >> > return -EINVAL; > >> > >> Hmm. Linus's latest checks _ep and _req. Are you sure you are working > >> with the latest tree? > > > > I checked with next-20161221 and its still there. > > This is for vep_dequeue() - Are you sure both linux-next and Linus's tree show > the following: This is for vep_set_halt_and_wedge(). I do not have any idea why the patch says its vep_dequeue(). I tried generating the patch again and it still shows as vep_dequeue(). But the line number 388 is correct and if you try to apply, it applies correctly. regards sudip ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-12-21 16:21 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2016-12-18 22:44 [PATCH] usbip: vudc: check for NULL before use Sudip Mukherjee 2016-12-20 14:31 ` Shuah Khan 2016-12-21 13:33 ` Sudip Mukherjee 2016-12-21 14:38 ` Shuah Khan 2016-12-21 15:02 ` Krzysztof Opasiak 2016-12-21 16:11 ` Sudip Mukherjee
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).