From: Byungchul Park <byungchul.park@lge.com>
To: peterz@infradead.org, mingo@kernel.org, neilb@suse.de,
nab@linux-iscsi.org, viro@zeniv.linux.org.uk
Cc: ying.huang@intel.com, oleg@redhat.com, shli@kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v3 8/9] sched: Don't reinvent the wheel but use existing llist API
Date: Tue, 14 Feb 2017 16:26:29 +0900 [thread overview]
Message-ID: <1487057190-25191-9-git-send-email-byungchul.park@lge.com> (raw)
In-Reply-To: <1487057190-25191-1-git-send-email-byungchul.park@lge.com>
Although llist provides proper APIs, they are not used. Make them used.
Signed-off-by: Byungchul Park <byungchul.park@lge.com>
---
kernel/sched/core.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index d01f9d0..8938125 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1773,7 +1773,7 @@ void sched_ttwu_pending(void)
{
struct rq *rq = this_rq();
struct llist_node *llist = llist_del_all(&rq->wake_list);
- struct task_struct *p;
+ struct task_struct *p, *t;
unsigned long flags;
struct rq_flags rf;
@@ -1783,17 +1783,8 @@ void sched_ttwu_pending(void)
raw_spin_lock_irqsave(&rq->lock, flags);
rq_pin_lock(rq, &rf);
- while (llist) {
- int wake_flags = 0;
-
- p = llist_entry(llist, struct task_struct, wake_entry);
- llist = llist_next(llist);
-
- if (p->sched_remote_wakeup)
- wake_flags = WF_MIGRATED;
-
- ttwu_do_activate(rq, p, wake_flags, &rf);
- }
+ llist_for_each_entry_safe(p, t, llist, wake_entry)
+ ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRATED : 0, &rf);
rq_unpin_lock(rq, &rf);
raw_spin_unlock_irqrestore(&rq->lock, flags);
--
1.9.1
next prev parent reply other threads:[~2017-02-14 7:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 7:26 [PATCH v3 0/9] Don't reinvent the wheel but use existing llist API Byungchul Park
2017-02-14 7:26 ` [PATCH v3 1/9] llist: Provide a safe version for llist_for_each Byungchul Park
2017-02-14 7:45 ` Huang, Ying
2017-03-02 22:59 ` Byungchul Park
2017-03-21 2:53 ` Byungchul Park
2017-02-14 7:26 ` [PATCH v3 2/9] bcache: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-03-02 23:16 ` Byungchul Park
2017-03-05 19:59 ` Jiri Kosina
2017-03-05 22:51 ` Byungchul Park
2017-03-05 22:54 ` Byungchul Park
2017-03-24 0:27 ` Byungchul Park
2017-02-14 7:26 ` [PATCH v3 3/9] raid5: " Byungchul Park
2017-02-16 22:48 ` Shaohua Li
2017-02-14 7:26 ` [PATCH v3 4/9] vhost/scsi: " Byungchul Park
2017-02-19 5:42 ` Nicholas A. Bellinger
2017-02-14 7:26 ` [PATCH v3 5/9] fput: " Byungchul Park
2017-02-14 17:44 ` Oleg Nesterov
2017-03-02 23:09 ` Byungchul Park
2017-02-14 7:26 ` [PATCH v3 6/9] namespace.c: " Byungchul Park
2017-02-14 7:26 ` [PATCH v3 7/9] irq_work: " Byungchul Park
2017-02-14 7:26 ` Byungchul Park [this message]
2017-02-22 5:04 ` [PATCH v3 8/9] sched: " Byungchul Park
2017-02-14 7:26 ` [PATCH v3 9/9] mm: " Byungchul Park
2017-05-02 8:03 ` [PATCH v3 0/9] " Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487057190-25191-9-git-send-email-byungchul.park@lge.com \
--to=byungchul.park@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nab@linux-iscsi.org \
--cc=neilb@suse.de \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=shli@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).