From: Shaohua Li <shli@kernel.org>
To: Byungchul Park <byungchul.park@lge.com>
Cc: peterz@infradead.org, mingo@kernel.org, neilb@suse.de,
nab@linux-iscsi.org, viro@zeniv.linux.org.uk,
ying.huang@intel.com, oleg@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/9] raid5: Don't reinvent the wheel but use existing llist API
Date: Thu, 16 Feb 2017 14:48:43 -0800 [thread overview]
Message-ID: <20170216224843.f76zr4fbyxgmb6t7@kernel.org> (raw)
In-Reply-To: <1487057190-25191-4-git-send-email-byungchul.park@lge.com>
On Tue, Feb 14, 2017 at 04:26:24PM +0900, Byungchul Park wrote:
> Although llist provides proper APIs, they are not used. Make them used.
This one has no dependence of previous patches, so I added to md tree.
Thanks,
Shaohua
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
> drivers/md/raid5.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
> index 36c13e4..22a0326 100644
> --- a/drivers/md/raid5.c
> +++ b/drivers/md/raid5.c
> @@ -353,17 +353,15 @@ static void release_inactive_stripe_list(struct r5conf *conf,
> static int release_stripe_list(struct r5conf *conf,
> struct list_head *temp_inactive_list)
> {
> - struct stripe_head *sh;
> + struct stripe_head *sh, *t;
> int count = 0;
> struct llist_node *head;
>
> head = llist_del_all(&conf->released_stripes);
> head = llist_reverse_order(head);
> - while (head) {
> + llist_for_each_entry_safe(sh, t, head, release_list) {
> int hash;
>
> - sh = llist_entry(head, struct stripe_head, release_list);
> - head = llist_next(head);
> /* sh could be readded after STRIPE_ON_RELEASE_LIST is cleard */
> smp_mb();
> clear_bit(STRIPE_ON_RELEASE_LIST, &sh->state);
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-02-16 22:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 7:26 [PATCH v3 0/9] Don't reinvent the wheel but use existing llist API Byungchul Park
2017-02-14 7:26 ` [PATCH v3 1/9] llist: Provide a safe version for llist_for_each Byungchul Park
2017-02-14 7:45 ` Huang, Ying
2017-03-02 22:59 ` Byungchul Park
2017-03-21 2:53 ` Byungchul Park
2017-02-14 7:26 ` [PATCH v3 2/9] bcache: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-03-02 23:16 ` Byungchul Park
2017-03-05 19:59 ` Jiri Kosina
2017-03-05 22:51 ` Byungchul Park
2017-03-05 22:54 ` Byungchul Park
2017-03-24 0:27 ` Byungchul Park
2017-02-14 7:26 ` [PATCH v3 3/9] raid5: " Byungchul Park
2017-02-16 22:48 ` Shaohua Li [this message]
2017-02-14 7:26 ` [PATCH v3 4/9] vhost/scsi: " Byungchul Park
2017-02-19 5:42 ` Nicholas A. Bellinger
2017-02-14 7:26 ` [PATCH v3 5/9] fput: " Byungchul Park
2017-02-14 17:44 ` Oleg Nesterov
2017-03-02 23:09 ` Byungchul Park
2017-02-14 7:26 ` [PATCH v3 6/9] namespace.c: " Byungchul Park
2017-02-14 7:26 ` [PATCH v3 7/9] irq_work: " Byungchul Park
2017-02-14 7:26 ` [PATCH v3 8/9] sched: " Byungchul Park
2017-02-22 5:04 ` Byungchul Park
2017-02-14 7:26 ` [PATCH v3 9/9] mm: " Byungchul Park
2017-05-02 8:03 ` [PATCH v3 0/9] " Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170216224843.f76zr4fbyxgmb6t7@kernel.org \
--to=shli@kernel.org \
--cc=byungchul.park@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nab@linux-iscsi.org \
--cc=neilb@suse.de \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).