From: Oleg Nesterov <oleg@redhat.com>
To: Byungchul Park <byungchul.park@lge.com>
Cc: peterz@infradead.org, mingo@kernel.org, neilb@suse.de,
nab@linux-iscsi.org, viro@zeniv.linux.org.uk,
ying.huang@intel.com, shli@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/9] fput: Don't reinvent the wheel but use existing llist API
Date: Tue, 14 Feb 2017 18:44:44 +0100 [thread overview]
Message-ID: <20170214174443.GA13110@redhat.com> (raw)
In-Reply-To: <1487057190-25191-6-git-send-email-byungchul.park@lge.com>
On 02/14, Byungchul Park wrote:
>
> Although llist provides proper APIs, they are not used. Make them used.
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> ---
> fs/file_table.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/fs/file_table.c b/fs/file_table.c
> index 6d982b5..3209da2 100644
> --- a/fs/file_table.c
> +++ b/fs/file_table.c
> @@ -231,12 +231,10 @@ static void __fput(struct file *file)
> static void delayed_fput(struct work_struct *unused)
> {
> struct llist_node *node = llist_del_all(&delayed_fput_list);
> - struct llist_node *next;
> + struct file *f, *t;
>
> - for (; node; node = next) {
> - next = llist_next(node);
> - __fput(llist_entry(node, struct file, f_u.fu_llist));
> - }
> + llist_for_each_entry_safe(f, t, node, f_u.fu_llist)
> + __fput(f);
> }
>
> static void ____fput(struct callback_head *work)
> @@ -310,7 +308,7 @@ void put_filp(struct file *file)
> }
>
> void __init files_init(void)
> -{
> +{
> filp_cachep = kmem_cache_create("filp", sizeof(struct file), 0,
> SLAB_HWCACHE_ALIGN | SLAB_PANIC, NULL);
> percpu_counter_init(&nr_files, 0, GFP_KERNEL);
> @@ -329,4 +327,4 @@ void __init files_maxfiles_init(void)
> n = ((totalram_pages - memreserve) * (PAGE_SIZE / 1024)) / 10;
>
> files_stat.max_files = max_t(unsigned long, n, NR_FILE);
> -}
> +}
> --
> 1.9.1
>
next prev parent reply other threads:[~2017-02-14 17:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 7:26 [PATCH v3 0/9] Don't reinvent the wheel but use existing llist API Byungchul Park
2017-02-14 7:26 ` [PATCH v3 1/9] llist: Provide a safe version for llist_for_each Byungchul Park
2017-02-14 7:45 ` Huang, Ying
2017-03-02 22:59 ` Byungchul Park
2017-03-21 2:53 ` Byungchul Park
2017-02-14 7:26 ` [PATCH v3 2/9] bcache: Don't reinvent the wheel but use existing llist API Byungchul Park
2017-03-02 23:16 ` Byungchul Park
2017-03-05 19:59 ` Jiri Kosina
2017-03-05 22:51 ` Byungchul Park
2017-03-05 22:54 ` Byungchul Park
2017-03-24 0:27 ` Byungchul Park
2017-02-14 7:26 ` [PATCH v3 3/9] raid5: " Byungchul Park
2017-02-16 22:48 ` Shaohua Li
2017-02-14 7:26 ` [PATCH v3 4/9] vhost/scsi: " Byungchul Park
2017-02-19 5:42 ` Nicholas A. Bellinger
2017-02-14 7:26 ` [PATCH v3 5/9] fput: " Byungchul Park
2017-02-14 17:44 ` Oleg Nesterov [this message]
2017-03-02 23:09 ` Byungchul Park
2017-02-14 7:26 ` [PATCH v3 6/9] namespace.c: " Byungchul Park
2017-02-14 7:26 ` [PATCH v3 7/9] irq_work: " Byungchul Park
2017-02-14 7:26 ` [PATCH v3 8/9] sched: " Byungchul Park
2017-02-22 5:04 ` Byungchul Park
2017-02-14 7:26 ` [PATCH v3 9/9] mm: " Byungchul Park
2017-05-02 8:03 ` [PATCH v3 0/9] " Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214174443.GA13110@redhat.com \
--to=oleg@redhat.com \
--cc=byungchul.park@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nab@linux-iscsi.org \
--cc=neilb@suse.de \
--cc=peterz@infradead.org \
--cc=shli@kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).