* [PATCH] tracing: Fix code comment for ftrace_ops_get_func
@ 2017-02-22 0:29 Chunyu Hu
2017-02-27 16:08 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Chunyu Hu @ 2017-02-22 0:29 UTC (permalink / raw)
To: rostedt; +Cc: mingo, linux-kernel
There is no function 'ftrace_ops_recurs_func' existing in the code, it
should be ftrace_ops_assist_func. Fix the comment to avoid misleading.
Signed-off-by: Chunyu Hu <chuhu@redhat.com>
---
kernel/trace/ftrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 0c06093..fd84f2e 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -5487,7 +5487,7 @@ static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip,
* Normally the mcount trampoline will call the ops->func, but there
* are times that it should not. For example, if the ops does not
* have its own recursion protection, then it should call the
- * ftrace_ops_recurs_func() instead.
+ * ftrace_ops_assist_func() instead.
*
* Returns the function that the trampoline should call for @ops.
*/
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tracing: Fix code comment for ftrace_ops_get_func
2017-02-22 0:29 [PATCH] tracing: Fix code comment for ftrace_ops_get_func Chunyu Hu
@ 2017-02-27 16:08 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2017-02-27 16:08 UTC (permalink / raw)
To: Chunyu Hu; +Cc: mingo, linux-kernel
On Wed, 22 Feb 2017 08:29:26 +0800
Chunyu Hu <chuhu@redhat.com> wrote:
> There is no function 'ftrace_ops_recurs_func' existing in the code, it
> should be ftrace_ops_assist_func. Fix the comment to avoid misleading.
Applied, thanks!
I'm not sure it will go in this merge window. It might, I'll have to
see what else there is.
-- Steve
>
> Signed-off-by: Chunyu Hu <chuhu@redhat.com>
> ---
> kernel/trace/ftrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 0c06093..fd84f2e 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -5487,7 +5487,7 @@ static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip,
> * Normally the mcount trampoline will call the ops->func, but there
> * are times that it should not. For example, if the ops does not
> * have its own recursion protection, then it should call the
> - * ftrace_ops_recurs_func() instead.
> + * ftrace_ops_assist_func() instead.
> *
> * Returns the function that the trampoline should call for @ops.
> */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-27 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-22 0:29 [PATCH] tracing: Fix code comment for ftrace_ops_get_func Chunyu Hu
2017-02-27 16:08 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).