* [PATCH] staging/ks7010: formatting updates. @ 2017-02-21 4:20 Matthew Giassa 2017-02-21 7:59 ` Geert Uytterhoeven ` (3 more replies) 0 siblings, 4 replies; 31+ messages in thread From: Matthew Giassa @ 2017-02-21 4:20 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, Matthew Giassa Please pardon the earlier e-mail which was missing the changelog text. Wrapping complex macros with parentheses to remove checkpatch errors. Some additional style changes to appease checkpatch. --- drivers/staging/ks7010/ks_wlan_ioctl.h | 80 +++++++++++++++++----------------- 1 file changed, 41 insertions(+), 39 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 84554b6..00eec18 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -1,6 +1,6 @@ /* * Driver for KeyStream 11b/g wireless LAN - * + * * Copyright (c) 2005-2008 KeyStream Corp. * Copyright (C) 2009 Renesas Technology Corp. * @@ -8,60 +8,62 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ - #ifndef _KS_WLAN_IOCTL_H #define _KS_WLAN_IOCTL_H #include <linux/wireless.h> -/* The low order bit identify a SET (0) or a GET (1) ioctl. */ +/* The low order bit identify a SET (0) or a GET (1) ioctl. */ -/* SIOCIWFIRSTPRIV+0 */ -/* former KS_WLAN_GET_DRIVER_VERSION SIOCIWFIRSTPRIV+1 */ -/* SIOCIWFIRSTPRIV+2 */ -#define KS_WLAN_GET_FIRM_VERSION SIOCIWFIRSTPRIV+3 +/* (SIOCIWFIRSTPRIV + 0) */ +/* Former KS_WLAN_GET_DRIVER_VERSION (SIOCIWFIRSTPRIV + 1) */ +/* (SIOCIWFIRSTPRIV + 2) */ +#define KS_WLAN_GET_FIRM_VERSION (SIOCIWFIRSTPRIV + 3) #ifdef WPS -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV+4 -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV+5 -#define KS_WLAN_SET_WPS_PROBE_REQ SIOCIWFIRSTPRIV+6 +#define KS_WLAN_SET_WPS_ENABLE (SIOCIWFIRSTPRIV + 4) +#define KS_WLAN_GET_WPS_ENABLE (SIOCIWFIRSTPRIV + 5) +#define KS_WLAN_SET_WPS_PROBE_REQ (SIOCIWFIRSTPRIV + 6) #endif -#define KS_WLAN_GET_EEPROM_CKSUM SIOCIWFIRSTPRIV+7 -#define KS_WLAN_SET_PREAMBLE SIOCIWFIRSTPRIV+8 -#define KS_WLAN_GET_PREAMBLE SIOCIWFIRSTPRIV+9 -#define KS_WLAN_SET_POWER_SAVE SIOCIWFIRSTPRIV+10 -#define KS_WLAN_GET_POWER_SAVE SIOCIWFIRSTPRIV+11 -#define KS_WLAN_SET_SCAN_TYPE SIOCIWFIRSTPRIV+12 -#define KS_WLAN_GET_SCAN_TYPE SIOCIWFIRSTPRIV+13 -#define KS_WLAN_SET_RX_GAIN SIOCIWFIRSTPRIV+14 -#define KS_WLAN_GET_RX_GAIN SIOCIWFIRSTPRIV+15 -#define KS_WLAN_HOSTT SIOCIWFIRSTPRIV+16 /* unused */ -//#define KS_WLAN_SET_REGION SIOCIWFIRSTPRIV+17 -#define KS_WLAN_SET_BEACON_LOST SIOCIWFIRSTPRIV+18 -#define KS_WLAN_GET_BEACON_LOST SIOCIWFIRSTPRIV+19 +#define KS_WLAN_GET_EEPROM_CKSUM (SIOCIWFIRSTPRIV + 7) +#define KS_WLAN_SET_PREAMBLE (SIOCIWFIRSTPRIV + 8) +#define KS_WLAN_GET_PREAMBLE (SIOCIWFIRSTPRIV + 9) +#define KS_WLAN_SET_POWER_SAVE (SIOCIWFIRSTPRIV + 10) +#define KS_WLAN_GET_POWER_SAVE (SIOCIWFIRSTPRIV + 11) +#define KS_WLAN_SET_SCAN_TYPE (SIOCIWFIRSTPRIV + 12) +#define KS_WLAN_GET_SCAN_TYPE (SIOCIWFIRSTPRIV + 13) +#define KS_WLAN_SET_RX_GAIN (SIOCIWFIRSTPRIV + 14) +#define KS_WLAN_GET_RX_GAIN (SIOCIWFIRSTPRIV + 15) +#define KS_WLAN_HOSTT (SIOCIWFIRSTPRIV + 16) /* unused */ +/*#define KS_WLAN_SET_REGION (SIOCIWFIRSTPRIV + 17) */ +#define KS_WLAN_SET_BEACON_LOST (SIOCIWFIRSTPRIV + 18) +#define KS_WLAN_GET_BEACON_LOST (SIOCIWFIRSTPRIV + 19) -#define KS_WLAN_SET_TX_GAIN SIOCIWFIRSTPRIV+20 -#define KS_WLAN_GET_TX_GAIN SIOCIWFIRSTPRIV+21 +#define KS_WLAN_SET_TX_GAIN (SIOCIWFIRSTPRIV + 20) +#define KS_WLAN_GET_TX_GAIN (SIOCIWFIRSTPRIV + 21) -/* for KS7010 */ -#define KS_WLAN_SET_PHY_TYPE SIOCIWFIRSTPRIV+22 -#define KS_WLAN_GET_PHY_TYPE SIOCIWFIRSTPRIV+23 -#define KS_WLAN_SET_CTS_MODE SIOCIWFIRSTPRIV+24 -#define KS_WLAN_GET_CTS_MODE SIOCIWFIRSTPRIV+25 -/* SIOCIWFIRSTPRIV+26 */ -/* SIOCIWFIRSTPRIV+27 */ -#define KS_WLAN_SET_SLEEP_MODE SIOCIWFIRSTPRIV+28 /* sleep mode */ -#define KS_WLAN_GET_SLEEP_MODE SIOCIWFIRSTPRIV+29 /* sleep mode */ -/* SIOCIWFIRSTPRIV+30 */ -/* SIOCIWFIRSTPRIV+31 */ +/* For KS7010. */ +#define KS_WLAN_SET_PHY_TYPE (SIOCIWFIRSTPRIV + 22) +#define KS_WLAN_GET_PHY_TYPE (SIOCIWFIRSTPRIV + 23) +#define KS_WLAN_SET_CTS_MODE (SIOCIWFIRSTPRIV + 24) +#define KS_WLAN_GET_CTS_MODE (SIOCIWFIRSTPRIV + 25) +/* (SIOCIWFIRSTPRIV + 26) */ +/* (SIOCIWFIRSTPRIV + 27) */ +#define KS_WLAN_SET_SLEEP_MODE (SIOCIWFIRSTPRIV + 28) /* sleep mode */ +#define KS_WLAN_GET_SLEEP_MODE (SIOCIWFIRSTPRIV + 29) /* sleep mode */ +/* (SIOCIWFIRSTPRIV + 30) */ +/* (SIOCIWFIRSTPRIV + 31) */ #ifdef __KERNEL__ #include "ks_wlan.h" #include <linux/netdevice.h> -int ks_wlan_read_config_file(struct ks_wlan_private *priv); -int ks_wlan_setup_parameter(struct ks_wlan_private *priv, - unsigned int commit_flag); +int ks_wlan_read_config_file( + struct ks_wlan_private *priv); +int ks_wlan_setup_parameter( + struct ks_wlan_private *priv, + unsigned int commit_flag); #endif /* __KERNEL__ */ #endif /* _KS_WLAN_IOCTL_H */ + -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* Re: [PATCH] staging/ks7010: formatting updates. 2017-02-21 4:20 [PATCH] staging/ks7010: formatting updates Matthew Giassa @ 2017-02-21 7:59 ` Geert Uytterhoeven 2017-02-21 14:12 ` Matthew Giassa 2017-02-22 21:52 ` [PATCHv2] Checkpatch fixes for staging/drivers/ks7010 Matthew Giassa ` (2 subsequent siblings) 3 siblings, 1 reply; 31+ messages in thread From: Geert Uytterhoeven @ 2017-02-21 7:59 UTC (permalink / raw) To: Matthew Giassa Cc: Wolfram Sang, Greg KH, linux-kernel, Linux-Renesas, driverdevel Hi Matthew, On Tue, Feb 21, 2017 at 5:20 AM, Matthew Giassa <matthew@giassa.net> wrote: > Please pardon the earlier e-mail which was missing the changelog text. This line should be between the "---" and the diffstat below. > Some additional style changes to appease checkpatch. Which additional style changes? > --- > drivers/staging/ks7010/ks_wlan_ioctl.h | 80 +++++++++++++++++----------------- > 1 file changed, 41 insertions(+), 39 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h > index 84554b6..00eec18 100644 > --- a/drivers/staging/ks7010/ks_wlan_ioctl.h > +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h > #include "ks_wlan.h" > #include <linux/netdevice.h> > > -int ks_wlan_read_config_file(struct ks_wlan_private *priv); > -int ks_wlan_setup_parameter(struct ks_wlan_private *priv, > - unsigned int commit_flag); > +int ks_wlan_read_config_file( > + struct ks_wlan_private *priv); > +int ks_wlan_setup_parameter( > + struct ks_wlan_private *priv, > + unsigned int commit_flag); Really? If checkpatch complained about the above, you should file a bug report against checkpatch. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH] staging/ks7010: formatting updates. 2017-02-21 7:59 ` Geert Uytterhoeven @ 2017-02-21 14:12 ` Matthew Giassa 2017-02-21 14:22 ` Geert Uytterhoeven 0 siblings, 1 reply; 31+ messages in thread From: Matthew Giassa @ 2017-02-21 14:12 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Wolfram Sang, Greg KH, linux-kernel, Linux-Renesas, driverdevel * Geert Uytterhoeven <geert@linux-m68k.org> [2017-02-21 08:59:18 +0100]: Hi Geert, >On Tue, Feb 21, 2017 at 5:20 AM, Matthew Giassa <matthew@giassa.net> wrote: >> Please pardon the earlier e-mail which was missing the changelog text. > >This line should be between the "---" and the diffstat below. > Thank you. >> Some additional style changes to appease checkpatch. > >Which additional style changes? > * Aligning function parameters in the function prototypes. * Removing "double newlines". where checkpatch warns about them. * Spaces between macro names, '+', and integer literals. * Swapped out some line comments with C-style equivalent. * Removing trailing spaces. >> --- >> drivers/staging/ks7010/ks_wlan_ioctl.h | 80 +++++++++++++++++----------------- >> 1 file changed, 41 insertions(+), 39 deletions(-) >> >> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h >> index 84554b6..00eec18 100644 >> --- a/drivers/staging/ks7010/ks_wlan_ioctl.h >> +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h > >> #include "ks_wlan.h" >> #include <linux/netdevice.h> >> >> -int ks_wlan_read_config_file(struct ks_wlan_private *priv); >> -int ks_wlan_setup_parameter(struct ks_wlan_private *priv, >> - unsigned int commit_flag); >> +int ks_wlan_read_config_file( >> + struct ks_wlan_private *priv); >> +int ks_wlan_setup_parameter( >> + struct ks_wlan_private *priv, >> + unsigned int commit_flag); > >Really? >If checkpatch complained about the above, you should file a bug report >against checkpatch. > >Gr{oetje,eeting}s, It seems to be a very deliberate message from checkpatch, complaining about the alignment of the beginning of individual function parameters in the prototype. The only two configurations which appeased it was the changes I put in above, or a combination of hard-tabs (8-wide, noexpand) and spaces, which I thought was ugly. -- Matthew ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH] staging/ks7010: formatting updates. 2017-02-21 14:12 ` Matthew Giassa @ 2017-02-21 14:22 ` Geert Uytterhoeven 2017-02-21 17:32 ` Matthew Giassa 0 siblings, 1 reply; 31+ messages in thread From: Geert Uytterhoeven @ 2017-02-21 14:22 UTC (permalink / raw) To: Matthew Giassa Cc: Wolfram Sang, Greg KH, linux-kernel, Linux-Renesas, driverdevel Hi Matthew, On Tue, Feb 21, 2017 at 3:12 PM, Matthew Giassa <matthew@giassa.net> wrote: >>> drivers/staging/ks7010/ks_wlan_ioctl.h | 80 >>> +++++++++++++++++----------------- >>> 1 file changed, 41 insertions(+), 39 deletions(-) >>> >>> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h >>> b/drivers/staging/ks7010/ks_wlan_ioctl.h >>> index 84554b6..00eec18 100644 >>> --- a/drivers/staging/ks7010/ks_wlan_ioctl.h >>> +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h >> >> >>> #include "ks_wlan.h" >>> #include <linux/netdevice.h> >>> >>> -int ks_wlan_read_config_file(struct ks_wlan_private *priv); >>> -int ks_wlan_setup_parameter(struct ks_wlan_private *priv, >>> - unsigned int commit_flag); >>> +int ks_wlan_read_config_file( >>> + struct ks_wlan_private *priv); >>> +int ks_wlan_setup_parameter( >>> + struct ks_wlan_private *priv, >>> + unsigned int commit_flag); >> >> >> Really? >> If checkpatch complained about the above, you should file a bug report >> against checkpatch. > > It seems to be a very deliberate message from checkpatch, complaining > about the alignment of the beginning of individual function parameters > in the prototype. The only two configurations which appeased it was the > changes I put in above, or a combination of hard-tabs (8-wide, noexpand) > and spaces, which I thought was ugly. The first declaration fit nicely on a single line. The second one indeed has a few spaces instead of TABs in the continuation line. But that can be fixed easily, without moving the first parameter to a continuation line. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH] staging/ks7010: formatting updates. 2017-02-21 14:22 ` Geert Uytterhoeven @ 2017-02-21 17:32 ` Matthew Giassa 2017-02-21 18:47 ` Joe Perches 0 siblings, 1 reply; 31+ messages in thread From: Matthew Giassa @ 2017-02-21 17:32 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Wolfram Sang, Greg KH, linux-kernel, Linux-Renesas, driverdevel * Geert Uytterhoeven <geert@linux-m68k.org> [2017-02-21 15:22:10 +0100]: >The first declaration fit nicely on a single line. >The second one indeed has a few spaces instead of TABs in the >continuation line. But that can be fixed easily, without moving the >first parameter to a continuation line. What would the proposed fix be? A combination of spaces and hard-tabs? I don't see checkpatch complaining about it, so that could work too. -- -Matthew Giassa e:<matthew@giassa.net> ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH] staging/ks7010: formatting updates. 2017-02-21 17:32 ` Matthew Giassa @ 2017-02-21 18:47 ` Joe Perches 2017-02-21 19:48 ` Matthew Giassa 0 siblings, 1 reply; 31+ messages in thread From: Joe Perches @ 2017-02-21 18:47 UTC (permalink / raw) To: Matthew Giassa, Geert Uytterhoeven Cc: Wolfram Sang, Greg KH, linux-kernel, Linux-Renesas, driverdevel On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: > * Geert Uytterhoeven <geert@linux-m68k.org> [2017-02-21 15:22:10 +0100]: > > > The first declaration fit nicely on a single line. > > The second one indeed has a few spaces instead of TABs in the > > continuation line. But that can be fixed easily, without moving the > > first parameter to a continuation line. > > What would the proposed fix be? A combination of spaces and hard-tabs? I > don't see checkpatch complaining about it, so that could work too. Maximal initial tabs, followed by required spaces to align to open parenthesis So from: int ks_wlan_setup_parameter(struct ks_wlan_private *priv, unsigned int commit_flag); (2 tabs followed by 13 spaces) to: int ks_wlan_setup_parameter(struct ks_wlan_private *priv, unsigned int commit_flag); (3 tabs followed by 4 spaces) ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH] staging/ks7010: formatting updates. 2017-02-21 18:47 ` Joe Perches @ 2017-02-21 19:48 ` Matthew Giassa 2017-02-21 20:02 ` Joe Perches 0 siblings, 1 reply; 31+ messages in thread From: Matthew Giassa @ 2017-02-21 19:48 UTC (permalink / raw) To: Joe Perches Cc: Geert Uytterhoeven, Wolfram Sang, Greg KH, linux-kernel, Linux-Renesas, driverdevel * Joe Perches <joe@perches.com> [2017-02-21 10:47:31 -0800]: >On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: >> * Geert Uytterhoeven <geert@linux-m68k.org> [2017-02-21 15:22:10 +0100]: >> >> > The first declaration fit nicely on a single line. >> > The second one indeed has a few spaces instead of TABs in the >> > continuation line. But that can be fixed easily, without moving the >> > first parameter to a continuation line. >> >> What would the proposed fix be? A combination of spaces and hard-tabs? I >> don't see checkpatch complaining about it, so that could work too. > >Maximal initial tabs, followed by required spaces to align >to open parenthesis > Thank you Joe. I will change it accordingly. Is there a supplementary style guide that covers these finer details? Cheers! -- -Matthew Giassa e:<matthew@giassa.net> ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCH] staging/ks7010: formatting updates. 2017-02-21 19:48 ` Matthew Giassa @ 2017-02-21 20:02 ` Joe Perches 0 siblings, 0 replies; 31+ messages in thread From: Joe Perches @ 2017-02-21 20:02 UTC (permalink / raw) To: Matthew Giassa Cc: Geert Uytterhoeven, Wolfram Sang, Greg KH, linux-kernel, Linux-Renesas, driverdevel On Tue, 2017-02-21 at 11:48 -0800, Matthew Giassa wrote: > * Joe Perches <joe@perches.com> [2017-02-21 10:47:31 -0800]: > > > On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote: > > > * Geert Uytterhoeven <geert@linux-m68k.org> [2017-02-21 15:22:10 +0100]: > > > > > > > The first declaration fit nicely on a single line. > > > > The second one indeed has a few spaces instead of TABs in the > > > > continuation line. But that can be fixed easily, without moving the > > > > first parameter to a continuation line. > > > > > > What would the proposed fix be? A combination of spaces and hard-tabs? I > > > don't see checkpatch complaining about it, so that could work too. > > > > Maximal initial tabs, followed by required spaces to align > > to open parenthesis > > > > Thank you Joe. I will change it accordingly. Is there a supplementary > style guide that covers these finer details? No, coding style just says Descendants are always substantially shorter than the parent and are placed substantially to the right However alignment to the open parenthesis is a pretty common style. ^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCHv2] Checkpatch fixes for staging/drivers/ks7010. 2017-02-21 4:20 [PATCH] staging/ks7010: formatting updates Matthew Giassa 2017-02-21 7:59 ` Geert Uytterhoeven @ 2017-02-22 21:52 ` Matthew Giassa 2017-02-24 17:12 ` Greg KH 2017-02-27 2:00 ` [PATCHv3] checkpatch fixes for drivers/staging/ks7010/ks_wlan_ioctl.h Matthew Giassa 2017-03-15 2:25 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa 3 siblings, 1 reply; 31+ messages in thread From: Matthew Giassa @ 2017-02-22 21:52 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, Matthew Giassa Wrapping complex macros with parentheses. Adding extra spaces between macros and integer literals. Indentation changes to remove checkpatch warnings. Swapping out C++-style comments with C-style comments. Signed-off-by: Matthew Giassa <matthew@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 74 +++++++++++++++++----------------- 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 84554b6..b0166c2 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -1,6 +1,6 @@ /* * Driver for KeyStream 11b/g wireless LAN - * + * * Copyright (c) 2005-2008 KeyStream Corp. * Copyright (C) 2009 Renesas Technology Corp. * @@ -8,50 +8,49 @@ * it under the terms of the GNU General Public License version 2 as * published by the Free Software Foundation. */ - #ifndef _KS_WLAN_IOCTL_H #define _KS_WLAN_IOCTL_H #include <linux/wireless.h> -/* The low order bit identify a SET (0) or a GET (1) ioctl. */ +/* The low order bit identify a SET (0) or a GET (1) ioctl. */ -/* SIOCIWFIRSTPRIV+0 */ -/* former KS_WLAN_GET_DRIVER_VERSION SIOCIWFIRSTPRIV+1 */ -/* SIOCIWFIRSTPRIV+2 */ -#define KS_WLAN_GET_FIRM_VERSION SIOCIWFIRSTPRIV+3 +/* (SIOCIWFIRSTPRIV + 0) */ +/* Former KS_WLAN_GET_DRIVER_VERSION (SIOCIWFIRSTPRIV + 1) */ +/* (SIOCIWFIRSTPRIV + 2) */ +#define KS_WLAN_GET_FIRM_VERSION (SIOCIWFIRSTPRIV + 3) #ifdef WPS -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV+4 -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV+5 -#define KS_WLAN_SET_WPS_PROBE_REQ SIOCIWFIRSTPRIV+6 +#define KS_WLAN_SET_WPS_ENABLE (SIOCIWFIRSTPRIV + 4) +#define KS_WLAN_GET_WPS_ENABLE (SIOCIWFIRSTPRIV + 5) +#define KS_WLAN_SET_WPS_PROBE_REQ (SIOCIWFIRSTPRIV + 6) #endif -#define KS_WLAN_GET_EEPROM_CKSUM SIOCIWFIRSTPRIV+7 -#define KS_WLAN_SET_PREAMBLE SIOCIWFIRSTPRIV+8 -#define KS_WLAN_GET_PREAMBLE SIOCIWFIRSTPRIV+9 -#define KS_WLAN_SET_POWER_SAVE SIOCIWFIRSTPRIV+10 -#define KS_WLAN_GET_POWER_SAVE SIOCIWFIRSTPRIV+11 -#define KS_WLAN_SET_SCAN_TYPE SIOCIWFIRSTPRIV+12 -#define KS_WLAN_GET_SCAN_TYPE SIOCIWFIRSTPRIV+13 -#define KS_WLAN_SET_RX_GAIN SIOCIWFIRSTPRIV+14 -#define KS_WLAN_GET_RX_GAIN SIOCIWFIRSTPRIV+15 -#define KS_WLAN_HOSTT SIOCIWFIRSTPRIV+16 /* unused */ -//#define KS_WLAN_SET_REGION SIOCIWFIRSTPRIV+17 -#define KS_WLAN_SET_BEACON_LOST SIOCIWFIRSTPRIV+18 -#define KS_WLAN_GET_BEACON_LOST SIOCIWFIRSTPRIV+19 +#define KS_WLAN_GET_EEPROM_CKSUM (SIOCIWFIRSTPRIV + 7) +#define KS_WLAN_SET_PREAMBLE (SIOCIWFIRSTPRIV + 8) +#define KS_WLAN_GET_PREAMBLE (SIOCIWFIRSTPRIV + 9) +#define KS_WLAN_SET_POWER_SAVE (SIOCIWFIRSTPRIV + 10) +#define KS_WLAN_GET_POWER_SAVE (SIOCIWFIRSTPRIV + 11) +#define KS_WLAN_SET_SCAN_TYPE (SIOCIWFIRSTPRIV + 12) +#define KS_WLAN_GET_SCAN_TYPE (SIOCIWFIRSTPRIV + 13) +#define KS_WLAN_SET_RX_GAIN (SIOCIWFIRSTPRIV + 14) +#define KS_WLAN_GET_RX_GAIN (SIOCIWFIRSTPRIV + 15) +#define KS_WLAN_HOSTT (SIOCIWFIRSTPRIV + 16) /* unused */ +/*#define KS_WLAN_SET_REGION (SIOCIWFIRSTPRIV + 17) */ +#define KS_WLAN_SET_BEACON_LOST (SIOCIWFIRSTPRIV + 18) +#define KS_WLAN_GET_BEACON_LOST (SIOCIWFIRSTPRIV + 19) -#define KS_WLAN_SET_TX_GAIN SIOCIWFIRSTPRIV+20 -#define KS_WLAN_GET_TX_GAIN SIOCIWFIRSTPRIV+21 +#define KS_WLAN_SET_TX_GAIN (SIOCIWFIRSTPRIV + 20) +#define KS_WLAN_GET_TX_GAIN (SIOCIWFIRSTPRIV + 21) -/* for KS7010 */ -#define KS_WLAN_SET_PHY_TYPE SIOCIWFIRSTPRIV+22 -#define KS_WLAN_GET_PHY_TYPE SIOCIWFIRSTPRIV+23 -#define KS_WLAN_SET_CTS_MODE SIOCIWFIRSTPRIV+24 -#define KS_WLAN_GET_CTS_MODE SIOCIWFIRSTPRIV+25 -/* SIOCIWFIRSTPRIV+26 */ -/* SIOCIWFIRSTPRIV+27 */ -#define KS_WLAN_SET_SLEEP_MODE SIOCIWFIRSTPRIV+28 /* sleep mode */ -#define KS_WLAN_GET_SLEEP_MODE SIOCIWFIRSTPRIV+29 /* sleep mode */ -/* SIOCIWFIRSTPRIV+30 */ -/* SIOCIWFIRSTPRIV+31 */ +/* For KS7010. */ +#define KS_WLAN_SET_PHY_TYPE (SIOCIWFIRSTPRIV + 22) +#define KS_WLAN_GET_PHY_TYPE (SIOCIWFIRSTPRIV + 23) +#define KS_WLAN_SET_CTS_MODE (SIOCIWFIRSTPRIV + 24) +#define KS_WLAN_GET_CTS_MODE (SIOCIWFIRSTPRIV + 25) +/* (SIOCIWFIRSTPRIV + 26) */ +/* (SIOCIWFIRSTPRIV + 27) */ +#define KS_WLAN_SET_SLEEP_MODE (SIOCIWFIRSTPRIV + 28) /* sleep mode */ +#define KS_WLAN_GET_SLEEP_MODE (SIOCIWFIRSTPRIV + 29) /* sleep mode */ +/* (SIOCIWFIRSTPRIV + 30) */ +/* (SIOCIWFIRSTPRIV + 31) */ #ifdef __KERNEL__ @@ -60,8 +59,9 @@ int ks_wlan_read_config_file(struct ks_wlan_private *priv); int ks_wlan_setup_parameter(struct ks_wlan_private *priv, - unsigned int commit_flag); + unsigned int commit_flag); #endif /* __KERNEL__ */ #endif /* _KS_WLAN_IOCTL_H */ + -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* Re: [PATCHv2] Checkpatch fixes for staging/drivers/ks7010. 2017-02-22 21:52 ` [PATCHv2] Checkpatch fixes for staging/drivers/ks7010 Matthew Giassa @ 2017-02-24 17:12 ` Greg KH 0 siblings, 0 replies; 31+ messages in thread From: Greg KH @ 2017-02-24 17:12 UTC (permalink / raw) To: Matthew Giassa; +Cc: wsa, linux-renesas-soc, devel, linux-kernel On Wed, Feb 22, 2017 at 01:52:58PM -0800, Matthew Giassa wrote: > Wrapping complex macros with parentheses. > Adding extra spaces between macros and integer literals. > Indentation changes to remove checkpatch warnings. > Swapping out C++-style comments with C-style comments. > > Signed-off-by: Matthew Giassa <matthew@giassa.net> > --- > drivers/staging/ks7010/ks_wlan_ioctl.h | 74 +++++++++++++++++----------------- > 1 file changed, 37 insertions(+), 37 deletions(-) Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch did many different things all at once, making it difficult to review. All Linux kernel patches need to only do one thing at a time. If you need to do multiple things (such as clean up all coding style issues in a file/driver), do it in a sequence of patches, each one doing only one thing. This will make it easier to review the patches to ensure that they are correct, and to help alleviate any merge issues that larger patches can cause. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot ^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCHv3] checkpatch fixes for drivers/staging/ks7010/ks_wlan_ioctl.h 2017-02-21 4:20 [PATCH] staging/ks7010: formatting updates Matthew Giassa 2017-02-21 7:59 ` Geert Uytterhoeven 2017-02-22 21:52 ` [PATCHv2] Checkpatch fixes for staging/drivers/ks7010 Matthew Giassa @ 2017-02-27 2:00 ` Matthew Giassa 2017-02-27 2:00 ` [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses Matthew Giassa 2017-03-15 2:25 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa 3 siblings, 1 reply; 31+ messages in thread From: Matthew Giassa @ 2017-02-27 2:00 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel Assembling a set of patches to address all outstanding checkpatch issues in staging/drivers/ks7010/ks_wlan_ioctl.h to replace my earlier v2 work which attempted to do all of this in a single patch. This includes wrapping macros with complex values in parentheses, removing extraneous/mixed whitespace characters, and changing the alignment of parameters in function prototypes. ^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses. 2017-02-27 2:00 ` [PATCHv3] checkpatch fixes for drivers/staging/ks7010/ks_wlan_ioctl.h Matthew Giassa @ 2017-02-27 2:00 ` Matthew Giassa 2017-02-27 2:00 ` [PATCHv3 2/4] Removing trailing whitespace in comment block Matthew Giassa 2017-02-27 5:56 ` [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses Tobin C. Harding 0 siblings, 2 replies; 31+ messages in thread From: Matthew Giassa @ 2017-02-27 2:00 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +++++++++++++++++----------------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 8e62b10..47c8015 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -15,43 +15,43 @@ #include <linux/wireless.h> /* The low order bit identify a SET (0) or a GET (1) ioctl. */ -/* SIOCIWFIRSTPRIV + 0 */ -/* former KS_WLAN_GET_DRIVER_VERSION SIOCIWFIRSTPRIV + 1 */ -/* SIOCIWFIRSTPRIV + 2 */ -#define KS_WLAN_GET_FIRM_VERSION SIOCIWFIRSTPRIV + 3 +/* (SIOCIWFIRSTPRIV + 0) */ +/* former KS_WLAN_GET_DRIVER_VERSION (SIOCIWFIRSTPRIV + 1) */ +/* (SIOCIWFIRSTPRIV + 2) */ +#define KS_WLAN_GET_FIRM_VERSION (SIOCIWFIRSTPRIV + 3) #ifdef WPS -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4 -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV + 5 -#define KS_WLAN_SET_WPS_PROBE_REQ SIOCIWFIRSTPRIV + 6 +#define KS_WLAN_SET_WPS_ENABLE (SIOCIWFIRSTPRIV + 4) +#define KS_WLAN_GET_WPS_ENABLE (SIOCIWFIRSTPRIV + 5) +#define KS_WLAN_SET_WPS_PROBE_REQ (SIOCIWFIRSTPRIV + 6) #endif -#define KS_WLAN_GET_EEPROM_CKSUM SIOCIWFIRSTPRIV + 7 -#define KS_WLAN_SET_PREAMBLE SIOCIWFIRSTPRIV + 8 -#define KS_WLAN_GET_PREAMBLE SIOCIWFIRSTPRIV + 9 -#define KS_WLAN_SET_POWER_SAVE SIOCIWFIRSTPRIV + 10 -#define KS_WLAN_GET_POWER_SAVE SIOCIWFIRSTPRIV + 11 -#define KS_WLAN_SET_SCAN_TYPE SIOCIWFIRSTPRIV + 12 -#define KS_WLAN_GET_SCAN_TYPE SIOCIWFIRSTPRIV + 13 -#define KS_WLAN_SET_RX_GAIN SIOCIWFIRSTPRIV + 14 -#define KS_WLAN_GET_RX_GAIN SIOCIWFIRSTPRIV + 15 -#define KS_WLAN_HOSTT SIOCIWFIRSTPRIV + 16 /* unused */ -//#define KS_WLAN_SET_REGION SIOCIWFIRSTPRIV + 17 -#define KS_WLAN_SET_BEACON_LOST SIOCIWFIRSTPRIV + 18 -#define KS_WLAN_GET_BEACON_LOST SIOCIWFIRSTPRIV + 19 +#define KS_WLAN_GET_EEPROM_CKSUM (SIOCIWFIRSTPRIV + 7) +#define KS_WLAN_SET_PREAMBLE (SIOCIWFIRSTPRIV + 8) +#define KS_WLAN_GET_PREAMBLE (SIOCIWFIRSTPRIV + 9) +#define KS_WLAN_SET_POWER_SAVE (SIOCIWFIRSTPRIV + 10) +#define KS_WLAN_GET_POWER_SAVE (SIOCIWFIRSTPRIV + 11) +#define KS_WLAN_SET_SCAN_TYPE (SIOCIWFIRSTPRIV + 12) +#define KS_WLAN_GET_SCAN_TYPE (SIOCIWFIRSTPRIV + 13) +#define KS_WLAN_SET_RX_GAIN (SIOCIWFIRSTPRIV + 14) +#define KS_WLAN_GET_RX_GAIN (SIOCIWFIRSTPRIV + 15) +#define KS_WLAN_HOSTT (SIOCIWFIRSTPRIV + 16) /* unused */ +//#define KS_WLAN_SET_REGION (SIOCIWFIRSTPRIV + 17) +#define KS_WLAN_SET_BEACON_LOST (SIOCIWFIRSTPRIV + 18) +#define KS_WLAN_GET_BEACON_LOST (SIOCIWFIRSTPRIV + 19) -#define KS_WLAN_SET_TX_GAIN SIOCIWFIRSTPRIV + 20 -#define KS_WLAN_GET_TX_GAIN SIOCIWFIRSTPRIV + 21 +#define KS_WLAN_SET_TX_GAIN (SIOCIWFIRSTPRIV + 20) +#define KS_WLAN_GET_TX_GAIN (SIOCIWFIRSTPRIV + 21) /* for KS7010 */ -#define KS_WLAN_SET_PHY_TYPE SIOCIWFIRSTPRIV + 22 -#define KS_WLAN_GET_PHY_TYPE SIOCIWFIRSTPRIV + 23 -#define KS_WLAN_SET_CTS_MODE SIOCIWFIRSTPRIV + 24 -#define KS_WLAN_GET_CTS_MODE SIOCIWFIRSTPRIV + 25 -/* SIOCIWFIRSTPRIV + 26 */ -/* SIOCIWFIRSTPRIV + 27 */ -#define KS_WLAN_SET_SLEEP_MODE SIOCIWFIRSTPRIV + 28 /* sleep mode */ -#define KS_WLAN_GET_SLEEP_MODE SIOCIWFIRSTPRIV + 29 /* sleep mode */ -/* SIOCIWFIRSTPRIV + 30 */ -/* SIOCIWFIRSTPRIV + 31 */ +#define KS_WLAN_SET_PHY_TYPE (SIOCIWFIRSTPRIV + 22) +#define KS_WLAN_GET_PHY_TYPE (SIOCIWFIRSTPRIV + 23) +#define KS_WLAN_SET_CTS_MODE (SIOCIWFIRSTPRIV + 24) +#define KS_WLAN_GET_CTS_MODE (SIOCIWFIRSTPRIV + 25) +/* (SIOCIWFIRSTPRIV + 26) */ +/* (SIOCIWFIRSTPRIV + 27) */ +#define KS_WLAN_SET_SLEEP_MODE (SIOCIWFIRSTPRIV + 28) /* sleep mode */ +#define KS_WLAN_GET_SLEEP_MODE (SIOCIWFIRSTPRIV + 29) /* sleep mode */ +/* (SIOCIWFIRSTPRIV + 30) */ +/* (SIOCIWFIRSTPRIV + 31) */ #ifdef __KERNEL__ -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCHv3 2/4] Removing trailing whitespace in comment block. 2017-02-27 2:00 ` [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses Matthew Giassa @ 2017-02-27 2:00 ` Matthew Giassa 2017-02-27 2:00 ` [PATCHv3 3/4] Removing mixed spaces/hard-tabs in the alignment indentation to appease checkpatch Matthew Giassa 2017-02-27 5:56 ` [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses Tobin C. Harding 1 sibling, 1 reply; 31+ messages in thread From: Matthew Giassa @ 2017-02-27 2:00 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 47c8015..0aa402d 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -1,6 +1,6 @@ /* * Driver for KeyStream 11b/g wireless LAN - * + * * Copyright (c) 2005-2008 KeyStream Corp. * Copyright (C) 2009 Renesas Technology Corp. * -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCHv3 3/4] Removing mixed spaces/hard-tabs in the alignment indentation to appease checkpatch. 2017-02-27 2:00 ` [PATCHv3 2/4] Removing trailing whitespace in comment block Matthew Giassa @ 2017-02-27 2:00 ` Matthew Giassa 2017-02-27 2:00 ` [PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors) Matthew Giassa 0 siblings, 1 reply; 31+ messages in thread From: Matthew Giassa @ 2017-02-27 2:00 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 0aa402d..9f71f01 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -20,8 +20,8 @@ /* (SIOCIWFIRSTPRIV + 2) */ #define KS_WLAN_GET_FIRM_VERSION (SIOCIWFIRSTPRIV + 3) #ifdef WPS -#define KS_WLAN_SET_WPS_ENABLE (SIOCIWFIRSTPRIV + 4) -#define KS_WLAN_GET_WPS_ENABLE (SIOCIWFIRSTPRIV + 5) +#define KS_WLAN_SET_WPS_ENABLE (SIOCIWFIRSTPRIV + 4) +#define KS_WLAN_GET_WPS_ENABLE (SIOCIWFIRSTPRIV + 5) #define KS_WLAN_SET_WPS_PROBE_REQ (SIOCIWFIRSTPRIV + 6) #endif #define KS_WLAN_GET_EEPROM_CKSUM (SIOCIWFIRSTPRIV + 7) -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors). 2017-02-27 2:00 ` [PATCHv3 3/4] Removing mixed spaces/hard-tabs in the alignment indentation to appease checkpatch Matthew Giassa @ 2017-02-27 2:00 ` Matthew Giassa 2017-02-27 9:19 ` Sergei Shtylyov 0 siblings, 1 reply; 31+ messages in thread From: Matthew Giassa @ 2017-02-27 2:00 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, Matthew Giassa --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 9f71f01..adc935d 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -60,7 +60,7 @@ int ks_wlan_read_config_file(struct ks_wlan_private *priv); int ks_wlan_setup_parameter(struct ks_wlan_private *priv, - unsigned int commit_flag); + unsigned int commit_flag); #endif /* __KERNEL__ */ -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* Re: [PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors). 2017-02-27 2:00 ` [PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors) Matthew Giassa @ 2017-02-27 9:19 ` Sergei Shtylyov 0 siblings, 0 replies; 31+ messages in thread From: Sergei Shtylyov @ 2017-02-27 9:19 UTC (permalink / raw) To: Matthew Giassa, wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel Hello! Your subject is too long, mught want to move i(part of) it to the patch description... And you need to provide your Signed-off-by:, the patch can't be applied without it. MBR, Sergei ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses. 2017-02-27 2:00 ` [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses Matthew Giassa 2017-02-27 2:00 ` [PATCHv3 2/4] Removing trailing whitespace in comment block Matthew Giassa @ 2017-02-27 5:56 ` Tobin C. Harding 1 sibling, 0 replies; 31+ messages in thread From: Tobin C. Harding @ 2017-02-27 5:56 UTC (permalink / raw) To: Matthew Giassa; +Cc: wsa, linux-renesas-soc, gregkh, devel, linux-kernel On Sun, Feb 26, 2017 at 06:00:19PM -0800, Matthew Giassa wrote: > --- > drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +++++++++++++++++----------------- > 1 file changed, 32 insertions(+), 32 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h > index 8e62b10..47c8015 100644 > --- a/drivers/staging/ks7010/ks_wlan_ioctl.h > +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h > @@ -15,43 +15,43 @@ > #include <linux/wireless.h> > /* The low order bit identify a SET (0) or a GET (1) ioctl. */ Patches without a git log won't be able to be merged. Please see Documentation/process/submitting-patches.rst thanks, Tobin. > > -/* SIOCIWFIRSTPRIV + 0 */ > -/* former KS_WLAN_GET_DRIVER_VERSION SIOCIWFIRSTPRIV + 1 */ > -/* SIOCIWFIRSTPRIV + 2 */ > -#define KS_WLAN_GET_FIRM_VERSION SIOCIWFIRSTPRIV + 3 > +/* (SIOCIWFIRSTPRIV + 0) */ > +/* former KS_WLAN_GET_DRIVER_VERSION (SIOCIWFIRSTPRIV + 1) */ > +/* (SIOCIWFIRSTPRIV + 2) */ > +#define KS_WLAN_GET_FIRM_VERSION (SIOCIWFIRSTPRIV + 3) > #ifdef WPS > -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4 > -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV + 5 > -#define KS_WLAN_SET_WPS_PROBE_REQ SIOCIWFIRSTPRIV + 6 > +#define KS_WLAN_SET_WPS_ENABLE (SIOCIWFIRSTPRIV + 4) > +#define KS_WLAN_GET_WPS_ENABLE (SIOCIWFIRSTPRIV + 5) > +#define KS_WLAN_SET_WPS_PROBE_REQ (SIOCIWFIRSTPRIV + 6) > #endif > -#define KS_WLAN_GET_EEPROM_CKSUM SIOCIWFIRSTPRIV + 7 > -#define KS_WLAN_SET_PREAMBLE SIOCIWFIRSTPRIV + 8 > -#define KS_WLAN_GET_PREAMBLE SIOCIWFIRSTPRIV + 9 > -#define KS_WLAN_SET_POWER_SAVE SIOCIWFIRSTPRIV + 10 > -#define KS_WLAN_GET_POWER_SAVE SIOCIWFIRSTPRIV + 11 > -#define KS_WLAN_SET_SCAN_TYPE SIOCIWFIRSTPRIV + 12 > -#define KS_WLAN_GET_SCAN_TYPE SIOCIWFIRSTPRIV + 13 > -#define KS_WLAN_SET_RX_GAIN SIOCIWFIRSTPRIV + 14 > -#define KS_WLAN_GET_RX_GAIN SIOCIWFIRSTPRIV + 15 > -#define KS_WLAN_HOSTT SIOCIWFIRSTPRIV + 16 /* unused */ > -//#define KS_WLAN_SET_REGION SIOCIWFIRSTPRIV + 17 > -#define KS_WLAN_SET_BEACON_LOST SIOCIWFIRSTPRIV + 18 > -#define KS_WLAN_GET_BEACON_LOST SIOCIWFIRSTPRIV + 19 > +#define KS_WLAN_GET_EEPROM_CKSUM (SIOCIWFIRSTPRIV + 7) > +#define KS_WLAN_SET_PREAMBLE (SIOCIWFIRSTPRIV + 8) > +#define KS_WLAN_GET_PREAMBLE (SIOCIWFIRSTPRIV + 9) > +#define KS_WLAN_SET_POWER_SAVE (SIOCIWFIRSTPRIV + 10) > +#define KS_WLAN_GET_POWER_SAVE (SIOCIWFIRSTPRIV + 11) > +#define KS_WLAN_SET_SCAN_TYPE (SIOCIWFIRSTPRIV + 12) > +#define KS_WLAN_GET_SCAN_TYPE (SIOCIWFIRSTPRIV + 13) > +#define KS_WLAN_SET_RX_GAIN (SIOCIWFIRSTPRIV + 14) > +#define KS_WLAN_GET_RX_GAIN (SIOCIWFIRSTPRIV + 15) > +#define KS_WLAN_HOSTT (SIOCIWFIRSTPRIV + 16) /* unused */ > +//#define KS_WLAN_SET_REGION (SIOCIWFIRSTPRIV + 17) > +#define KS_WLAN_SET_BEACON_LOST (SIOCIWFIRSTPRIV + 18) > +#define KS_WLAN_GET_BEACON_LOST (SIOCIWFIRSTPRIV + 19) > > -#define KS_WLAN_SET_TX_GAIN SIOCIWFIRSTPRIV + 20 > -#define KS_WLAN_GET_TX_GAIN SIOCIWFIRSTPRIV + 21 > +#define KS_WLAN_SET_TX_GAIN (SIOCIWFIRSTPRIV + 20) > +#define KS_WLAN_GET_TX_GAIN (SIOCIWFIRSTPRIV + 21) > > /* for KS7010 */ > -#define KS_WLAN_SET_PHY_TYPE SIOCIWFIRSTPRIV + 22 > -#define KS_WLAN_GET_PHY_TYPE SIOCIWFIRSTPRIV + 23 > -#define KS_WLAN_SET_CTS_MODE SIOCIWFIRSTPRIV + 24 > -#define KS_WLAN_GET_CTS_MODE SIOCIWFIRSTPRIV + 25 > -/* SIOCIWFIRSTPRIV + 26 */ > -/* SIOCIWFIRSTPRIV + 27 */ > -#define KS_WLAN_SET_SLEEP_MODE SIOCIWFIRSTPRIV + 28 /* sleep mode */ > -#define KS_WLAN_GET_SLEEP_MODE SIOCIWFIRSTPRIV + 29 /* sleep mode */ > -/* SIOCIWFIRSTPRIV + 30 */ > -/* SIOCIWFIRSTPRIV + 31 */ > +#define KS_WLAN_SET_PHY_TYPE (SIOCIWFIRSTPRIV + 22) > +#define KS_WLAN_GET_PHY_TYPE (SIOCIWFIRSTPRIV + 23) > +#define KS_WLAN_SET_CTS_MODE (SIOCIWFIRSTPRIV + 24) > +#define KS_WLAN_GET_CTS_MODE (SIOCIWFIRSTPRIV + 25) > +/* (SIOCIWFIRSTPRIV + 26) */ > +/* (SIOCIWFIRSTPRIV + 27) */ > +#define KS_WLAN_SET_SLEEP_MODE (SIOCIWFIRSTPRIV + 28) /* sleep mode */ > +#define KS_WLAN_GET_SLEEP_MODE (SIOCIWFIRSTPRIV + 29) /* sleep mode */ > +/* (SIOCIWFIRSTPRIV + 30) */ > +/* (SIOCIWFIRSTPRIV + 31) */ > > #ifdef __KERNEL__ > > -- > 2.7.4 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel ^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs 2017-02-21 4:20 [PATCH] staging/ks7010: formatting updates Matthew Giassa ` (2 preceding siblings ...) 2017-02-27 2:00 ` [PATCHv3] checkpatch fixes for drivers/staging/ks7010/ks_wlan_ioctl.h Matthew Giassa @ 2017-03-15 2:25 ` Matthew Giassa 2017-03-15 2:25 ` [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa 2017-03-16 2:42 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Greg KH 3 siblings, 2 replies; 31+ messages in thread From: Matthew Giassa @ 2017-03-15 2:25 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, matthew Removing mixed spaces/hard-tabs used to create a "column alignment" of macro names and macro values. Signed-off-by: Matthew Giassa <matthew@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 8e62b10..d811680 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -20,8 +20,8 @@ /* SIOCIWFIRSTPRIV + 2 */ #define KS_WLAN_GET_FIRM_VERSION SIOCIWFIRSTPRIV + 3 #ifdef WPS -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4 -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV + 5 +#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4 +#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV + 5 #define KS_WLAN_SET_WPS_PROBE_REQ SIOCIWFIRSTPRIV + 6 #endif #define KS_WLAN_GET_EEPROM_CKSUM SIOCIWFIRSTPRIV + 7 -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space 2017-03-15 2:25 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa @ 2017-03-15 2:25 ` Matthew Giassa 2017-03-15 2:25 ` [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes Matthew Giassa 2017-03-16 2:42 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Greg KH 1 sibling, 1 reply; 31+ messages in thread From: Matthew Giassa @ 2017-03-15 2:25 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, matthew Removing trailing white space characters in comments to resolve a checkpatch warning. Signed-off-by: Matthew Giassa <matthew@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index d811680..1b68402 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -1,6 +1,6 @@ /* * Driver for KeyStream 11b/g wireless LAN - * + * * Copyright (c) 2005-2008 KeyStream Corp. * Copyright (C) 2009 Renesas Technology Corp. * -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes. 2017-03-15 2:25 ` [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa @ 2017-03-15 2:25 ` Matthew Giassa 2017-03-15 2:25 ` [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses Matthew Giassa 0 siblings, 1 reply; 31+ messages in thread From: Matthew Giassa @ 2017-03-15 2:25 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, matthew Re-aligning function parameters in function prototypes by inserting additional hard-tabs to resolve a checkpatch warning. Signed-off-by: Matthew Giassa <matthew@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 1b68402..1251d7e 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -60,7 +60,7 @@ int ks_wlan_read_config_file(struct ks_wlan_private *priv); int ks_wlan_setup_parameter(struct ks_wlan_private *priv, - unsigned int commit_flag); + unsigned int commit_flag); #endif /* __KERNEL__ */ -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses 2017-03-15 2:25 ` [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes Matthew Giassa @ 2017-03-15 2:25 ` Matthew Giassa 2017-03-15 3:14 ` Tobin C. Harding 0 siblings, 1 reply; 31+ messages in thread From: Matthew Giassa @ 2017-03-15 2:25 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, matthew Wrapping all complex macros with parentheses to resolve checkpatch errors. This change, along with the preceding changes in this change set, resolves all checkpatch warnings and errors for the file. Signed-off-by: Matthew Giassa <matthew@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +++++++++++++++++----------------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 1251d7e..adc935d 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -15,43 +15,43 @@ #include <linux/wireless.h> /* The low order bit identify a SET (0) or a GET (1) ioctl. */ -/* SIOCIWFIRSTPRIV + 0 */ -/* former KS_WLAN_GET_DRIVER_VERSION SIOCIWFIRSTPRIV + 1 */ -/* SIOCIWFIRSTPRIV + 2 */ -#define KS_WLAN_GET_FIRM_VERSION SIOCIWFIRSTPRIV + 3 +/* (SIOCIWFIRSTPRIV + 0) */ +/* former KS_WLAN_GET_DRIVER_VERSION (SIOCIWFIRSTPRIV + 1) */ +/* (SIOCIWFIRSTPRIV + 2) */ +#define KS_WLAN_GET_FIRM_VERSION (SIOCIWFIRSTPRIV + 3) #ifdef WPS -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4 -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV + 5 -#define KS_WLAN_SET_WPS_PROBE_REQ SIOCIWFIRSTPRIV + 6 +#define KS_WLAN_SET_WPS_ENABLE (SIOCIWFIRSTPRIV + 4) +#define KS_WLAN_GET_WPS_ENABLE (SIOCIWFIRSTPRIV + 5) +#define KS_WLAN_SET_WPS_PROBE_REQ (SIOCIWFIRSTPRIV + 6) #endif -#define KS_WLAN_GET_EEPROM_CKSUM SIOCIWFIRSTPRIV + 7 -#define KS_WLAN_SET_PREAMBLE SIOCIWFIRSTPRIV + 8 -#define KS_WLAN_GET_PREAMBLE SIOCIWFIRSTPRIV + 9 -#define KS_WLAN_SET_POWER_SAVE SIOCIWFIRSTPRIV + 10 -#define KS_WLAN_GET_POWER_SAVE SIOCIWFIRSTPRIV + 11 -#define KS_WLAN_SET_SCAN_TYPE SIOCIWFIRSTPRIV + 12 -#define KS_WLAN_GET_SCAN_TYPE SIOCIWFIRSTPRIV + 13 -#define KS_WLAN_SET_RX_GAIN SIOCIWFIRSTPRIV + 14 -#define KS_WLAN_GET_RX_GAIN SIOCIWFIRSTPRIV + 15 -#define KS_WLAN_HOSTT SIOCIWFIRSTPRIV + 16 /* unused */ -//#define KS_WLAN_SET_REGION SIOCIWFIRSTPRIV + 17 -#define KS_WLAN_SET_BEACON_LOST SIOCIWFIRSTPRIV + 18 -#define KS_WLAN_GET_BEACON_LOST SIOCIWFIRSTPRIV + 19 +#define KS_WLAN_GET_EEPROM_CKSUM (SIOCIWFIRSTPRIV + 7) +#define KS_WLAN_SET_PREAMBLE (SIOCIWFIRSTPRIV + 8) +#define KS_WLAN_GET_PREAMBLE (SIOCIWFIRSTPRIV + 9) +#define KS_WLAN_SET_POWER_SAVE (SIOCIWFIRSTPRIV + 10) +#define KS_WLAN_GET_POWER_SAVE (SIOCIWFIRSTPRIV + 11) +#define KS_WLAN_SET_SCAN_TYPE (SIOCIWFIRSTPRIV + 12) +#define KS_WLAN_GET_SCAN_TYPE (SIOCIWFIRSTPRIV + 13) +#define KS_WLAN_SET_RX_GAIN (SIOCIWFIRSTPRIV + 14) +#define KS_WLAN_GET_RX_GAIN (SIOCIWFIRSTPRIV + 15) +#define KS_WLAN_HOSTT (SIOCIWFIRSTPRIV + 16) /* unused */ +//#define KS_WLAN_SET_REGION (SIOCIWFIRSTPRIV + 17) +#define KS_WLAN_SET_BEACON_LOST (SIOCIWFIRSTPRIV + 18) +#define KS_WLAN_GET_BEACON_LOST (SIOCIWFIRSTPRIV + 19) -#define KS_WLAN_SET_TX_GAIN SIOCIWFIRSTPRIV + 20 -#define KS_WLAN_GET_TX_GAIN SIOCIWFIRSTPRIV + 21 +#define KS_WLAN_SET_TX_GAIN (SIOCIWFIRSTPRIV + 20) +#define KS_WLAN_GET_TX_GAIN (SIOCIWFIRSTPRIV + 21) /* for KS7010 */ -#define KS_WLAN_SET_PHY_TYPE SIOCIWFIRSTPRIV + 22 -#define KS_WLAN_GET_PHY_TYPE SIOCIWFIRSTPRIV + 23 -#define KS_WLAN_SET_CTS_MODE SIOCIWFIRSTPRIV + 24 -#define KS_WLAN_GET_CTS_MODE SIOCIWFIRSTPRIV + 25 -/* SIOCIWFIRSTPRIV + 26 */ -/* SIOCIWFIRSTPRIV + 27 */ -#define KS_WLAN_SET_SLEEP_MODE SIOCIWFIRSTPRIV + 28 /* sleep mode */ -#define KS_WLAN_GET_SLEEP_MODE SIOCIWFIRSTPRIV + 29 /* sleep mode */ -/* SIOCIWFIRSTPRIV + 30 */ -/* SIOCIWFIRSTPRIV + 31 */ +#define KS_WLAN_SET_PHY_TYPE (SIOCIWFIRSTPRIV + 22) +#define KS_WLAN_GET_PHY_TYPE (SIOCIWFIRSTPRIV + 23) +#define KS_WLAN_SET_CTS_MODE (SIOCIWFIRSTPRIV + 24) +#define KS_WLAN_GET_CTS_MODE (SIOCIWFIRSTPRIV + 25) +/* (SIOCIWFIRSTPRIV + 26) */ +/* (SIOCIWFIRSTPRIV + 27) */ +#define KS_WLAN_SET_SLEEP_MODE (SIOCIWFIRSTPRIV + 28) /* sleep mode */ +#define KS_WLAN_GET_SLEEP_MODE (SIOCIWFIRSTPRIV + 29) /* sleep mode */ +/* (SIOCIWFIRSTPRIV + 30) */ +/* (SIOCIWFIRSTPRIV + 31) */ #ifdef __KERNEL__ -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* Re: [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses 2017-03-15 2:25 ` [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses Matthew Giassa @ 2017-03-15 3:14 ` Tobin C. Harding 2017-03-15 20:27 ` Matthew Giassa 0 siblings, 1 reply; 31+ messages in thread From: Tobin C. Harding @ 2017-03-15 3:14 UTC (permalink / raw) To: Matthew Giassa; +Cc: wsa, linux-renesas-soc, gregkh, devel, linux-kernel On Tue, Mar 14, 2017 at 07:25:54PM -0700, Matthew Giassa wrote: > Wrapping all complex macros with parentheses to resolve checkpatch > errors. This change, along with the preceding changes in this change > set, resolves all checkpatch warnings and errors for the file. > > Signed-off-by: Matthew Giassa <matthew@giassa.net> > --- > drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +++++++++++++++++----------------- > 1 file changed, 32 insertions(+), 32 deletions(-) > > diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h > index 1251d7e..adc935d 100644 > --- a/drivers/staging/ks7010/ks_wlan_ioctl.h > +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h > @@ -15,43 +15,43 @@ > #include <linux/wireless.h> > /* The low order bit identify a SET (0) or a GET (1) ioctl. */ > > -/* SIOCIWFIRSTPRIV + 0 */ > -/* former KS_WLAN_GET_DRIVER_VERSION SIOCIWFIRSTPRIV + 1 */ > -/* SIOCIWFIRSTPRIV + 2 */ > -#define KS_WLAN_GET_FIRM_VERSION SIOCIWFIRSTPRIV + 3 > +/* (SIOCIWFIRSTPRIV + 0) */ > +/* former KS_WLAN_GET_DRIVER_VERSION (SIOCIWFIRSTPRIV + 1) */ > +/* (SIOCIWFIRSTPRIV + 2) */ > +#define KS_WLAN_GET_FIRM_VERSION (SIOCIWFIRSTPRIV + 3) > #ifdef WPS > -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4 > -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV + 5 > -#define KS_WLAN_SET_WPS_PROBE_REQ SIOCIWFIRSTPRIV + 6 > +#define KS_WLAN_SET_WPS_ENABLE (SIOCIWFIRSTPRIV + 4) > +#define KS_WLAN_GET_WPS_ENABLE (SIOCIWFIRSTPRIV + 5) > +#define KS_WLAN_SET_WPS_PROBE_REQ (SIOCIWFIRSTPRIV + 6) > #endif > -#define KS_WLAN_GET_EEPROM_CKSUM SIOCIWFIRSTPRIV + 7 > -#define KS_WLAN_SET_PREAMBLE SIOCIWFIRSTPRIV + 8 > -#define KS_WLAN_GET_PREAMBLE SIOCIWFIRSTPRIV + 9 > -#define KS_WLAN_SET_POWER_SAVE SIOCIWFIRSTPRIV + 10 > -#define KS_WLAN_GET_POWER_SAVE SIOCIWFIRSTPRIV + 11 > -#define KS_WLAN_SET_SCAN_TYPE SIOCIWFIRSTPRIV + 12 > -#define KS_WLAN_GET_SCAN_TYPE SIOCIWFIRSTPRIV + 13 > -#define KS_WLAN_SET_RX_GAIN SIOCIWFIRSTPRIV + 14 > -#define KS_WLAN_GET_RX_GAIN SIOCIWFIRSTPRIV + 15 > -#define KS_WLAN_HOSTT SIOCIWFIRSTPRIV + 16 /* unused */ > -//#define KS_WLAN_SET_REGION SIOCIWFIRSTPRIV + 17 > -#define KS_WLAN_SET_BEACON_LOST SIOCIWFIRSTPRIV + 18 > -#define KS_WLAN_GET_BEACON_LOST SIOCIWFIRSTPRIV + 19 > +#define KS_WLAN_GET_EEPROM_CKSUM (SIOCIWFIRSTPRIV + 7) > +#define KS_WLAN_SET_PREAMBLE (SIOCIWFIRSTPRIV + 8) > +#define KS_WLAN_GET_PREAMBLE (SIOCIWFIRSTPRIV + 9) > +#define KS_WLAN_SET_POWER_SAVE (SIOCIWFIRSTPRIV + 10) > +#define KS_WLAN_GET_POWER_SAVE (SIOCIWFIRSTPRIV + 11) > +#define KS_WLAN_SET_SCAN_TYPE (SIOCIWFIRSTPRIV + 12) > +#define KS_WLAN_GET_SCAN_TYPE (SIOCIWFIRSTPRIV + 13) > +#define KS_WLAN_SET_RX_GAIN (SIOCIWFIRSTPRIV + 14) > +#define KS_WLAN_GET_RX_GAIN (SIOCIWFIRSTPRIV + 15) > +#define KS_WLAN_HOSTT (SIOCIWFIRSTPRIV + 16) /* unused */ > +//#define KS_WLAN_SET_REGION (SIOCIWFIRSTPRIV + 17) > +#define KS_WLAN_SET_BEACON_LOST (SIOCIWFIRSTPRIV + 18) > +#define KS_WLAN_GET_BEACON_LOST (SIOCIWFIRSTPRIV + 19) > > -#define KS_WLAN_SET_TX_GAIN SIOCIWFIRSTPRIV + 20 > -#define KS_WLAN_GET_TX_GAIN SIOCIWFIRSTPRIV + 21 > +#define KS_WLAN_SET_TX_GAIN (SIOCIWFIRSTPRIV + 20) > +#define KS_WLAN_GET_TX_GAIN (SIOCIWFIRSTPRIV + 21) > > /* for KS7010 */ > -#define KS_WLAN_SET_PHY_TYPE SIOCIWFIRSTPRIV + 22 > -#define KS_WLAN_GET_PHY_TYPE SIOCIWFIRSTPRIV + 23 > -#define KS_WLAN_SET_CTS_MODE SIOCIWFIRSTPRIV + 24 > -#define KS_WLAN_GET_CTS_MODE SIOCIWFIRSTPRIV + 25 > -/* SIOCIWFIRSTPRIV + 26 */ > -/* SIOCIWFIRSTPRIV + 27 */ > -#define KS_WLAN_SET_SLEEP_MODE SIOCIWFIRSTPRIV + 28 /* sleep mode */ > -#define KS_WLAN_GET_SLEEP_MODE SIOCIWFIRSTPRIV + 29 /* sleep mode */ > -/* SIOCIWFIRSTPRIV + 30 */ > -/* SIOCIWFIRSTPRIV + 31 */ > +#define KS_WLAN_SET_PHY_TYPE (SIOCIWFIRSTPRIV + 22) > +#define KS_WLAN_GET_PHY_TYPE (SIOCIWFIRSTPRIV + 23) > +#define KS_WLAN_SET_CTS_MODE (SIOCIWFIRSTPRIV + 24) > +#define KS_WLAN_GET_CTS_MODE (SIOCIWFIRSTPRIV + 25) > +/* (SIOCIWFIRSTPRIV + 26) */ > +/* (SIOCIWFIRSTPRIV + 27) */ > +#define KS_WLAN_SET_SLEEP_MODE (SIOCIWFIRSTPRIV + 28) /* sleep mode */ > +#define KS_WLAN_GET_SLEEP_MODE (SIOCIWFIRSTPRIV + 29) /* sleep mode */ > +/* (SIOCIWFIRSTPRIV + 30) */ > +/* (SIOCIWFIRSTPRIV + 31) */ > > #ifdef __KERNEL__ > > -- > 2.7.4 > > _______________________________________________ > devel mailing list > devel@linuxdriverproject.org > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel Hi Matthew, Sergei already mentioned the length of the subject line. If I may add to what he said. You may want to make your subject line (about) maximum 50 characters. Also, while we are at it, you may like to wrap your git log lines at 72 characters. One other thing, are you using git send-email? Your patches are chained together. >From Documentation/process/5.Posting.rst If you have a significant series of patches, it is customary to send an introductory description as part zero. This convention is not universally followed though; if you use it, remember that information in the introduction does not make it into the kernel changelogs. So please ensure that the patches, themselves, have complete changelog information. In general, the second and following parts of a multi-part patch should be sent as a reply to the first part so that they all thread together at the receiving end. Tools like git and quilt have commands to mail out a set of patches with the proper threading. If you have a long series, though, and are using git, please stay away from the --chain-reply-to option to avoid creating exceptionally deep nesting. Good luck, Tobin. ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses 2017-03-15 3:14 ` Tobin C. Harding @ 2017-03-15 20:27 ` Matthew Giassa 0 siblings, 0 replies; 31+ messages in thread From: Matthew Giassa @ 2017-03-15 20:27 UTC (permalink / raw) To: Tobin C. Harding; +Cc: wsa, linux-renesas-soc, gregkh, devel, linux-kernel * Tobin C. Harding <me@tobin.cc> [2017-03-15 14:14:08 +1100]: >On Tue, Mar 14, 2017 at 07:25:54PM -0700, Matthew Giassa wrote: >> Wrapping all complex macros with parentheses to resolve checkpatch >> errors. This change, along with the preceding changes in this change >> set, resolves all checkpatch warnings and errors for the file. >> >> Signed-off-by: Matthew Giassa <matthew@giassa.net> >> --- >> drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +++++++++++++++++----------------- >> 1 file changed, 32 insertions(+), 32 deletions(-) >> >> diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h >> index 1251d7e..adc935d 100644 >> --- a/drivers/staging/ks7010/ks_wlan_ioctl.h >> +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h >> @@ -15,43 +15,43 @@ >> #include <linux/wireless.h> >> /* The low order bit identify a SET (0) or a GET (1) ioctl. */ >> >> -/* SIOCIWFIRSTPRIV + 0 */ >> -/* former KS_WLAN_GET_DRIVER_VERSION SIOCIWFIRSTPRIV + 1 */ >> -/* SIOCIWFIRSTPRIV + 2 */ >> -#define KS_WLAN_GET_FIRM_VERSION SIOCIWFIRSTPRIV + 3 >> +/* (SIOCIWFIRSTPRIV + 0) */ >> +/* former KS_WLAN_GET_DRIVER_VERSION (SIOCIWFIRSTPRIV + 1) */ >> +/* (SIOCIWFIRSTPRIV + 2) */ >> +#define KS_WLAN_GET_FIRM_VERSION (SIOCIWFIRSTPRIV + 3) >> #ifdef WPS >> -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4 >> -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV + 5 >> -#define KS_WLAN_SET_WPS_PROBE_REQ SIOCIWFIRSTPRIV + 6 >> +#define KS_WLAN_SET_WPS_ENABLE (SIOCIWFIRSTPRIV + 4) >> +#define KS_WLAN_GET_WPS_ENABLE (SIOCIWFIRSTPRIV + 5) >> +#define KS_WLAN_SET_WPS_PROBE_REQ (SIOCIWFIRSTPRIV + 6) >> #endif >> -#define KS_WLAN_GET_EEPROM_CKSUM SIOCIWFIRSTPRIV + 7 >> -#define KS_WLAN_SET_PREAMBLE SIOCIWFIRSTPRIV + 8 >> -#define KS_WLAN_GET_PREAMBLE SIOCIWFIRSTPRIV + 9 >> -#define KS_WLAN_SET_POWER_SAVE SIOCIWFIRSTPRIV + 10 >> -#define KS_WLAN_GET_POWER_SAVE SIOCIWFIRSTPRIV + 11 >> -#define KS_WLAN_SET_SCAN_TYPE SIOCIWFIRSTPRIV + 12 >> -#define KS_WLAN_GET_SCAN_TYPE SIOCIWFIRSTPRIV + 13 >> -#define KS_WLAN_SET_RX_GAIN SIOCIWFIRSTPRIV + 14 >> -#define KS_WLAN_GET_RX_GAIN SIOCIWFIRSTPRIV + 15 >> -#define KS_WLAN_HOSTT SIOCIWFIRSTPRIV + 16 /* unused */ >> -//#define KS_WLAN_SET_REGION SIOCIWFIRSTPRIV + 17 >> -#define KS_WLAN_SET_BEACON_LOST SIOCIWFIRSTPRIV + 18 >> -#define KS_WLAN_GET_BEACON_LOST SIOCIWFIRSTPRIV + 19 >> +#define KS_WLAN_GET_EEPROM_CKSUM (SIOCIWFIRSTPRIV + 7) >> +#define KS_WLAN_SET_PREAMBLE (SIOCIWFIRSTPRIV + 8) >> +#define KS_WLAN_GET_PREAMBLE (SIOCIWFIRSTPRIV + 9) >> +#define KS_WLAN_SET_POWER_SAVE (SIOCIWFIRSTPRIV + 10) >> +#define KS_WLAN_GET_POWER_SAVE (SIOCIWFIRSTPRIV + 11) >> +#define KS_WLAN_SET_SCAN_TYPE (SIOCIWFIRSTPRIV + 12) >> +#define KS_WLAN_GET_SCAN_TYPE (SIOCIWFIRSTPRIV + 13) >> +#define KS_WLAN_SET_RX_GAIN (SIOCIWFIRSTPRIV + 14) >> +#define KS_WLAN_GET_RX_GAIN (SIOCIWFIRSTPRIV + 15) >> +#define KS_WLAN_HOSTT (SIOCIWFIRSTPRIV + 16) /* unused */ >> +//#define KS_WLAN_SET_REGION (SIOCIWFIRSTPRIV + 17) >> +#define KS_WLAN_SET_BEACON_LOST (SIOCIWFIRSTPRIV + 18) >> +#define KS_WLAN_GET_BEACON_LOST (SIOCIWFIRSTPRIV + 19) >> >> -#define KS_WLAN_SET_TX_GAIN SIOCIWFIRSTPRIV + 20 >> -#define KS_WLAN_GET_TX_GAIN SIOCIWFIRSTPRIV + 21 >> +#define KS_WLAN_SET_TX_GAIN (SIOCIWFIRSTPRIV + 20) >> +#define KS_WLAN_GET_TX_GAIN (SIOCIWFIRSTPRIV + 21) >> >> /* for KS7010 */ >> -#define KS_WLAN_SET_PHY_TYPE SIOCIWFIRSTPRIV + 22 >> -#define KS_WLAN_GET_PHY_TYPE SIOCIWFIRSTPRIV + 23 >> -#define KS_WLAN_SET_CTS_MODE SIOCIWFIRSTPRIV + 24 >> -#define KS_WLAN_GET_CTS_MODE SIOCIWFIRSTPRIV + 25 >> -/* SIOCIWFIRSTPRIV + 26 */ >> -/* SIOCIWFIRSTPRIV + 27 */ >> -#define KS_WLAN_SET_SLEEP_MODE SIOCIWFIRSTPRIV + 28 /* sleep mode */ >> -#define KS_WLAN_GET_SLEEP_MODE SIOCIWFIRSTPRIV + 29 /* sleep mode */ >> -/* SIOCIWFIRSTPRIV + 30 */ >> -/* SIOCIWFIRSTPRIV + 31 */ >> +#define KS_WLAN_SET_PHY_TYPE (SIOCIWFIRSTPRIV + 22) >> +#define KS_WLAN_GET_PHY_TYPE (SIOCIWFIRSTPRIV + 23) >> +#define KS_WLAN_SET_CTS_MODE (SIOCIWFIRSTPRIV + 24) >> +#define KS_WLAN_GET_CTS_MODE (SIOCIWFIRSTPRIV + 25) >> +/* (SIOCIWFIRSTPRIV + 26) */ >> +/* (SIOCIWFIRSTPRIV + 27) */ >> +#define KS_WLAN_SET_SLEEP_MODE (SIOCIWFIRSTPRIV + 28) /* sleep mode */ >> +#define KS_WLAN_GET_SLEEP_MODE (SIOCIWFIRSTPRIV + 29) /* sleep mode */ >> +/* (SIOCIWFIRSTPRIV + 30) */ >> +/* (SIOCIWFIRSTPRIV + 31) */ >> >> #ifdef __KERNEL__ >> >> -- >> 2.7.4 >> >> _______________________________________________ >> devel mailing list >> devel@linuxdriverproject.org >> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel > >Hi Matthew, > >Sergei already mentioned the length of the subject line. If I may add >to what he said. > >You may want to make your subject line (about) maximum 50 >characters. Also, while we are at it, you may like to wrap your git >log lines at 72 characters. > >One other thing, are you using git send-email? Your patches are >chained together. > >From Documentation/process/5.Posting.rst > >If you have a significant series of patches, it is customary to send >an introductory description as part zero. This convention is not >universally followed though; if you use it, remember that information >in the introduction does not make it into the kernel changelogs. So >please ensure that the patches, themselves, have complete changelog >information. > >In general, the second and following parts of a multi-part patch >should be sent as a reply to the first part so that they all thread >together at the receiving end. Tools like git and quilt have commands >to mail out a set of patches with the proper threading. If you have a >long series, though, and are using git, please stay away from the >--chain-reply-to option to avoid creating exceptionally deep nesting. > >Good luck, >Tobin. > Duely noted. Thank you for the heads-up Tobin. -Matthew ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs 2017-03-15 2:25 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa 2017-03-15 2:25 ` [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa @ 2017-03-16 2:42 ` Greg KH 2017-03-16 3:18 ` [PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes Matthew Giassa 1 sibling, 1 reply; 31+ messages in thread From: Greg KH @ 2017-03-16 2:42 UTC (permalink / raw) To: Matthew Giassa; +Cc: wsa, linux-renesas-soc, devel, linux-kernel On Tue, Mar 14, 2017 at 07:25:51PM -0700, Matthew Giassa wrote: > Removing mixed spaces/hard-tabs used to create a "column alignment" of > macro names and macro values. > > Signed-off-by: Matthew Giassa <matthew@giassa.net> > --- > drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This does not apply, please rebase your tree and resend. thanks, greg k-h ^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes 2017-03-16 2:42 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Greg KH @ 2017-03-16 3:18 ` Matthew Giassa 2017-03-16 3:18 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa ` (3 more replies) 0 siblings, 4 replies; 31+ messages in thread From: Matthew Giassa @ 2017-03-16 3:18 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, matthew The following patches address all outstanding checkpatch warnings/errors present in drivers/staging/ks7010/ks_wlan_ioctl.h. This change set has been rebased off of the current master (69eea5a4ab9c705496e912b55a9d312325de19e6) as per an earlier request, and the change log formatting has been slightly changed, as per Tobin's advice. ^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs 2017-03-16 3:18 ` [PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes Matthew Giassa @ 2017-03-16 3:18 ` Matthew Giassa 2017-03-17 6:22 ` Greg KH 2017-03-16 3:18 ` [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa ` (2 subsequent siblings) 3 siblings, 1 reply; 31+ messages in thread From: Matthew Giassa @ 2017-03-16 3:18 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, matthew Removing mixed spaces/hard-tabs used to create a "column alignment" of macro names and macro values. Signed-off-by: Matthew Giassa <matthew@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 8e62b10..d811680 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -20,8 +20,8 @@ /* SIOCIWFIRSTPRIV + 2 */ #define KS_WLAN_GET_FIRM_VERSION SIOCIWFIRSTPRIV + 3 #ifdef WPS -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4 -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV + 5 +#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4 +#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV + 5 #define KS_WLAN_SET_WPS_PROBE_REQ SIOCIWFIRSTPRIV + 6 #endif #define KS_WLAN_GET_EEPROM_CKSUM SIOCIWFIRSTPRIV + 7 -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* Re: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs 2017-03-16 3:18 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa @ 2017-03-17 6:22 ` Greg KH 2017-03-17 6:23 ` Greg KH 0 siblings, 1 reply; 31+ messages in thread From: Greg KH @ 2017-03-17 6:22 UTC (permalink / raw) To: Matthew Giassa; +Cc: wsa, linux-renesas-soc, devel, linux-kernel On Wed, Mar 15, 2017 at 08:18:08PM -0700, Matthew Giassa wrote: > Removing mixed spaces/hard-tabs used to create a "column alignment" of > macro names and macro values. > > Signed-off-by: Matthew Giassa <matthew@giassa.net> > --- > drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This patch does not apply to my tree at all. Are you sure you are working against the staging-next branch? Please rebase and resend. thanks, greg k-h ^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs 2017-03-17 6:22 ` Greg KH @ 2017-03-17 6:23 ` Greg KH 0 siblings, 0 replies; 31+ messages in thread From: Greg KH @ 2017-03-17 6:23 UTC (permalink / raw) To: Matthew Giassa; +Cc: wsa, linux-renesas-soc, devel, linux-kernel On Fri, Mar 17, 2017 at 03:22:57PM +0900, Greg KH wrote: > On Wed, Mar 15, 2017 at 08:18:08PM -0700, Matthew Giassa wrote: > > Removing mixed spaces/hard-tabs used to create a "column alignment" of > > macro names and macro values. > > > > Signed-off-by: Matthew Giassa <matthew@giassa.net> > > --- > > drivers/staging/ks7010/ks_wlan_ioctl.h | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > This patch does not apply to my tree at all. Are you sure you are > working against the staging-next branch? Please rebase and resend. Same thing for all of the patches in this series. greg k-h ^ permalink raw reply [flat|nested] 31+ messages in thread
* [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space 2017-03-16 3:18 ` [PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes Matthew Giassa 2017-03-16 3:18 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa @ 2017-03-16 3:18 ` Matthew Giassa 2017-03-16 3:18 ` [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes Matthew Giassa 2017-03-16 3:18 ` [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses Matthew Giassa 3 siblings, 0 replies; 31+ messages in thread From: Matthew Giassa @ 2017-03-16 3:18 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, matthew Removing trailing white space characters in comments to resolve a checkpatch warning. Signed-off-by: Matthew Giassa <matthew@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index d811680..1b68402 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -1,6 +1,6 @@ /* * Driver for KeyStream 11b/g wireless LAN - * + * * Copyright (c) 2005-2008 KeyStream Corp. * Copyright (C) 2009 Renesas Technology Corp. * -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes. 2017-03-16 3:18 ` [PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes Matthew Giassa 2017-03-16 3:18 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa 2017-03-16 3:18 ` [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa @ 2017-03-16 3:18 ` Matthew Giassa 2017-03-16 3:18 ` [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses Matthew Giassa 3 siblings, 0 replies; 31+ messages in thread From: Matthew Giassa @ 2017-03-16 3:18 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, matthew Re-aligning function parameters in function prototypes by inserting additional hard-tabs to resolve a checkpatch warning. Signed-off-by: Matthew Giassa <matthew@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 1b68402..1251d7e 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -60,7 +60,7 @@ int ks_wlan_read_config_file(struct ks_wlan_private *priv); int ks_wlan_setup_parameter(struct ks_wlan_private *priv, - unsigned int commit_flag); + unsigned int commit_flag); #endif /* __KERNEL__ */ -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses 2017-03-16 3:18 ` [PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes Matthew Giassa ` (2 preceding siblings ...) 2017-03-16 3:18 ` [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes Matthew Giassa @ 2017-03-16 3:18 ` Matthew Giassa 3 siblings, 0 replies; 31+ messages in thread From: Matthew Giassa @ 2017-03-16 3:18 UTC (permalink / raw) To: wsa; +Cc: gregkh, linux-kernel, linux-renesas-soc, devel, matthew Wrapping all complex macros with parentheses to resolve checkpatch errors. This change, along with the preceding changes in this change set, resolves all checkpatch warnings and errors for the file. Signed-off-by: Matthew Giassa <matthew@giassa.net> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 64 +++++++++++++++++----------------- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.h b/drivers/staging/ks7010/ks_wlan_ioctl.h index 1251d7e..adc935d 100644 --- a/drivers/staging/ks7010/ks_wlan_ioctl.h +++ b/drivers/staging/ks7010/ks_wlan_ioctl.h @@ -15,43 +15,43 @@ #include <linux/wireless.h> /* The low order bit identify a SET (0) or a GET (1) ioctl. */ -/* SIOCIWFIRSTPRIV + 0 */ -/* former KS_WLAN_GET_DRIVER_VERSION SIOCIWFIRSTPRIV + 1 */ -/* SIOCIWFIRSTPRIV + 2 */ -#define KS_WLAN_GET_FIRM_VERSION SIOCIWFIRSTPRIV + 3 +/* (SIOCIWFIRSTPRIV + 0) */ +/* former KS_WLAN_GET_DRIVER_VERSION (SIOCIWFIRSTPRIV + 1) */ +/* (SIOCIWFIRSTPRIV + 2) */ +#define KS_WLAN_GET_FIRM_VERSION (SIOCIWFIRSTPRIV + 3) #ifdef WPS -#define KS_WLAN_SET_WPS_ENABLE SIOCIWFIRSTPRIV + 4 -#define KS_WLAN_GET_WPS_ENABLE SIOCIWFIRSTPRIV + 5 -#define KS_WLAN_SET_WPS_PROBE_REQ SIOCIWFIRSTPRIV + 6 +#define KS_WLAN_SET_WPS_ENABLE (SIOCIWFIRSTPRIV + 4) +#define KS_WLAN_GET_WPS_ENABLE (SIOCIWFIRSTPRIV + 5) +#define KS_WLAN_SET_WPS_PROBE_REQ (SIOCIWFIRSTPRIV + 6) #endif -#define KS_WLAN_GET_EEPROM_CKSUM SIOCIWFIRSTPRIV + 7 -#define KS_WLAN_SET_PREAMBLE SIOCIWFIRSTPRIV + 8 -#define KS_WLAN_GET_PREAMBLE SIOCIWFIRSTPRIV + 9 -#define KS_WLAN_SET_POWER_SAVE SIOCIWFIRSTPRIV + 10 -#define KS_WLAN_GET_POWER_SAVE SIOCIWFIRSTPRIV + 11 -#define KS_WLAN_SET_SCAN_TYPE SIOCIWFIRSTPRIV + 12 -#define KS_WLAN_GET_SCAN_TYPE SIOCIWFIRSTPRIV + 13 -#define KS_WLAN_SET_RX_GAIN SIOCIWFIRSTPRIV + 14 -#define KS_WLAN_GET_RX_GAIN SIOCIWFIRSTPRIV + 15 -#define KS_WLAN_HOSTT SIOCIWFIRSTPRIV + 16 /* unused */ -//#define KS_WLAN_SET_REGION SIOCIWFIRSTPRIV + 17 -#define KS_WLAN_SET_BEACON_LOST SIOCIWFIRSTPRIV + 18 -#define KS_WLAN_GET_BEACON_LOST SIOCIWFIRSTPRIV + 19 +#define KS_WLAN_GET_EEPROM_CKSUM (SIOCIWFIRSTPRIV + 7) +#define KS_WLAN_SET_PREAMBLE (SIOCIWFIRSTPRIV + 8) +#define KS_WLAN_GET_PREAMBLE (SIOCIWFIRSTPRIV + 9) +#define KS_WLAN_SET_POWER_SAVE (SIOCIWFIRSTPRIV + 10) +#define KS_WLAN_GET_POWER_SAVE (SIOCIWFIRSTPRIV + 11) +#define KS_WLAN_SET_SCAN_TYPE (SIOCIWFIRSTPRIV + 12) +#define KS_WLAN_GET_SCAN_TYPE (SIOCIWFIRSTPRIV + 13) +#define KS_WLAN_SET_RX_GAIN (SIOCIWFIRSTPRIV + 14) +#define KS_WLAN_GET_RX_GAIN (SIOCIWFIRSTPRIV + 15) +#define KS_WLAN_HOSTT (SIOCIWFIRSTPRIV + 16) /* unused */ +//#define KS_WLAN_SET_REGION (SIOCIWFIRSTPRIV + 17) +#define KS_WLAN_SET_BEACON_LOST (SIOCIWFIRSTPRIV + 18) +#define KS_WLAN_GET_BEACON_LOST (SIOCIWFIRSTPRIV + 19) -#define KS_WLAN_SET_TX_GAIN SIOCIWFIRSTPRIV + 20 -#define KS_WLAN_GET_TX_GAIN SIOCIWFIRSTPRIV + 21 +#define KS_WLAN_SET_TX_GAIN (SIOCIWFIRSTPRIV + 20) +#define KS_WLAN_GET_TX_GAIN (SIOCIWFIRSTPRIV + 21) /* for KS7010 */ -#define KS_WLAN_SET_PHY_TYPE SIOCIWFIRSTPRIV + 22 -#define KS_WLAN_GET_PHY_TYPE SIOCIWFIRSTPRIV + 23 -#define KS_WLAN_SET_CTS_MODE SIOCIWFIRSTPRIV + 24 -#define KS_WLAN_GET_CTS_MODE SIOCIWFIRSTPRIV + 25 -/* SIOCIWFIRSTPRIV + 26 */ -/* SIOCIWFIRSTPRIV + 27 */ -#define KS_WLAN_SET_SLEEP_MODE SIOCIWFIRSTPRIV + 28 /* sleep mode */ -#define KS_WLAN_GET_SLEEP_MODE SIOCIWFIRSTPRIV + 29 /* sleep mode */ -/* SIOCIWFIRSTPRIV + 30 */ -/* SIOCIWFIRSTPRIV + 31 */ +#define KS_WLAN_SET_PHY_TYPE (SIOCIWFIRSTPRIV + 22) +#define KS_WLAN_GET_PHY_TYPE (SIOCIWFIRSTPRIV + 23) +#define KS_WLAN_SET_CTS_MODE (SIOCIWFIRSTPRIV + 24) +#define KS_WLAN_GET_CTS_MODE (SIOCIWFIRSTPRIV + 25) +/* (SIOCIWFIRSTPRIV + 26) */ +/* (SIOCIWFIRSTPRIV + 27) */ +#define KS_WLAN_SET_SLEEP_MODE (SIOCIWFIRSTPRIV + 28) /* sleep mode */ +#define KS_WLAN_GET_SLEEP_MODE (SIOCIWFIRSTPRIV + 29) /* sleep mode */ +/* (SIOCIWFIRSTPRIV + 30) */ +/* (SIOCIWFIRSTPRIV + 31) */ #ifdef __KERNEL__ -- 2.7.4 ^ permalink raw reply related [flat|nested] 31+ messages in thread
end of thread, other threads:[~2017-03-17 6:32 UTC | newest] Thread overview: 31+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-02-21 4:20 [PATCH] staging/ks7010: formatting updates Matthew Giassa 2017-02-21 7:59 ` Geert Uytterhoeven 2017-02-21 14:12 ` Matthew Giassa 2017-02-21 14:22 ` Geert Uytterhoeven 2017-02-21 17:32 ` Matthew Giassa 2017-02-21 18:47 ` Joe Perches 2017-02-21 19:48 ` Matthew Giassa 2017-02-21 20:02 ` Joe Perches 2017-02-22 21:52 ` [PATCHv2] Checkpatch fixes for staging/drivers/ks7010 Matthew Giassa 2017-02-24 17:12 ` Greg KH 2017-02-27 2:00 ` [PATCHv3] checkpatch fixes for drivers/staging/ks7010/ks_wlan_ioctl.h Matthew Giassa 2017-02-27 2:00 ` [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses Matthew Giassa 2017-02-27 2:00 ` [PATCHv3 2/4] Removing trailing whitespace in comment block Matthew Giassa 2017-02-27 2:00 ` [PATCHv3 3/4] Removing mixed spaces/hard-tabs in the alignment indentation to appease checkpatch Matthew Giassa 2017-02-27 2:00 ` [PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors) Matthew Giassa 2017-02-27 9:19 ` Sergei Shtylyov 2017-02-27 5:56 ` [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses Tobin C. Harding 2017-03-15 2:25 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa 2017-03-15 2:25 ` [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa 2017-03-15 2:25 ` [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes Matthew Giassa 2017-03-15 2:25 ` [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses Matthew Giassa 2017-03-15 3:14 ` Tobin C. Harding 2017-03-15 20:27 ` Matthew Giassa 2017-03-16 2:42 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Greg KH 2017-03-16 3:18 ` [PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes Matthew Giassa 2017-03-16 3:18 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa 2017-03-17 6:22 ` Greg KH 2017-03-17 6:23 ` Greg KH 2017-03-16 3:18 ` [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa 2017-03-16 3:18 ` [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes Matthew Giassa 2017-03-16 3:18 ` [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses Matthew Giassa
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).