linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] lib: add module support to sort tests
Date: Tue, 28 Feb 2017 16:28:51 +0200	[thread overview]
Message-ID: <1488292131.20145.61.camel@linux.intel.com> (raw)
In-Reply-To: <1488287219-15832-1-git-send-email-geert@linux-m68k.org>

On Tue, 2017-02-28 at 14:06 +0100, Geert Uytterhoeven wrote:
> 	Hi Andrew,
> 
> This patch series allows to compile the array-based and linked list
> sort
> test code either to loadable modules, or builtin into the kernel.
> 
> It's very valuable to have modular tests, so you can run them just by
> insmodding the test modules, instead of needing a separate kernel that
> runs them at boot.
> 
> Thanks for applying!

FWIW:
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

On the first glance looks okay to me. I didn't carefully checked code
move (I guess -M -C will not help much, though one can play with numbers
there), so I believe Geert didn't change much there.

> 
> Geert Uytterhoeven (3):
>   Revert "lib/test_sort.c: make it explicitly non-modular"
>   lib: add module support to array-based sort tests
>   lib: add module support to linked list sorting tests
> 
>  lib/Kconfig.debug    |  14 ++---
>  lib/Makefile         |   1 +
>  lib/list_sort.c      | 149 ------------------------------------------
> --------
>  lib/test_list_sort.c | 150
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  lib/test_sort.c      |  11 ++--
>  5 files changed, 164 insertions(+), 161 deletions(-)
>  create mode 100644 lib/test_list_sort.c
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

      parent reply	other threads:[~2017-02-28 14:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 13:06 [PATCH 0/3] lib: add module support to sort tests Geert Uytterhoeven
2017-02-28 13:06 ` [PATCH 1/3] Revert "lib/test_sort.c: make it explicitly non-modular" Geert Uytterhoeven
2017-02-28 14:24   ` Andy Shevchenko
2017-02-28 15:24     ` Geert Uytterhoeven
2017-02-28 13:06 ` [PATCH 2/3] lib: add module support to array-based sort tests Geert Uytterhoeven
2017-02-28 13:06 ` [PATCH 3/3] lib: add module support to linked list sorting tests Geert Uytterhoeven
2017-02-28 14:28   ` Arnd Bergmann
2017-02-28 14:43     ` Geert Uytterhoeven
2017-02-28 14:28 ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1488292131.20145.61.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).