linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Kaiser <martin@kaiser.cx>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>, Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 1/2 v2] char: misc: move the EXPORT_SYMBOL() declarations
Date: Mon, 17 Apr 2017 20:22:56 +0200	[thread overview]
Message-ID: <1492453377-23796-1-git-send-email-martin@kaiser.cx> (raw)
In-Reply-To: <1488234485-26111-1-git-send-email-martin@kaiser.cx>

This fixes a checkpatch warning:
EXPORT_SYMBOL(foo); should immediately follow its function/variable.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
v2:
   separate patch for each checkpatch warning

 drivers/char/misc.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/char/misc.c b/drivers/char/misc.c
index c9cd1ea..3447b2e 100644
--- a/drivers/char/misc.c
+++ b/drivers/char/misc.c
@@ -238,6 +238,7 @@ int misc_register(struct miscdevice *misc)
 	mutex_unlock(&misc_mtx);
 	return err;
 }
+EXPORT_SYMBOL(misc_register);
 
 /**
  *	misc_deregister - unregister a miscellaneous device
@@ -261,8 +262,6 @@ void misc_deregister(struct miscdevice *misc)
 		clear_bit(i, misc_minors);
 	mutex_unlock(&misc_mtx);
 }
-
-EXPORT_SYMBOL(misc_register);
 EXPORT_SYMBOL(misc_deregister);
 
 static char *misc_devnode(struct device *dev, umode_t *mode)
-- 
1.7.10.4

  parent reply	other threads:[~2017-04-17 18:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 22:27 [PATCH] char: misc: minor code cleanup Martin Kaiser
2017-04-08 16:11 ` Greg Kroah-Hartman
2017-04-17 18:22 ` Martin Kaiser [this message]
2017-04-17 18:22   ` [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry Martin Kaiser
2017-04-18  4:31     ` Greg Kroah-Hartman
2017-04-18  7:51       ` Martin Kaiser
2017-04-18  8:15         ` Greg Kroah-Hartman
2017-04-18  9:11           ` Martin Kaiser
     [not found]             ` <CAHp75Vec84Ltp2oGQwCKv9CwhzTFCu0znR_tmoLstctn_UR88A@mail.gmail.com>
2017-04-29  7:05               ` Martin Kaiser
2017-04-30 12:52                 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1492453377-23796-1-git-send-email-martin@kaiser.cx \
    --to=martin@kaiser.cx \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/2 v2] char: misc: move the EXPORT_SYMBOL() declarations' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).