From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martin Kaiser <martin@kaiser.cx>
Cc: linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry
Date: Tue, 18 Apr 2017 10:15:43 +0200 [thread overview]
Message-ID: <20170418081542.GA2051@kroah.com> (raw)
In-Reply-To: <20170418075131.GA15328@botnar.kaiser.cx>
On Tue, Apr 18, 2017 at 09:51:31AM +0200, Martin Kaiser wrote:
> Thus wrote Greg Kroah-Hartman (gregkh@linuxfoundation.org):
>
> > > - ret = proc_create("misc", 0, NULL, &misc_proc_fops);
> > > + ret = proc_create("misc", 0444, NULL, &misc_proc_fops);
>
> > What checkpatch warning does this fix? 0 is a number :)
>
> ERROR: Use 4 digit octal (0777) not decimal permissions
> #285: FILE: drivers/char/misc.c:285:
> + ret = proc_create("misc", 0, NULL, &misc_proc_fops);
Come on now, think about what this is saying. Is 0 not also an octal
number?
checkpatch requires you to use your brain, it is but a dumb perl
script...
greg k-h
next prev parent reply other threads:[~2017-04-18 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-27 22:27 [PATCH] char: misc: minor code cleanup Martin Kaiser
2017-04-08 16:11 ` Greg Kroah-Hartman
2017-04-17 18:22 ` [PATCH 1/2 v2] char: misc: move the EXPORT_SYMBOL() declarations Martin Kaiser
2017-04-17 18:22 ` [PATCH 2/2 v2] char: misc: use octal permissions for the proc entry Martin Kaiser
2017-04-18 4:31 ` Greg Kroah-Hartman
2017-04-18 7:51 ` Martin Kaiser
2017-04-18 8:15 ` Greg Kroah-Hartman [this message]
2017-04-18 9:11 ` Martin Kaiser
[not found] ` <CAHp75Vec84Ltp2oGQwCKv9CwhzTFCu0znR_tmoLstctn_UR88A@mail.gmail.com>
2017-04-29 7:05 ` Martin Kaiser
2017-04-30 12:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170418081542.GA2051@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@kaiser.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).