linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] of: Provide dummy of_device_compatible_match() for compile-testing
@ 2017-04-25 17:38 Geert Uytterhoeven
  2017-06-13 10:32 ` Geert Uytterhoeven
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2017-04-25 17:38 UTC (permalink / raw)
  To: Rob Herring, Frank Rowand; +Cc: devicetree, linux-kernel, Geert Uytterhoeven

Most of_device_*() functions have dummy versions for CONFIG_OF=n,
but of_device_compatible_match() hasn't.  Fix that to improve the
ability to do compile-testing.

Fixes: b9c13fe32faaa71c ("dt: Add of_device_compatible_match()")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 include/linux/of.h | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/include/linux/of.h b/include/linux/of.h
index 21e6323de0f3b786..bfd1a23221735161 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -620,6 +620,12 @@ static inline int of_device_is_compatible(const struct device_node *device,
 	return 0;
 }
 
+static inline  int of_device_compatible_match(struct device_node *device,
+					      const char *const *compat)
+{
+	return 0;
+}
+
 static inline bool of_device_is_available(const struct device_node *device)
 {
 	return false;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] of: Provide dummy of_device_compatible_match() for compile-testing
  2017-04-25 17:38 [PATCH] of: Provide dummy of_device_compatible_match() for compile-testing Geert Uytterhoeven
@ 2017-06-13 10:32 ` Geert Uytterhoeven
  2017-06-13 20:52   ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2017-06-13 10:32 UTC (permalink / raw)
  To: Rob Herring, Frank Rowand; +Cc: devicetree, linux-kernel

On Tue, Apr 25, 2017 at 7:38 PM, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> Most of_device_*() functions have dummy versions for CONFIG_OF=n,
> but of_device_compatible_match() hasn't.  Fix that to improve the
> ability to do compile-testing.
>
> Fixes: b9c13fe32faaa71c ("dt: Add of_device_compatible_match()")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Any reason not to apply this patch?

Thanks!

> ---
>  include/linux/of.h | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/include/linux/of.h b/include/linux/of.h
> index 21e6323de0f3b786..bfd1a23221735161 100644
> --- a/include/linux/of.h
> +++ b/include/linux/of.h
> @@ -620,6 +620,12 @@ static inline int of_device_is_compatible(const struct device_node *device,
>         return 0;
>  }
>
> +static inline  int of_device_compatible_match(struct device_node *device,
> +                                             const char *const *compat)
> +{
> +       return 0;
> +}
> +
>  static inline bool of_device_is_available(const struct device_node *device)
>  {
>         return false;
> --
> 2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] of: Provide dummy of_device_compatible_match() for compile-testing
  2017-06-13 10:32 ` Geert Uytterhoeven
@ 2017-06-13 20:52   ` Rob Herring
  0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2017-06-13 20:52 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Frank Rowand, devicetree, linux-kernel

On Tue, Jun 13, 2017 at 5:32 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Tue, Apr 25, 2017 at 7:38 PM, Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
>> Most of_device_*() functions have dummy versions for CONFIG_OF=n,
>> but of_device_compatible_match() hasn't.  Fix that to improve the
>> ability to do compile-testing.
>>
>> Fixes: b9c13fe32faaa71c ("dt: Add of_device_compatible_match()")
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Any reason not to apply this patch?

No, sorry I missed it. I've queued it up for 4.13.

Rob

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-06-13 20:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-25 17:38 [PATCH] of: Provide dummy of_device_compatible_match() for compile-testing Geert Uytterhoeven
2017-06-13 10:32 ` Geert Uytterhoeven
2017-06-13 20:52   ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).