From: Joe Perches <joe@perches.com>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: David Miller <davem@davemloft.net>,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-ipv4] question about arguments position
Date: Thu, 04 May 2017 12:17:13 -0700 [thread overview]
Message-ID: <1493925433.31950.0.camel@perches.com> (raw)
In-Reply-To: <20170504141548.Horde.VjUEZJdTZiLesC8PBMAO8QM@gator4166.hostgator.com>
On Thu, 2017-05-04 at 14:15 -0500, Gustavo A. R. Silva wrote:
> Quoting Joe Perches <joe@perches.com>:
>
> > On Thu, 2017-05-04 at 14:00 -0500, Gustavo A. R. Silva wrote:
> > > Regarding the code comments, what about the following patch:
> >
> > []
> > > diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c
> >
> > []
> > > @@ -389,6 +389,12 @@ static int sk_diag_fill(struct sock *sk, struct
> > > sk_buff *skb,
> > > nlmsg_flags, unlh, net_admin);
> > > }
> > >
> > > +/*
> > > + * Ignore the position of the arguments req->id.idiag_dport and
> > > + * req->id.idiag_sport in both calls to inet_lookup() and inet6_lookup()
> > > + * functions, once this is a locked in behavior exposed to user space.
> > > + * Changing this will break things for people.
> > > + */
> > > struct sock *inet_diag_find_one_icsk(struct net *net,
> > > struct inet_hashinfo *hashinfo,
> > > const struct inet_diag_req_v2 *req)
> > >
> >
> > Seems sensible. Thanks.
>
> Should I resend it in a full and proper format or it can taken from here?
If you want it applied, it should be resent as a full patch
with your sign-off.
next prev parent reply other threads:[~2017-05-04 19:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 16:07 [net-ipv4] question about arguments position Gustavo A. R. Silva
2017-05-04 16:46 ` David Miller
2017-05-04 16:56 ` Gustavo A. R. Silva
2017-05-04 17:47 ` Joe Perches
2017-05-04 19:00 ` Gustavo A. R. Silva
2017-05-04 19:02 ` Joe Perches
2017-05-04 19:15 ` Gustavo A. R. Silva
2017-05-04 19:17 ` Joe Perches [this message]
2017-05-04 19:24 ` Gustavo A. R. Silva
2017-05-04 19:44 ` [PATCH] net: ipv4: add code comment for clarification Gustavo A. R. Silva
2017-05-08 15:36 ` David Miller
2017-05-08 15:44 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493925433.31950.0.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=garsilva@embeddedor.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).