From: David Miller <davem@davemloft.net>
To: garsilva@embeddedor.com
Cc: kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [net-ipv4] question about arguments position
Date: Thu, 04 May 2017 12:46:00 -0400 (EDT) [thread overview]
Message-ID: <20170504.124600.627647229351638856.davem@davemloft.net> (raw)
In-Reply-To: <20170504110755.Horde.9md-X4baf8TwOEKjGrXkelZ@gator4166.hostgator.com>
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Thu, 04 May 2017 11:07:54 -0500
> While looking into Coverity ID 1357474 I ran into the following piece
> of code at net/ipv4/inet_diag.c:392:
Because it's been this way since at least 2005, it doesn't matter if
the order is correct or not. What's there is the locked in behavior
exposed to userspace and changing it will break things for people.
next prev parent reply other threads:[~2017-05-04 16:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-04 16:07 [net-ipv4] question about arguments position Gustavo A. R. Silva
2017-05-04 16:46 ` David Miller [this message]
2017-05-04 16:56 ` Gustavo A. R. Silva
2017-05-04 17:47 ` Joe Perches
2017-05-04 19:00 ` Gustavo A. R. Silva
2017-05-04 19:02 ` Joe Perches
2017-05-04 19:15 ` Gustavo A. R. Silva
2017-05-04 19:17 ` Joe Perches
2017-05-04 19:24 ` Gustavo A. R. Silva
2017-05-04 19:44 ` [PATCH] net: ipv4: add code comment for clarification Gustavo A. R. Silva
2017-05-08 15:36 ` David Miller
2017-05-08 15:44 ` Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504.124600.627647229351638856.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=garsilva@embeddedor.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).