linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck hacking jiffies.
@ 2017-04-29 19:46 Karim Eshapa
  2017-04-29 20:43 ` [PATCH] drivers:soc:fsl:qbman:qman.c: unsigned long jiffies value Karim Eshapa
  0 siblings, 1 reply; 12+ messages in thread
From: Karim Eshapa @ 2017-04-29 19:46 UTC (permalink / raw)
  To: oss
  Cc: claudiu.manoil, roy.pledge, colin.king, linuxppc-dev,
	linux-arm-kernel, linux-kernel, Karim Eshapa

Convert the jiffies into usecs then use it with usleep_range
such that instead of stuck doing nothing until action happens,
sleep with range improves responsiveness and power usage
and avoid hacking jiffies. it's used for approximate time.
You can check /kernel/time/timer.c.

Signed-off-by: Karim Eshapa <karim.eshapa@gmail.com>
---
 drivers/soc/fsl/qbman/qman.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/soc/fsl/qbman/qman.c b/drivers/soc/fsl/qbman/qman.c
index 6f509f6..e0df4d1 100644
--- a/drivers/soc/fsl/qbman/qman.c
+++ b/drivers/soc/fsl/qbman/qman.c
@@ -1084,11 +1084,9 @@ static int drain_mr_fqrni(struct qm_portal *p)
 		 * entries well before the ring has been fully consumed, so
 		 * we're being *really* paranoid here.
 		 */
-		u64 now, then = jiffies;
+		unsigned int udel_time = jiffies_to_usecs(10000);
 
-		do {
-			now = jiffies;
-		} while ((then + 10000) > now);
+		usleep_range(udel_time/2, udel_time);
 		msg = qm_mr_current(p);
 		if (!msg)
 			return 0;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2017-06-27 16:38 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-29 19:46 [PATCH] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck hacking jiffies Karim Eshapa
2017-04-29 20:43 ` [PATCH] drivers:soc:fsl:qbman:qman.c: unsigned long jiffies value Karim Eshapa
2017-04-29 23:32   ` Scott Wood
2017-04-30  1:09     ` Karim Eshapa
2017-05-04  4:58     ` [PATCH v2] drivers:soc:fsl:qbman:qman.c: Sleep instead of stuck hacking jiffies Karim Eshapa
2017-05-04 21:07       ` Scott Wood
2017-05-04 23:30         ` Roy Pledge
2017-05-05  5:45       ` [PATCH v3] " Karim Eshapa
2017-06-25  2:46         ` [v3] " Scott Wood
2017-06-27 16:38           ` Leo Li
2017-05-05  6:01       ` [PATCH v2] " Karim Eshapa
2017-05-05  6:33         ` Scott Wood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).