* [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"
@ 2017-06-13 8:52 Colin King
2017-06-13 10:36 ` Joe Perches
2017-06-20 3:41 ` Herbert Xu
0 siblings, 2 replies; 5+ messages in thread
From: Colin King @ 2017-06-13 8:52 UTC (permalink / raw)
To: Herbert Xu, David S . Miller, Srikanth Jampala, linux-crypto
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Trivial fix to spelling mistake in seq_printf message
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/crypto/cavium/nitrox/nitrox_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c
index eee6fb501580..ae44a464cd2d 100644
--- a/drivers/crypto/cavium/nitrox/nitrox_main.c
+++ b/drivers/crypto/cavium/nitrox/nitrox_main.c
@@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v)
struct nitrox_device *ndev = s->private;
seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx);
- seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id);
+ seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id);
seq_printf(s, " Cores [AE: %u SE: %u]\n",
ndev->hw.ae_cores, ndev->hw.se_cores);
seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues);
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"
2017-06-13 8:52 [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" Colin King
@ 2017-06-13 10:36 ` Joe Perches
2017-06-13 10:40 ` Colin Ian King
2017-06-20 3:41 ` Herbert Xu
1 sibling, 1 reply; 5+ messages in thread
From: Joe Perches @ 2017-06-13 10:36 UTC (permalink / raw)
To: Colin King, Herbert Xu, David S . Miller, Srikanth Jampala, linux-crypto
Cc: kernel-janitors, linux-kernel
On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in seq_printf message
Hey Colin.
Fixing spelling typos is a good thing, but is it a
good thing to change possibly API dependent output
in seq_ calls?
> diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c
[]
> @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v)
> struct nitrox_device *ndev = s->private;
>
> seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx);
> - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id);
> + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id);
> seq_printf(s, " Cores [AE: %u SE: %u]\n",
> ndev->hw.ae_cores, ndev->hw.se_cores);
> seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"
2017-06-13 10:36 ` Joe Perches
@ 2017-06-13 10:40 ` Colin Ian King
2017-06-13 10:44 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Colin Ian King @ 2017-06-13 10:40 UTC (permalink / raw)
To: Joe Perches, Herbert Xu, David S . Miller, Srikanth Jampala,
linux-crypto
Cc: kernel-janitors, linux-kernel
On 13/06/17 11:36, Joe Perches wrote:
> On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Trivial fix to spelling mistake in seq_printf message
>
> Hey Colin.
>
> Fixing spelling typos is a good thing, but is it a
> good thing to change possibly API dependent output
> in seq_ calls?
Considering it's in -next and has not landed in upstream I supposed it
was better to fix it now before it landed in Linus' repo.
Colin
>
>> diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c
> []
>> @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v)
>> struct nitrox_device *ndev = s->private;
>>
>> seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx);
>> - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id);
>> + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id);
>> seq_printf(s, " Cores [AE: %u SE: %u]\n",
>> ndev->hw.ae_cores, ndev->hw.se_cores);
>> seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues);
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"
2017-06-13 10:40 ` Colin Ian King
@ 2017-06-13 10:44 ` Joe Perches
0 siblings, 0 replies; 5+ messages in thread
From: Joe Perches @ 2017-06-13 10:44 UTC (permalink / raw)
To: Colin Ian King, Herbert Xu, David S . Miller, Srikanth Jampala,
linux-crypto
Cc: kernel-janitors, linux-kernel
On Tue, 2017-06-13 at 11:40 +0100, Colin Ian King wrote:
> On 13/06/17 11:36, Joe Perches wrote:
> > On Tue, 2017-06-13 at 09:52 +0100, Colin King wrote:
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > Trivial fix to spelling mistake in seq_printf message
> > Fixing spelling typos is a good thing, but is it a
> > good thing to change possibly API dependent output
> > in seq_ calls?
> Considering it's in -next and has not landed in upstream I supposed it
> was better to fix it now before it landed in Linus' repo.
Good call, thanks.
> > > diff --git a/drivers/crypto/cavium/nitrox/nitrox_main.c b/drivers/crypto/cavium/nitrox/nitrox_main.c
> >
> > []
> > > @@ -399,7 +399,7 @@ static int nitrox_show(struct seq_file *s, void *v)
> > > struct nitrox_device *ndev = s->private;
> > >
> > > seq_printf(s, "NITROX-5 [idx: %d]\n", ndev->idx);
> > > - seq_printf(s, " Revsion ID: 0x%0x\n", ndev->hw.revision_id);
> > > + seq_printf(s, " Revision ID: 0x%0x\n", ndev->hw.revision_id);
> > > seq_printf(s, " Cores [AE: %u SE: %u]\n",
> > > ndev->hw.ae_cores, ndev->hw.se_cores);
> > > seq_printf(s, " Number of Queues: %u\n", ndev->nr_queues);
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision"
2017-06-13 8:52 [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" Colin King
2017-06-13 10:36 ` Joe Perches
@ 2017-06-20 3:41 ` Herbert Xu
1 sibling, 0 replies; 5+ messages in thread
From: Herbert Xu @ 2017-06-20 3:41 UTC (permalink / raw)
To: Colin King
Cc: David S . Miller, Srikanth Jampala, linux-crypto,
kernel-janitors, linux-kernel
On Tue, Jun 13, 2017 at 09:52:54AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Trivial fix to spelling mistake in seq_printf message
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-06-20 3:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-13 8:52 [PATCH][crypto-next] crypto: cavium: fix spelling mistake "Revsion" -> "Revision" Colin King
2017-06-13 10:36 ` Joe Perches
2017-06-13 10:40 ` Colin Ian King
2017-06-13 10:44 ` Joe Perches
2017-06-20 3:41 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).