* [PATCH 0/3] Remove unnecessary pci_set_drvdata() and platform_set_drvdata().
@ 2016-05-11 12:35 Sandhya Bankar
2016-05-11 12:38 ` [PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata() Sandhya Bankar
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-05-11 12:35 UTC (permalink / raw)
To: linux-kernel, linux-usb, gregkh, balbi, r.baldyga, saurabh.truth,
bankarsandhya512, peter.chen, Julia.Lawall
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver datato NULL after device release or on probe failure. There is no need to manually clear the device driver data to NULL.
Sandhya Bankar (3):
usb: pci: Remove unnecessary pci_set_drvdata().
usb: dwc3-keystone: Remove unnecessary platform_set_drvdata().
usb: gr_udec: Remove unnecessary platform_set_drvdata().
drivers/usb/dwc2/pci.c | 1 -
drivers/usb/dwc3/dwc3-keystone.c | 1 -
drivers/usb/gadget/udc/gr_udc.c | 1 -
3 files changed, 3 deletions(-)
--
1.8.3.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata().
2016-05-11 12:35 [PATCH 0/3] Remove unnecessary pci_set_drvdata() and platform_set_drvdata() Sandhya Bankar
@ 2016-05-11 12:38 ` Sandhya Bankar
2016-06-08 5:23 ` Greg KH
2016-05-11 12:42 ` [PATCH 2/3] usb: dwc3-keystone: Remove unnecessary platform_set_drvdata() Sandhya Bankar
2016-05-11 12:46 ` [PATCH 3/3] usb: gr_udc: " Sandhya Bankar
2 siblings, 1 reply; 5+ messages in thread
From: Sandhya Bankar @ 2016-05-11 12:38 UTC (permalink / raw)
To: gregkh, johnyoun, linux-usb, linux-kernel
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the
device driver data to NULL.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/usb/dwc2/pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc2/pci.c b/drivers/usb/dwc2/pci.c
index ae41961..c76fade 100644
--- a/drivers/usb/dwc2/pci.c
+++ b/drivers/usb/dwc2/pci.c
@@ -69,7 +69,6 @@ static void dwc2_pci_remove(struct pci_dev *pci)
platform_device_unregister(glue->dwc2);
usb_phy_generic_unregister(glue->phy);
kfree(glue);
- pci_set_drvdata(pci, NULL);
}
static int dwc2_pci_probe(struct pci_dev *pci,
--
1.8.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] usb: dwc3-keystone: Remove unnecessary platform_set_drvdata().
2016-05-11 12:35 [PATCH 0/3] Remove unnecessary pci_set_drvdata() and platform_set_drvdata() Sandhya Bankar
2016-05-11 12:38 ` [PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata() Sandhya Bankar
@ 2016-05-11 12:42 ` Sandhya Bankar
2016-05-11 12:46 ` [PATCH 3/3] usb: gr_udc: " Sandhya Bankar
2 siblings, 0 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-05-11 12:42 UTC (permalink / raw)
To: gregkh, balbi, linux-usb, linux-kernel
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/usb/dwc3/dwc3-keystone.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/dwc3/dwc3-keystone.c b/drivers/usb/dwc3/dwc3-keystone.c
index 7266470..089bb70 100644
--- a/drivers/usb/dwc3/dwc3-keystone.c
+++ b/drivers/usb/dwc3/dwc3-keystone.c
@@ -164,7 +164,6 @@ static int kdwc3_remove(struct platform_device *pdev)
kdwc3_disable_irqs(kdwc);
device_for_each_child(&pdev->dev, NULL, kdwc3_remove_core);
clk_disable_unprepare(kdwc->clk);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.8.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 3/3] usb: gr_udc: Remove unnecessary platform_set_drvdata().
2016-05-11 12:35 [PATCH 0/3] Remove unnecessary pci_set_drvdata() and platform_set_drvdata() Sandhya Bankar
2016-05-11 12:38 ` [PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata() Sandhya Bankar
2016-05-11 12:42 ` [PATCH 2/3] usb: dwc3-keystone: Remove unnecessary platform_set_drvdata() Sandhya Bankar
@ 2016-05-11 12:46 ` Sandhya Bankar
2 siblings, 0 replies; 5+ messages in thread
From: Sandhya Bankar @ 2016-05-11 12:46 UTC (permalink / raw)
To: balbi, gregkh, r.baldyga, bankarsandhya512, saurabh.truth,
peter.chen, Julia.Lawall, linux-usb, linux-kernel
Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL.
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/usb/gadget/udc/gr_udc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c
index 39b7136..05f956c 100644
--- a/drivers/usb/gadget/udc/gr_udc.c
+++ b/drivers/usb/gadget/udc/gr_udc.c
@@ -2117,7 +2117,6 @@ static int gr_remove(struct platform_device *pdev)
gr_dfs_delete(dev);
dma_pool_destroy(dev->desc_pool);
- platform_set_drvdata(pdev, NULL);
gr_free_request(&dev->epi[0].ep, &dev->ep0reqi->req);
gr_free_request(&dev->epo[0].ep, &dev->ep0reqo->req);
--
1.8.3.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-06-08 5:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-11 12:35 [PATCH 0/3] Remove unnecessary pci_set_drvdata() and platform_set_drvdata() Sandhya Bankar
2016-05-11 12:38 ` [PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata() Sandhya Bankar
2016-06-08 5:23 ` Greg KH
2016-05-11 12:42 ` [PATCH 2/3] usb: dwc3-keystone: Remove unnecessary platform_set_drvdata() Sandhya Bankar
2016-05-11 12:46 ` [PATCH 3/3] usb: gr_udc: " Sandhya Bankar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).