From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kuldeep Singh <singh.kuldeep87k@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v2 6/6] dt-bindings: dma: Convert Qualcomm BAM DMA binding to json format
Date: Sun, 10 Apr 2022 21:22:11 +0200 [thread overview]
Message-ID: <14ecb746-56f0-2d3b-2f93-1af9407de4b7@linaro.org> (raw)
In-Reply-To: <20220410175056.79330-7-singh.kuldeep87k@gmail.com>
On 10/04/2022 19:50, Kuldeep Singh wrote:
> Convert Qualcomm BAM DMA controller binding to DT schema format using
> json schema.
Thank you for your patch. There is something to discuss/improve.
(...)
> +
> + interrupts:
> + maxItems: 1
> +
> + iommus:
> + minItems: 1
> + maxItems: 4
This is something new and it seems only one SoC defines it (not even one
BAM version). I wonder whether this is actually correct or this
particular version of BAM is slightly different. Maybe someone could
clarify it, but if no - looks ok.
> +
> + num-channels:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Indicates supported number of DMA channels in a remotely controlled bam.
> +
> + qcom,controlled-remotely:
> + $ref: /schemas/types.yaml#/definitions/flag
type: boolean
> + description:
> + Indicates that the bam is controlled by remote proccessor i.e. execution
> + environment.
> +
> + qcom,ee:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Indicates the active Execution Environment identifier (0-7) used in the
> + secure world.
maximum: 7
> +
> + qcom,num-ees:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + Indicates supported number of Execution Environments in a remotely
> + controlled bam.
> +
> + qcom,powered-remotely:
> + $ref: /schemas/types.yaml#/definitions/flag
type: boolean
> + description:
> + Indicates that the bam is powered up by a remote processor but must be
> + initialized by the local processor.
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - "#dma-cells"
> + - interrupts
> + - reg
clocks, clock-names, qcom-ee - these are required according to old bindings.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-10 19:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 17:50 [PATCH v2 0/6] Convert Qcom BAM dma binding to json format Kuldeep Singh
2022-04-10 17:50 ` [PATCH v2 1/6] ARM: dts: qcom: apq8064: User generic node name for DMA Kuldeep Singh
2022-04-10 19:08 ` Krzysztof Kozlowski
2022-04-11 10:43 ` Kuldeep Singh
2022-04-10 17:50 ` [PATCH v2 2/6] ARM: dts: qcom: mdm9615: " Kuldeep Singh
2022-04-10 19:09 ` Krzysztof Kozlowski
2022-04-10 17:50 ` [PATCH v2 3/6] arm64: dts: qcom: msm8996: " Kuldeep Singh
2022-04-10 19:09 ` Krzysztof Kozlowski
2022-04-10 17:50 ` [PATCH v2 4/6] ARM: dts: qcom: ipq4019: " Kuldeep Singh
2022-04-10 19:10 ` Krzysztof Kozlowski
2022-04-10 17:50 ` [PATCH v2 5/6] ARM: dts: qcom: ipq8064: " Kuldeep Singh
2022-04-10 19:10 ` Krzysztof Kozlowski
2022-04-10 17:50 ` [PATCH v2 6/6] dt-bindings: dma: Convert Qualcomm BAM DMA binding to json format Kuldeep Singh
2022-04-10 19:22 ` Krzysztof Kozlowski [this message]
2022-04-11 10:58 ` Kuldeep Singh
2022-04-11 11:38 ` Krzysztof Kozlowski
2022-04-12 6:19 ` Kuldeep Singh
2022-04-12 6:43 ` Krzysztof Kozlowski
2022-04-12 18:01 ` Kuldeep Singh
2022-04-17 5:50 ` Kuldeep Singh
2022-04-18 5:27 ` Bhupesh Sharma
2022-04-18 19:20 ` Kuldeep Singh
2022-04-19 7:47 ` Krzysztof Kozlowski
2022-04-20 13:29 ` Kuldeep Singh
2022-04-20 15:33 ` Kuldeep Singh
2022-04-20 19:17 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14ecb746-56f0-2d3b-2f93-1af9407de4b7@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=singh.kuldeep87k@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).