From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kuldeep Singh <singh.kuldeep87k@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v2 6/6] dt-bindings: dma: Convert Qualcomm BAM DMA binding to json format
Date: Tue, 12 Apr 2022 08:43:59 +0200 [thread overview]
Message-ID: <8ff07720-3c52-99e6-8046-501f4ae28518@linaro.org> (raw)
In-Reply-To: <20220412061953.GA95928@9a2d8922b8f1>
On 12/04/2022 08:19, Kuldeep Singh wrote:
> On Mon, Apr 11, 2022 at 01:38:41PM +0200, Krzysztof Kozlowski wrote:
>> On 11/04/2022 12:58, Kuldeep Singh wrote:
>>>> This is something new and it seems only one SoC defines it (not even one
>>>> BAM version). I wonder whether this is actually correct or this
>>>> particular version of BAM is slightly different. Maybe someone could
>>>> clarify it, but if no - looks ok.
>>>
>>> Yes, sdm845.dtsi uses 4 entries and rest 1.
>>
>> Yes, I know. This does not solve my wonder.
>>
>>>
>>>>
>>>>> +
>>>>> + num-channels:
>>>>> + $ref: /schemas/types.yaml#/definitions/uint32
>>>>> + description:
>>>>> + Indicates supported number of DMA channels in a remotely controlled bam.
>>>>> +
>>>>> + qcom,controlled-remotely:
>>>>> + $ref: /schemas/types.yaml#/definitions/flag
>>>>
>>>> type: boolean
>>>
>>> Boolean comes under flag in types.yaml
>>>
>>> definitions:
>>> flag:
>>> oneOf:
>>> - type: boolean
>>> const: true
>>> - type: 'null'
>>>
>>> I have seen other boolean properties(spi-cpol, spi-cpha and bunch of
>>> others) using type flag. I think we should keep flag here.
>>
>> type:boolean is just shorter and example-schema recommends it. If you
>> want to base on something (as a template, pattern) then the
>> example-schema is the source, the preferred one.
>
> I had seen other spec using flag and that's why kept same here.
I understand, you mentioned it before. However other spec is not the
example-schema...
> Which example schema are you talking about?
There is only one example-schema.
$ find ./linux -name 'example-schema*'
>>>> clocks, clock-names, qcom-ee - these are required according to old bindings.
>>>
>>> I missed qcom,ee. Will add in v3.
>>>
>>> For clocks and clock-names , there are two platforms(msm8996.dtsi,
>>> sdm845.dtsi) where these properties are missing. And I don't want to add
>>> some random values. Shall I skip them here? and let board owners add
>>> them later.
>>
>> These are required, so the SoC DTSI should be fixed. Not with random
>> clocks but something proper. :)
>
> Yes absolutely :-)
> I have kept Srinivas in copy, who sent initial support for both the
> dtsi. Probably he can confirm provided his email doesn't bounce.
>
> Anyway Krzysztof, can you confirm the same as you have been actively
> contributing to Qcom peripherals. I will add credit in follow-up
> submission.
Honestly not now, because I don't have access to related datasheets (I
am working on this). You can though try to look at original (vendor)
sources:
https://git.codelinaro.org/clo/la/kernel/msm-4.19 (sdm845)
https://git.codelinaro.org/clo/la/kernel/msm-3.18 (msm8996)
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-12 7:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-10 17:50 [PATCH v2 0/6] Convert Qcom BAM dma binding to json format Kuldeep Singh
2022-04-10 17:50 ` [PATCH v2 1/6] ARM: dts: qcom: apq8064: User generic node name for DMA Kuldeep Singh
2022-04-10 19:08 ` Krzysztof Kozlowski
2022-04-11 10:43 ` Kuldeep Singh
2022-04-10 17:50 ` [PATCH v2 2/6] ARM: dts: qcom: mdm9615: " Kuldeep Singh
2022-04-10 19:09 ` Krzysztof Kozlowski
2022-04-10 17:50 ` [PATCH v2 3/6] arm64: dts: qcom: msm8996: " Kuldeep Singh
2022-04-10 19:09 ` Krzysztof Kozlowski
2022-04-10 17:50 ` [PATCH v2 4/6] ARM: dts: qcom: ipq4019: " Kuldeep Singh
2022-04-10 19:10 ` Krzysztof Kozlowski
2022-04-10 17:50 ` [PATCH v2 5/6] ARM: dts: qcom: ipq8064: " Kuldeep Singh
2022-04-10 19:10 ` Krzysztof Kozlowski
2022-04-10 17:50 ` [PATCH v2 6/6] dt-bindings: dma: Convert Qualcomm BAM DMA binding to json format Kuldeep Singh
2022-04-10 19:22 ` Krzysztof Kozlowski
2022-04-11 10:58 ` Kuldeep Singh
2022-04-11 11:38 ` Krzysztof Kozlowski
2022-04-12 6:19 ` Kuldeep Singh
2022-04-12 6:43 ` Krzysztof Kozlowski [this message]
2022-04-12 18:01 ` Kuldeep Singh
2022-04-17 5:50 ` Kuldeep Singh
2022-04-18 5:27 ` Bhupesh Sharma
2022-04-18 19:20 ` Kuldeep Singh
2022-04-19 7:47 ` Krzysztof Kozlowski
2022-04-20 13:29 ` Kuldeep Singh
2022-04-20 15:33 ` Kuldeep Singh
2022-04-20 19:17 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ff07720-3c52-99e6-8046-501f4ae28518@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=singh.kuldeep87k@gmail.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).