From: Chen Zhong <chen.zhong@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Lee Jones" <lee.jones@linaro.org>,
Eddie Huang <eddie.huang@mediatek.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Andi Shyti <andi.shyti@samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
"Jaechul Lee" <jcsing.lee@samsung.com>,
<linux-input@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-rtc@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] dt-bindings: input: Add document bindings for mtk-pmic-keys
Date: Sat, 2 Sep 2017 10:16:23 +0800 [thread overview]
Message-ID: <1504318583.15359.12.camel@mhfsdcap03> (raw)
In-Reply-To: <20170831195239.b2litxbu7smhkkjl@rob-hp-laptop>
On Thu, 2017-08-31 at 14:52 -0500, Rob Herring wrote:
> On Fri, Aug 25, 2017 at 02:32:30PM +0800, Chen Zhong wrote:
> > This patch adds the device tree binding documentation for the MediaTek
> > pmic keys found on PMIC MT6397/MT6323.
> >
> > Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>
> > ---
> > .../devicetree/bindings/input/mtk-pmic-keys.txt | 38 ++++++++++++++++++++
> > 1 file changed, 38 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
> >
> > diff --git a/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
> > new file mode 100644
> > index 0000000..100ec44
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/input/mtk-pmic-keys.txt
> > @@ -0,0 +1,38 @@
> > +MediaTek MT6397/MT6323 PMIC Keys Device Driver
> > +
> > +There are two key functions provided by MT6397/MT6323 PMIC, pwrkey
> > +and homekey. The key functions are defined as the subnode of the function
> > +node provided by MT6397/MT6323 PMIC that is being defined as one kind
> > +of Muti-Function Device (MFD)
> > +
> > +For MT6397/MT6323 MFD bindings see:
> > +Documentation/devicetree/bindings/mfd/mt6397.txt
> > +
> > +Required properties:
> > +- compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys"
> > +- linux,keycodes: Specifies the numeric keycode values to
> > + be used for reporting keys presses. The array can
> > + contain up to 2 entries.
> > +
> > +Optional Properties:
> > +- wakeup-source: each key can be used as a wakeup source.
>
> wakeup-source is defined as a boolean.
Hi Rob,
Could I modify it as this?
mediatek,wakeup-keys = <1>, <0>;
wakeup-source;
Thanks.
>
> > +- mediatek,long-press-mode: Long press key shutdown setting, 1 for
> > + pwrkey only, 2 for pwrkey/homekey together, others for disabled.
> > +- debounce-interval: Long press key shutdown debouncing interval time
> > + in seconds. 0/1/2/3 for 8/11/14/5 seconds. If not specified defaults to 0.
> > +
> > +Example:
> > +
> > + pmic: mt6397 {
> > + compatible = "mediatek,mt6397";
> > +
> > + ...
> > +
> > + mt6397keys: mt6397keys {
> > + compatible = "mediatek,mt6397-keys";
> > + linux,keycodes = <KEY_POWER>, <KEY_VOLUMEDOWN>;
> > + wakeup-source = <1>, <0>;
> > + mediatek,long-press-mode = <1>;
> > + debounce-interval = <0>;
> > + };
> > + };
> > --
> > 1.7.9.5
> >
next prev parent reply other threads:[~2017-09-02 2:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 6:32 [PATCH v3 0/5] Add MediaTek PMIC keys support Chen Zhong
2017-08-25 6:32 ` [PATCH v3 1/5] mfd: mt6397: create irq mappings in mfd core driver Chen Zhong
2017-08-25 8:39 ` Alexandre Belloni
2017-08-25 6:32 ` [PATCH v3 2/5] dt-bindings: input: Add document bindings for mtk-pmic-keys Chen Zhong
2017-08-31 19:52 ` Rob Herring
2017-09-01 2:00 ` Chen Zhong
2017-09-02 2:16 ` Chen Zhong [this message]
2017-09-05 16:05 ` Rob Herring
2017-09-07 3:05 ` Chen Zhong
2017-08-25 6:32 ` [PATCH v3 3/5] dt-bindings: mfd: Add bindings for the keys as subnode of PMIC Chen Zhong
2017-09-05 7:36 ` Lee Jones
2017-08-25 6:32 ` [PATCH v3 4/5] input: Add MediaTek PMIC keys support Chen Zhong
2017-08-28 16:57 ` Dmitry Torokhov
2017-08-29 2:11 ` Chen Zhong
2017-08-29 7:34 ` Andi Shyti
2017-08-29 7:40 ` Chen Zhong
2017-08-25 6:32 ` [PATCH v3 5/5] mfd: mt6397: Add PMIC keys support to MT6397 driver Chen Zhong
2017-09-05 7:37 ` Lee Jones
2017-08-26 2:30 ` [PATCH v3 0/5] Add MediaTek PMIC keys support Chen Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1504318583.15359.12.camel@mhfsdcap03 \
--to=chen.zhong@mediatek.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=andi.shyti@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eddie.huang@mediatek.com \
--cc=javier@osg.samsung.com \
--cc=jcsing.lee@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).