From: Andi Shyti <andi.shyti@samsung.com>
To: Chen Zhong <chen.zhong@mediatek.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Lee Jones <lee.jones@linaro.org>,
Eddie Huang <eddie.huang@mediatek.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Jaechul Lee <jcsing.lee@samsung.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org
Subject: Re: [PATCH v3 4/5] input: Add MediaTek PMIC keys support
Date: Tue, 29 Aug 2017 16:34:53 +0900 [thread overview]
Message-ID: <20170829073453.GB4469@gangnam> (raw)
In-Reply-To: <1503642753-12385-5-git-send-email-chen.zhong@mediatek.com>
Hi Chen,
what I would ask you is to be consistent with the naming, if your
driver is called mtk-pmic, then all your functions and global
variables should be named accordingly as mtk_pmic or MTK_PMIC.
Please check in between the lines for real examples:
> +#define PWRKEY_RST_EN_MASK 0x1
> +#define PWRKEY_RST_EN_SHIFT 6
> +#define HOMEKEY_RST_EN_MASK 0x1
> +#define HOMEKEY_RST_EN_SHIFT 5
> +#define RST_DU_MASK 0x3
> +#define RST_DU_SHIFT 8
> +
> +#define PMIC_PWRKEY_INDEX 0
> +#define PMIC_HOMEKEY_INDEX 1
> +#define PMIC_MAX_KEY_COUNT 2
#define MTK_PMIC_*
> +struct pmic_keys_regs {
struct mtk_pmic_keys_regs
> + u32 deb_reg;
> + u32 deb_mask;
> + u32 intsel_reg;
> + u32 intsel_mask;
> +};
> +
> +#define PMIC_KEYS_REGS(_deb_reg, _deb_mask, _intsel_reg, _intsel_mask) \
MTK_PMIC_KEYS_REGS
> +{ \
> + .deb_reg = _deb_reg, \
> + .deb_mask = _deb_mask, \
> + .intsel_reg = _intsel_reg, \
> + .intsel_mask = _intsel_mask, \
> +}
> +
> +struct pmic_regs {
mtk_pmic_regs
and so on... you got the point.
Andi
next prev parent reply other threads:[~2017-08-29 7:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-25 6:32 [PATCH v3 0/5] Add MediaTek PMIC keys support Chen Zhong
2017-08-25 6:32 ` [PATCH v3 1/5] mfd: mt6397: create irq mappings in mfd core driver Chen Zhong
2017-08-25 8:39 ` Alexandre Belloni
2017-08-25 6:32 ` [PATCH v3 2/5] dt-bindings: input: Add document bindings for mtk-pmic-keys Chen Zhong
2017-08-31 19:52 ` Rob Herring
2017-09-01 2:00 ` Chen Zhong
2017-09-02 2:16 ` Chen Zhong
2017-09-05 16:05 ` Rob Herring
2017-09-07 3:05 ` Chen Zhong
2017-08-25 6:32 ` [PATCH v3 3/5] dt-bindings: mfd: Add bindings for the keys as subnode of PMIC Chen Zhong
2017-09-05 7:36 ` Lee Jones
2017-08-25 6:32 ` [PATCH v3 4/5] input: Add MediaTek PMIC keys support Chen Zhong
2017-08-28 16:57 ` Dmitry Torokhov
2017-08-29 2:11 ` Chen Zhong
2017-08-29 7:34 ` Andi Shyti [this message]
2017-08-29 7:40 ` Chen Zhong
2017-08-25 6:32 ` [PATCH v3 5/5] mfd: mt6397: Add PMIC keys support to MT6397 driver Chen Zhong
2017-09-05 7:37 ` Lee Jones
2017-08-26 2:30 ` [PATCH v3 0/5] Add MediaTek PMIC keys support Chen Zhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170829073453.GB4469@gangnam \
--to=andi.shyti@samsung.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=chen.zhong@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eddie.huang@mediatek.com \
--cc=javier@osg.samsung.com \
--cc=jcsing.lee@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).