linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Chen Zhong <chen.zhong@mediatek.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	Eddie Huang <eddie.huang@mediatek.com>,
	Alessandro Zummo <a.zummo@towertech.it>,
	Andi Shyti <andi.shyti@samsung.com>,
	Javier Martinez Canillas <javier@osg.samsung.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Jaechul Lee <jcsing.lee@samsung.com>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-rtc@vger.kernel.org
Subject: Re: [PATCH v3 1/5] mfd: mt6397: create irq mappings in mfd core driver
Date: Fri, 25 Aug 2017 10:39:29 +0200	[thread overview]
Message-ID: <20170825083929.ztyzfelwqcxvpiex@piout.net> (raw)
In-Reply-To: <1503642753-12385-2-git-send-email-chen.zhong@mediatek.com>

On 25/08/2017 at 14:32:29 +0800, Chen Zhong wrote:
> The core driver should create and manage irq mappings instead of
> leaf drivers. This patch change to pass irq domain to
> devm_mfd_add_devices() and it will create mapping for irq resources
> automatically. And remove irq mapping in rtc driver since this has
> been done in core driver.
> 
> Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> Signed-off-by: Chen Zhong <chen.zhong@mediatek.com>
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>

> ---
>  drivers/mfd/mt6397-core.c |    4 ++--
>  drivers/rtc/rtc-mt6397.c  |    7 +++----
>  2 files changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 04a601f..6546d7f 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -289,7 +289,7 @@ static int mt6397_probe(struct platform_device *pdev)
>  
>  		ret = devm_mfd_add_devices(&pdev->dev, -1, mt6323_devs,
>  					   ARRAY_SIZE(mt6323_devs), NULL,
> -					   0, NULL);
> +					   0, pmic->irq_domain);
>  		break;
>  
>  	case MT6397_CID_CODE:
> @@ -304,7 +304,7 @@ static int mt6397_probe(struct platform_device *pdev)
>  
>  		ret = devm_mfd_add_devices(&pdev->dev, -1, mt6397_devs,
>  					   ARRAY_SIZE(mt6397_devs), NULL,
> -					   0, NULL);
> +					   0, pmic->irq_domain);
>  		break;
>  
>  	default:
> diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c
> index 1a61fa5..385f830 100644
> --- a/drivers/rtc/rtc-mt6397.c
> +++ b/drivers/rtc/rtc-mt6397.c
> @@ -322,10 +322,9 @@ static int mtk_rtc_probe(struct platform_device *pdev)
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>  	rtc->addr_base = res->start;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
> -	rtc->irq = irq_create_mapping(mt6397_chip->irq_domain, res->start);
> -	if (rtc->irq <= 0)
> -		return -EINVAL;
> +	rtc->irq = platform_get_irq(pdev, 0);
> +	if (rtc->irq < 0)
> +		return rtc->irq;
>  
>  	rtc->regmap = mt6397_chip->regmap;
>  	rtc->dev = &pdev->dev;
> -- 
> 1.7.9.5
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2017-08-25  8:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-25  6:32 [PATCH v3 0/5] Add MediaTek PMIC keys support Chen Zhong
2017-08-25  6:32 ` [PATCH v3 1/5] mfd: mt6397: create irq mappings in mfd core driver Chen Zhong
2017-08-25  8:39   ` Alexandre Belloni [this message]
2017-08-25  6:32 ` [PATCH v3 2/5] dt-bindings: input: Add document bindings for mtk-pmic-keys Chen Zhong
2017-08-31 19:52   ` Rob Herring
2017-09-01  2:00     ` Chen Zhong
2017-09-02  2:16     ` Chen Zhong
2017-09-05 16:05       ` Rob Herring
2017-09-07  3:05         ` Chen Zhong
2017-08-25  6:32 ` [PATCH v3 3/5] dt-bindings: mfd: Add bindings for the keys as subnode of PMIC Chen Zhong
2017-09-05  7:36   ` Lee Jones
2017-08-25  6:32 ` [PATCH v3 4/5] input: Add MediaTek PMIC keys support Chen Zhong
2017-08-28 16:57   ` Dmitry Torokhov
2017-08-29  2:11     ` Chen Zhong
2017-08-29  7:34   ` Andi Shyti
2017-08-29  7:40     ` Chen Zhong
2017-08-25  6:32 ` [PATCH v3 5/5] mfd: mt6397: Add PMIC keys support to MT6397 driver Chen Zhong
2017-09-05  7:37   ` Lee Jones
2017-08-26  2:30 ` [PATCH v3 0/5] Add MediaTek PMIC keys support Chen Zhong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170825083929.ztyzfelwqcxvpiex@piout.net \
    --to=alexandre.belloni@free-electrons.com \
    --cc=a.zummo@towertech.it \
    --cc=andi.shyti@samsung.com \
    --cc=chen.zhong@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=eddie.huang@mediatek.com \
    --cc=javier@osg.samsung.com \
    --cc=jcsing.lee@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).