linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Filippo Sironi <sironi@amazon.de>
To: pbonzini@redhat.com, rkrcmar@redhat.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Cc: Filippo Sironi <sironi@amazon.de>
Subject: [PATCH 2/2] KVM: x86: Allow userspace to define what's the microcode version
Date: Sun, 26 Nov 2017 17:41:22 +0100	[thread overview]
Message-ID: <1511714482-3273-2-git-send-email-sironi@amazon.de> (raw)
In-Reply-To: <1511714482-3273-1-git-send-email-sironi@amazon.de>

... that the guest should see.
Guest operating systems may check the microcode version to decide whether
to disable certain features that are known to be buggy up to certain
microcode versions.  Address the issue by making the microcode version
that the guest should see settable.
The rationale for having userspace specifying the microcode version, rather
than having the kernel picking it, is to ensure consistency for live-migrated
instances; we don't want them to see a microcode version increase without a
reset.

Signed-off-by: Filippo Sironi <sironi@amazon.de>
---
 arch/x86/kvm/x86.c       | 23 +++++++++++++++++++++++
 include/uapi/linux/kvm.h |  3 +++
 2 files changed, 26 insertions(+)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 925c3e29cad3..741588f27ebc 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -4033,6 +4033,29 @@ long kvm_arch_vm_ioctl(struct file *filp,
 	} u;
 
 	switch (ioctl) {
+	case KVM_GET_MICROCODE_VERSION: {
+		r = -EFAULT;
+		if (copy_to_user(argp,
+				 &kvm->arch.microcode_version,
+				 sizeof(kvm->arch.microcode_version)))
+			goto out;
+		break;
+	}
+	case KVM_SET_MICROCODE_VERSION: {
+		u32 microcode_version;
+
+		r = -EFAULT;
+		if (copy_from_user(&microcode_version,
+				   argp,
+				   sizeof(microcode_version)))
+			goto out;
+		r = -EINVAL;
+		if (!microcode_version)
+			goto out;
+		kvm->arch.microcode_version = microcode_version;
+		r = 0;
+		break;
+	}
 	case KVM_SET_TSS_ADDR:
 		r = kvm_vm_ioctl_set_tss_addr(kvm, arg);
 		break;
diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h
index 282d7613fce8..e11887758e29 100644
--- a/include/uapi/linux/kvm.h
+++ b/include/uapi/linux/kvm.h
@@ -1192,6 +1192,9 @@ struct kvm_s390_ucas_mapping {
 #define KVM_S390_UCAS_UNMAP      _IOW(KVMIO, 0x51, struct kvm_s390_ucas_mapping)
 #define KVM_S390_VCPU_FAULT	 _IOW(KVMIO, 0x52, unsigned long)
 
+#define KVM_GET_MICROCODE_VERSION _IOR(KVMIO, 0x5e, __u32)
+#define KVM_SET_MICROCODE_VERSION _IOW(KVMIO, 0x5f, __u32)
+
 /* Device model IOC */
 #define KVM_CREATE_IRQCHIP        _IO(KVMIO,   0x60)
 #define KVM_IRQ_LINE              _IOW(KVMIO,  0x61, struct kvm_irq_level)
-- 
2.7.4

  reply	other threads:[~2017-11-26 16:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-26 16:41 [PATCH 1/2] KVM: x86: Store the microcode version in struct kvm_arch Filippo Sironi
2017-11-26 16:41 ` Filippo Sironi [this message]
2017-11-27  1:02   ` [PATCH 2/2] KVM: x86: Allow userspace to define what's the microcode version Wanpeng Li
2017-12-09  7:21     ` Sironi, Filippo
2017-11-27 10:40   ` Paolo Bonzini
2017-12-09  7:33     ` Sironi, Filippo
2017-11-27 11:58   ` Paolo Bonzini
2017-11-27 22:09     ` Steve Rutherford
2017-12-09  7:51       ` Sironi, Filippo
2017-12-09  7:42     ` Sironi, Filippo
2017-12-11 16:03       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1511714482-3273-2-git-send-email-sironi@amazon.de \
    --to=sironi@amazon.de \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).