From: "Sironi, Filippo" <sironi@amazon.de>
To: Steve Rutherford <srutherford@google.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"KVM list" <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] KVM: x86: Allow userspace to define what's the microcode version
Date: Sat, 9 Dec 2017 07:51:22 +0000 [thread overview]
Message-ID: <9F8D2D88-6ACC-444A-8538-8B231051C969@amazon.de> (raw)
In-Reply-To: <CABayD+dirdj9k=y=yKKJos+Wp-Yh91aO8RJwqMP-1UP54qD3+w@mail.gmail.com>
> On 27. Nov 2017, at 14:09, Steve Rutherford <srutherford@google.com> wrote:
>
> On Mon, Nov 27, 2017 at 3:58 AM, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> On 26/11/2017 17:41, Filippo Sironi wrote:
>>> ... that the guest should see.
>>> Guest operating systems may check the microcode version to decide whether
>>> to disable certain features that are known to be buggy up to certain
>>> microcode versions. Address the issue by making the microcode version
>>> that the guest should see settable.
>>> The rationale for having userspace specifying the microcode version, rather
>>> than having the kernel picking it, is to ensure consistency for live-migrated
>>> instances; we don't want them to see a microcode version increase without a
>>> reset.
>>>
>>> Signed-off-by: Filippo Sironi <sironi@amazon.de>
>>> ---
>>> arch/x86/kvm/x86.c | 23 +++++++++++++++++++++++
>>> include/uapi/linux/kvm.h | 3 +++
>>> 2 files changed, 26 insertions(+)
>>>
>>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>>> index 925c3e29cad3..741588f27ebc 100644
>>> --- a/arch/x86/kvm/x86.c
>>> +++ b/arch/x86/kvm/x86.c
>>> @@ -4033,6 +4033,29 @@ long kvm_arch_vm_ioctl(struct file *filp,
>>> } u;
>>>
>>> switch (ioctl) {
>>> + case KVM_GET_MICROCODE_VERSION: {
>>> + r = -EFAULT;
>>> + if (copy_to_user(argp,
>>> + &kvm->arch.microcode_version,
>>> + sizeof(kvm->arch.microcode_version)))
>>> + goto out;
>>> + break;
>>> + }
>>> + case KVM_SET_MICROCODE_VERSION: {
>>> + u32 microcode_version;
>>> +
>>> + r = -EFAULT;
>>> + if (copy_from_user(µcode_version,
>>> + argp,
>>> + sizeof(microcode_version)))
>>> + goto out;
>>> + r = -EINVAL;
>>> + if (!microcode_version)
>>> + goto out;
>>> + kvm->arch.microcode_version = microcode_version;
>>> + r = 0;
>>> + break;
>>> + }
>>
>> Also, there's no need to define new ioctls, instead you can just place
>> it in the vcpu and use KVM_GET_MSR/KVM_SET_MSR. I'd agree that's
>> slightly less polished, but it matches what we do already for e.g.
>> nested VMX model specific registers. And it spares you for writing the
>> documentation that you didn't include in this patch. :)
>>
>> Paolo
>
> This feels good time to mention Peter Hornyack's old MSR KVM_EXIT
> patches. With something like them, there would be no need to push this
> into the kernel at all.
That's one of the solution we discussed internally (at Amazon) but we
didn't pursue yet given the need to release a quick fix for customers.
I was thinking about implementing a mechanism to selectively go back to
userspace to emulate MSRs; something that's not limited to KVM unhandled
MSRs but that instead could even override KVM's handling.
Filippo
Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B
next prev parent reply other threads:[~2017-12-09 7:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 16:41 [PATCH 1/2] KVM: x86: Store the microcode version in struct kvm_arch Filippo Sironi
2017-11-26 16:41 ` [PATCH 2/2] KVM: x86: Allow userspace to define what's the microcode version Filippo Sironi
2017-11-27 1:02 ` Wanpeng Li
2017-12-09 7:21 ` Sironi, Filippo
2017-11-27 10:40 ` Paolo Bonzini
2017-12-09 7:33 ` Sironi, Filippo
2017-11-27 11:58 ` Paolo Bonzini
2017-11-27 22:09 ` Steve Rutherford
2017-12-09 7:51 ` Sironi, Filippo [this message]
2017-12-09 7:42 ` Sironi, Filippo
2017-12-11 16:03 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9F8D2D88-6ACC-444A-8538-8B231051C969@amazon.de \
--to=sironi@amazon.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=srutherford@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).