[PATCH 0/2] serial: stm32: fix name conflict

[PATCH 0/2] serial: stm32: fix name conflict

[Ludovic Barre]

From: Ludovic Barre <ludovic.barre@st.com>

This patch series:
-fix name conflict, when both driver 8250/stm32-usart
are activated. Replace stm32 tty name "ttyS" by "ttySTM".
-by default add stm32 console when SERIAL_STM32 is selected.

Ludovic Barre (2):
  serial: stm32: add default console
  serial: stm32: fix name conflict with 8250

 drivers/tty/serial/Kconfig       | 1 +
 drivers/tty/serial/stm32-usart.h | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

-- 
2.7.4

[PATCH 1/2] serial: stm32: add default console

[Ludovic Barre]

From: Ludovic Barre <ludovic.barre@st.com>

This patch adds by default the console support
on stm32.

Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
---
 drivers/tty/serial/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index b788fee..969e598 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -1664,6 +1664,7 @@ config SERIAL_STM32_CONSOLE
 	bool "Support for console on STM32"
 	depends on SERIAL_STM32=y
 	select SERIAL_CORE_CONSOLE
+	default y
 
 config SERIAL_MVEBU_UART
 	bool "Marvell EBU serial port support"
-- 
2.7.4

[PATCH 2/2] serial: stm32: fix name conflict with 8250

[Ludovic Barre]

From: Ludovic Barre <ludovic.barre@st.com>

This patch replaces stm32 tty name ttyS by ttySTM
to avoid a name conflict when Serial: 8250/16550 driver
is activated.

sysfs: cannot create duplicate filename '/class/tty/ttyS3'
Modules linked in:
CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.14.0-12903-gb392521-dirty #1
[<c03118dc>] (unwind_backtrace) from [<c030c950>] (show_stack+0x10/0x14)
[<c030c950>] (show_stack) from [<c0d31e18>] (dump_stack+0x90/0xa4)
[<c0d31e18>] (dump_stack) from [<c03430a0>] (__warn+0xf8/0x110)
[<c03430a0>] (__warn) from [<c03430f0>] (warn_slowpath_fmt+0x38/0x48)
[<c03430f0>] (warn_slowpath_fmt) from [<c04ce574>] (sysfs_warn_dup+0x68/0x78)
[<c04ce574>] (sysfs_warn_dup) from [<c04ce824>] (sysfs_do_create_link_sd+0xb4/0xc4)
[<c04ce824>] (sysfs_do_create_link_sd) from [<c08c60ec>] (device_add+0x204/0x574)
[<c08c60ec>] (device_add) from [<c07a7ddc>] (tty_register_device_attr+0xc8/0x1bc)
[<c07a7ddc>] (tty_register_device_attr) from [<c07c6530>] (uart_add_one_port+0x22c/0x4f4)

Signed-off-by: Ludovic Barre <ludovic.barre@st.com>
---
 drivers/tty/serial/stm32-usart.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/stm32-usart.h b/drivers/tty/serial/stm32-usart.h
index 8a5ff54..2294d0f 100644
--- a/drivers/tty/serial/stm32-usart.h
+++ b/drivers/tty/serial/stm32-usart.h
@@ -236,7 +236,7 @@ struct stm32_usart_info stm32h7_info = {
 #define USART_ICR_CMCF		BIT(17)		/* F7 */
 #define USART_ICR_WUCF		BIT(20)		/* H7 */
 
-#define STM32_SERIAL_NAME "ttyS"
+#define STM32_SERIAL_NAME "ttySTM"
 #define STM32_MAX_PORTS 8
 
 #define RX_BUF_L 200		 /* dma rx buffer length     */
-- 
2.7.4

Re: [PATCH 1/2] serial: stm32: add default console

[Greg Kroah-Hartman]

On Fri, Dec 01, 2017 at 05:36:50PM +0100, Ludovic Barre wrote:
> From: Ludovic Barre <ludovic.barre@st.com>
> 
> This patch adds by default the console support
> on stm32.

Why?  'default y' should only mean "machine will not boot without this".
And I think your machine will boot without the console, right?  :)

thanks,

greg k-h

Re: [PATCH 1/2] serial: stm32: add default console

[Ludovic BARRE]

hi Greg

Yes, the machine could be boot without console. but our
boards has a console by default. it is just to simplified the
configuration.
you can abandoned this patch, if you prefer.

BR
Ludo

On 12/15/2017 08:25 PM, Greg Kroah-Hartman wrote:
> On Fri, Dec 01, 2017 at 05:36:50PM +0100, Ludovic Barre wrote:
>> From: Ludovic Barre <ludovic.barre@st.com>
>>
>> This patch adds by default the console support
>> on stm32.
> 
> Why?  'default y' should only mean "machine will not boot without this".
> And I think your machine will boot without the console, right?  :)
> 
> thanks,
> 
> greg k-h
>