[PATCH] mm/sparse.c: Wrong allocation for mem_section

* [PATCH] mm/sparse.c: Wrong allocation for mem_section
@ 2017-12-22  8:48 Baoquan He
  2017-12-23  9:54 ` Kirill A. Shutemov
  0 siblings, 1 reply; 2+ messages in thread
From: Baoquan He @ 2017-12-22  8:48 UTC (permalink / raw)
  To: linux-kernel
  Cc: Baoquan He, Ingo Molnar, Andrew Morton, Andy Lutomirski,
	Peter Zijlstra, Thomas Gleixner, Atsushi Kumagai, linux-mm

In commit

  83e3c48729 "mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y"

mem_section is allocated at runtime to save memory. While it allocates
the first dimension of array with sizeof(struct mem_section). It costs 
extra memory, should be sizeof(struct mem_section*).

Fix it.

Signed-off-by: Baoquan He <bhe@redhat.com>
Tested-by: Dave Young <dyoung@redhat.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Atsushi Kumagai <ats-kumagai@wm.jp.nec.com>
Cc: linux-mm@kvack.org

---
 mm/sparse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/sparse.c b/mm/sparse.c
index 7a5dacaa06e3..2609aba121e8 100644
--- a/mm/sparse.c
+++ b/mm/sparse.c
@@ -211,7 +211,7 @@ void __init memory_present(int nid, unsigned long start, unsigned long end)
 	if (unlikely(!mem_section)) {
 		unsigned long size, align;
 
-		size = sizeof(struct mem_section) * NR_SECTION_ROOTS;
+		size = sizeof(struct mem_section*) * NR_SECTION_ROOTS;
 		align = 1 << (INTERNODE_CACHE_SHIFT);
 		mem_section = memblock_virt_alloc(size, align);
 	}
-- 
2.5.5

^ permalink raw reply related	[flat|nested] 2+ messages in thread