* [PATCH] drm/stm: ltdc: rework reset sequence
@ 2018-06-29 11:22 Yannick Fertre
2018-07-03 11:02 ` Philippe CORNU
2018-07-06 8:22 ` Benjamin Gaignard
0 siblings, 2 replies; 3+ messages in thread
From: Yannick Fertre @ 2018-06-29 11:22 UTC (permalink / raw)
To: Yannick Fertre, Philippe Cornu, Benjamin Gaignard,
Vincent Abriou, David Airlie, dri-devel, linux-kernel
Reset must be properly assert before deassert.
This is important if there is an early boot splash screen
before the kernel start up.
Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
---
drivers/gpu/drm/stm/ltdc.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index 96d20c2..8f4606d 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -1130,8 +1130,11 @@ int ltdc_load(struct drm_device *ddev)
}
}
- if (!IS_ERR(rstc))
+ if (!IS_ERR(rstc)) {
+ reset_control_assert(rstc);
+ usleep_range(10, 20);
reset_control_deassert(rstc);
+ }
/* Disable interrupts */
reg_clear(ldev->regs, LTDC_IER,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/stm: ltdc: rework reset sequence
2018-06-29 11:22 [PATCH] drm/stm: ltdc: rework reset sequence Yannick Fertre
@ 2018-07-03 11:02 ` Philippe CORNU
2018-07-06 8:22 ` Benjamin Gaignard
1 sibling, 0 replies; 3+ messages in thread
From: Philippe CORNU @ 2018-07-03 11:02 UTC (permalink / raw)
To: Yannick FERTRE, Benjamin Gaignard, Vincent ABRIOU, David Airlie,
dri-devel, linux-kernel
Hi Yannick,
On 06/29/2018 01:22 PM, Yannick Fertre wrote:
> Reset must be properly assert before deassert.
> This is important if there is an early boot splash screen
> before the kernel start up.
>
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 96d20c2..8f4606d 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1130,8 +1130,11 @@ int ltdc_load(struct drm_device *ddev)
> }
> }
>
> - if (!IS_ERR(rstc))
> + if (!IS_ERR(rstc)) {
> + reset_control_assert(rstc);
> + usleep_range(10, 20);
> reset_control_deassert(rstc);
> + }
Thank you for your patch,
Reviewed-by: Philippe Cornu <philippe.cornu@st.com>
Tested-by: Philippe Cornu <philippe.cornu@st.com>
Philippe :-)
>
> /* Disable interrupts */
> reg_clear(ldev->regs, LTDC_IER,
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/stm: ltdc: rework reset sequence
2018-06-29 11:22 [PATCH] drm/stm: ltdc: rework reset sequence Yannick Fertre
2018-07-03 11:02 ` Philippe CORNU
@ 2018-07-06 8:22 ` Benjamin Gaignard
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Gaignard @ 2018-07-06 8:22 UTC (permalink / raw)
To: Yannick Fertre
Cc: Philippe Cornu, Vincent Abriou, David Airlie, dri-devel,
Linux Kernel Mailing List
2018-06-29 13:22 GMT+02:00 Yannick Fertre <yannick.fertre@st.com>:
> Reset must be properly assert before deassert.
> This is important if there is an early boot splash screen
> before the kernel start up.
>
> Signed-off-by: Yannick Fertre <yannick.fertre@st.com>
Applied on drm-misc-next.
Thansk,
Benjamin
> ---
> drivers/gpu/drm/stm/ltdc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index 96d20c2..8f4606d 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1130,8 +1130,11 @@ int ltdc_load(struct drm_device *ddev)
> }
> }
>
> - if (!IS_ERR(rstc))
> + if (!IS_ERR(rstc)) {
> + reset_control_assert(rstc);
> + usleep_range(10, 20);
> reset_control_deassert(rstc);
> + }
>
> /* Disable interrupts */
> reg_clear(ldev->regs, LTDC_IER,
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-06 8:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-29 11:22 [PATCH] drm/stm: ltdc: rework reset sequence Yannick Fertre
2018-07-03 11:02 ` Philippe CORNU
2018-07-06 8:22 ` Benjamin Gaignard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).