* [RESEND PATCH v4 0/2] Add aproperty in at24.c
@ 2018-07-25 3:20 alanx.chiang
2018-07-25 3:20 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
2018-07-25 3:20 ` [RESEND PATCH v4 2/2] eeprom: at24: Add support for " alanx.chiang
0 siblings, 2 replies; 5+ messages in thread
From: alanx.chiang @ 2018-07-25 3:20 UTC (permalink / raw)
To: linux-i2c
Cc: andy.yeh, sakari.ailus, andriy.shevchenko, andriy.shevchenko,
rajmohan.mani, andy.shevchenko, tfiga, jcliang, brgl, robh+dt,
mark.rutland, arnd, rpjday, gregkh, linux-kernel, devicetree,
Alan Chiang
From: Alan Chiang <alanx.chiang@intel.com>
The RESEND PATCH modifies the commit message and adds the Reviewed-by.
In at24.c, it uses 8-bit addressing by default. In this patch add a
property address-width that provides a flexible method to pass the
information to the driver.
Alan Chiang (2):
dt-bindings: at24: Add address-width property
eeprom: at24: Add support for address-width property
Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
drivers/misc/eeprom/at24.c | 17 +++++++++++++++++
2 files changed, 19 insertions(+)
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
2018-07-25 3:20 [RESEND PATCH v4 0/2] Add aproperty in at24.c alanx.chiang
@ 2018-07-25 3:20 ` alanx.chiang
2018-07-25 7:35 ` Bartosz Golaszewski
2018-07-25 3:20 ` [RESEND PATCH v4 2/2] eeprom: at24: Add support for " alanx.chiang
1 sibling, 1 reply; 5+ messages in thread
From: alanx.chiang @ 2018-07-25 3:20 UTC (permalink / raw)
To: linux-i2c
Cc: andy.yeh, sakari.ailus, andriy.shevchenko, andriy.shevchenko,
rajmohan.mani, andy.shevchenko, tfiga, jcliang, brgl, robh+dt,
mark.rutland, arnd, rpjday, gregkh, linux-kernel, devicetree,
Alan Chiang
From: Alan Chiang <alanx.chiang@intel.com>
Currently the only way to use a variant of a supported model with
a different address with a different address width is to define a
new compatible string and the corresponding chip data structure.
Provide a flexible way to specify the size of the address pointer
by defining a new property: address-width.
Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
Signed-off-by: Andy Yeh <andy.yeh@intel.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
index 61d833a..aededdb 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.txt
+++ b/Documentation/devicetree/bindings/eeprom/at24.txt
@@ -72,6 +72,8 @@ Optional properties:
- wp-gpios: GPIO to which the write-protect pin of the chip is connected.
+ - address-width: number of address bits (one of 8, 16).
+
Example:
eeprom@52 {
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [RESEND PATCH v4 2/2] eeprom: at24: Add support for address-width property
2018-07-25 3:20 [RESEND PATCH v4 0/2] Add aproperty in at24.c alanx.chiang
2018-07-25 3:20 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
@ 2018-07-25 3:20 ` alanx.chiang
1 sibling, 0 replies; 5+ messages in thread
From: alanx.chiang @ 2018-07-25 3:20 UTC (permalink / raw)
To: linux-i2c
Cc: andy.yeh, sakari.ailus, andriy.shevchenko, andriy.shevchenko,
rajmohan.mani, andy.shevchenko, tfiga, jcliang, brgl, robh+dt,
mark.rutland, arnd, rpjday, gregkh, linux-kernel, devicetree,
Alan Chiang
From: Alan Chiang <alanx.chiang@intel.com>
Provide a flexible way to determine the addressing bits of eeprom.
Pass the addressing bits to driver through address-width property.
Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
Signed-off-by: Andy Yeh <andy.yeh@intel.com>
---
drivers/misc/eeprom/at24.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 0c125f2..7ea640b 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -478,6 +478,23 @@ static void at24_properties_to_pdata(struct device *dev,
if (device_property_present(dev, "no-read-rollover"))
chip->flags |= AT24_FLAG_NO_RDROL;
+ err = device_property_read_u32(dev, "address-width", &val);
+ if (!err) {
+ switch (val) {
+ case 8:
+ if (chip->flags & AT24_FLAG_ADDR16)
+ dev_warn(dev, "Override address width to be 8, while default is 16\n");
+ chip->flags &= ~AT24_FLAG_ADDR16;
+ break;
+ case 16:
+ chip->flags |= AT24_FLAG_ADDR16;
+ break;
+ default:
+ dev_warn(dev, "Bad \"address-width\" property: %u\n",
+ val);
+ }
+ }
+
err = device_property_read_u32(dev, "size", &val);
if (!err)
chip->byte_len = val;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property
2018-07-25 3:20 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
@ 2018-07-25 7:35 ` Bartosz Golaszewski
0 siblings, 0 replies; 5+ messages in thread
From: Bartosz Golaszewski @ 2018-07-25 7:35 UTC (permalink / raw)
To: Chiang, AlanX
Cc: linux-i2c, Yeh, Andy, Sakari Ailus, Andy Shevchenko, Shevchenko,
Andriy, Rajmohan Mani, Andy Shevchenko, tfiga, jcliang,
Rob Herring, Mark Rutland, Arnd Bergmann, Robert P. J. Day,
Greg Kroah-Hartman, Linux Kernel Mailing List, devicetree
2018-07-25 5:20 GMT+02:00 <alanx.chiang@intel.com>:
> From: Alan Chiang <alanx.chiang@intel.com>
>
> Currently the only way to use a variant of a supported model with
> a different address with a different address width is to define a
There's some copy-paste problem here. I fixed it.
> new compatible string and the corresponding chip data structure.
>
> Provide a flexible way to specify the size of the address pointer
> by defining a new property: address-width.
>
> Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
> Signed-off-by: Andy Yeh <andy.yeh@intel.com>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/eeprom/at24.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/eeprom/at24.txt b/Documentation/devicetree/bindings/eeprom/at24.txt
> index 61d833a..aededdb 100644
> --- a/Documentation/devicetree/bindings/eeprom/at24.txt
> +++ b/Documentation/devicetree/bindings/eeprom/at24.txt
> @@ -72,6 +72,8 @@ Optional properties:
>
> - wp-gpios: GPIO to which the write-protect pin of the chip is connected.
>
> + - address-width: number of address bits (one of 8, 16).
> +
> Example:
>
> eeprom@52 {
> --
> 2.7.4
>
Applied both to for-next.
Bart
^ permalink raw reply [flat|nested] 5+ messages in thread
* [RESEND PATCH v4 2/2] eeprom: at24: Add support for address-width property
2018-07-02 9:12 [RESEND PATCH v4 0/2] Add a property in at24.c alanx.chiang
@ 2018-07-02 9:12 ` alanx.chiang
0 siblings, 0 replies; 5+ messages in thread
From: alanx.chiang @ 2018-07-02 9:12 UTC (permalink / raw)
To: linux-i2c
Cc: andy.yeh, sakari.ailus, andriy.shevchenko, andriy.shevchenko,
rajmohan.mani, andy.shevchenko, tfiga, jcliang, brgl, robh+dt,
mark.rutland, arnd, gregkh, linux-kernel, devicetree,
Alan Chiang
From: Alan Chiang <alanx.chiang@intel.com>
Provide a flexible way to determine the addressing bits of eeprom.
Pass the addressing bits to driver through address-width property.
Signed-off-by: Alan Chiang <alanx.chiang@intel.com>
Signed-off-by: Andy Yeh <andy.yeh@intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
---
since v1
-- Add a warn message for 8-bit addressing.
since v2
-- Modify the warning message for clear.
-- Move the clearing bit operation outside of a statement.
since v3
-- Merge the warning message into one line.
---
drivers/misc/eeprom/at24.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 0c125f2..7ea640b 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -478,6 +478,23 @@ static void at24_properties_to_pdata(struct device *dev,
if (device_property_present(dev, "no-read-rollover"))
chip->flags |= AT24_FLAG_NO_RDROL;
+ err = device_property_read_u32(dev, "address-width", &val);
+ if (!err) {
+ switch (val) {
+ case 8:
+ if (chip->flags & AT24_FLAG_ADDR16)
+ dev_warn(dev, "Override address width to be 8, while default is 16\n");
+ chip->flags &= ~AT24_FLAG_ADDR16;
+ break;
+ case 16:
+ chip->flags |= AT24_FLAG_ADDR16;
+ break;
+ default:
+ dev_warn(dev, "Bad \"address-width\" property: %u\n",
+ val);
+ }
+ }
+
err = device_property_read_u32(dev, "size", &val);
if (!err)
chip->byte_len = val;
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-25 7:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25 3:20 [RESEND PATCH v4 0/2] Add aproperty in at24.c alanx.chiang
2018-07-25 3:20 ` [RESEND PATCH v4 1/2] dt-bindings: at24: Add address-width property alanx.chiang
2018-07-25 7:35 ` Bartosz Golaszewski
2018-07-25 3:20 ` [RESEND PATCH v4 2/2] eeprom: at24: Add support for " alanx.chiang
-- strict thread matches above, loose matches on Subject: below --
2018-07-02 9:12 [RESEND PATCH v4 0/2] Add a property in at24.c alanx.chiang
2018-07-02 9:12 ` [RESEND PATCH v4 2/2] eeprom: at24: Add support for address-width property alanx.chiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).