linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
@ 2018-08-18  9:14 Liu Xiang
  2018-08-27  8:06 ` Boris Brezillon
  0 siblings, 1 reply; 4+ messages in thread
From: Liu Xiang @ 2018-08-18  9:14 UTC (permalink / raw)
  To: linux-mtd
  Cc: linux-kernel, han.xu, marek.vasut, dwmw2, computersforpeace,
	boris.brezillon, richard, liuxiang_1999, Liu Xiang

If the size of spi-nor flash is larger than 16MB, the read_opcode
is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
cause read operation fail.

Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
---
 drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
index 7d9620c..64304a3 100644
--- a/drivers/mtd/spi-nor/fsl-quadspi.c
+++ b/drivers/mtd/spi-nor/fsl-quadspi.c
@@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
 {
 	switch (cmd) {
 	case SPINOR_OP_READ_1_1_4:
+	case SPINOR_OP_READ_1_1_4_4B:
 		return SEQID_READ;
 	case SPINOR_OP_WREN:
 		return SEQID_WREN;
-- 
1.9.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
  2018-08-18  9:14 [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB Liu Xiang
@ 2018-08-27  8:06 ` Boris Brezillon
  2018-08-27 15:02   ` liuxiang
  0 siblings, 1 reply; 4+ messages in thread
From: Boris Brezillon @ 2018-08-27  8:06 UTC (permalink / raw)
  To: Liu Xiang
  Cc: linux-mtd, linux-kernel, han.xu, marek.vasut, dwmw2,
	computersforpeace, richard, liuxiang_1999, Yogesh Narayan Gaur

On Sat, 18 Aug 2018 17:14:23 +0800
Liu Xiang <liu.xiang6@zte.com.cn> wrote:

> If the size of spi-nor flash is larger than 16MB, the read_opcode
> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
> cause read operation fail.
> 
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>

I'm pretty sure you want to backport this fix. Can you add a Fixes tag
and CC stable?

Also, I'd like to have an Ack from someone working at NXP (Han,
Yogesh?).

Thanks,

Boris.

> ---
>  drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 7d9620c..64304a3 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
>  {
>  	switch (cmd) {
>  	case SPINOR_OP_READ_1_1_4:
> +	case SPINOR_OP_READ_1_1_4_4B:
>  		return SEQID_READ;
>  	case SPINOR_OP_WREN:
>  		return SEQID_WREN;


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re:Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
  2018-08-27  8:06 ` Boris Brezillon
@ 2018-08-27 15:02   ` liuxiang
  2018-08-27 15:20     ` Boris Brezillon
  0 siblings, 1 reply; 4+ messages in thread
From: liuxiang @ 2018-08-27 15:02 UTC (permalink / raw)
  To: Boris Brezillon
  Cc: Liu Xiang, linux-mtd, linux-kernel, han.xu, marek.vasut, dwmw2,
	computersforpeace, richard, Yogesh Narayan Gaur



Fixes:e46ecda764dc37f9fc6279d95ea2c007daef1a71("mtd: spi-nor: Add Freescale QuadSPI driver")
Cc: stable@vger.kernel.org

Should I send a V2 patch that adds these above?




At 2018-08-27 16:06:13, "Boris Brezillon" <boris.brezillon@bootlin.com> wrote:
>On Sat, 18 Aug 2018 17:14:23 +0800
>Liu Xiang <liu.xiang6@zte.com.cn> wrote:
>
>> If the size of spi-nor flash is larger than 16MB, the read_opcode
>> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
>> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
>> cause read operation fail.
>> 
>> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
>
>I'm pretty sure you want to backport this fix. Can you add a Fixes tag
>and CC stable?
>
>Also, I'd like to have an Ack from someone working at NXP (Han,
>Yogesh?).
>
>Thanks,
>
>Boris.
>
>> ---
>>  drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
>> index 7d9620c..64304a3 100644
>> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
>> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
>> @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
>>  {
>>  	switch (cmd) {
>>  	case SPINOR_OP_READ_1_1_4:
>> +	case SPINOR_OP_READ_1_1_4_4B:
>>  		return SEQID_READ;
>>  	case SPINOR_OP_WREN:
>>  		return SEQID_WREN;

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
  2018-08-27 15:02   ` liuxiang
@ 2018-08-27 15:20     ` Boris Brezillon
  0 siblings, 0 replies; 4+ messages in thread
From: Boris Brezillon @ 2018-08-27 15:20 UTC (permalink / raw)
  To: liuxiang
  Cc: Liu Xiang, linux-mtd, linux-kernel, han.xu, marek.vasut, dwmw2,
	computersforpeace, richard, Yogesh Narayan Gaur

On Mon, 27 Aug 2018 23:02:29 +0800 (CST)
liuxiang  <liuxiang_1999@126.com> wrote:

> Fixes:e46ecda764dc37f9fc6279d95ea2c007daef1a71("mtd: spi-nor: Add Freescale QuadSPI driver")

12 digits should be enough for the commit-id.

> Cc: stable@vger.kernel.org
> 
> Should I send a V2 patch that adds these above?

Yes please.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-08-27 15:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-18  9:14 [PATCH] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB Liu Xiang
2018-08-27  8:06 ` Boris Brezillon
2018-08-27 15:02   ` liuxiang
2018-08-27 15:20     ` Boris Brezillon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).