* [PATCH] net: ethernet: ti: add missing GENERIC_ALLOCATOR dependency
@ 2018-09-14 11:20 Corentin Labbe
2018-09-17 14:49 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Corentin Labbe @ 2018-09-14 11:20 UTC (permalink / raw)
To: davem; +Cc: linux-kernel, netdev, Corentin Labbe
This patch mades TI_DAVINCI_CPDMA select GENERIC_ALLOCATOR.
without that, the following sparc64 build failure happen
drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_check_free_tx_desc':
(.text+0x278): undefined reference to `gen_pool_avail'
drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_chan_submit':
(.text+0x340): undefined reference to `gen_pool_alloc'
(.text+0x5c4): undefined reference to `gen_pool_free'
drivers/net/ethernet/ti/davinci_cpdma.o: In function `__cpdma_chan_free':
davinci_cpdma.c:(.text+0x64c): undefined reference to `gen_pool_free'
drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_desc_pool_destroy.isra.6':
davinci_cpdma.c:(.text+0x17ac): undefined reference to `gen_pool_size'
davinci_cpdma.c:(.text+0x17b8): undefined reference to `gen_pool_avail'
davinci_cpdma.c:(.text+0x1824): undefined reference to `gen_pool_size'
davinci_cpdma.c:(.text+0x1830): undefined reference to `gen_pool_avail'
drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_ctlr_create':
(.text+0x19f8): undefined reference to `devm_gen_pool_create'
(.text+0x1a90): undefined reference to `gen_pool_add_virt'
Makefile:1011: recipe for target 'vmlinux' failed
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
drivers/net/ethernet/ti/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig
index 9263d63..f932923 100644
--- a/drivers/net/ethernet/ti/Kconfig
+++ b/drivers/net/ethernet/ti/Kconfig
@@ -41,6 +41,7 @@ config TI_DAVINCI_MDIO
config TI_DAVINCI_CPDMA
tristate "TI DaVinci CPDMA Support"
depends on ARCH_DAVINCI || ARCH_OMAP2PLUS || COMPILE_TEST
+ select GENERIC_ALLOCATOR
---help---
This driver supports TI's DaVinci CPDMA dma engine.
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: ethernet: ti: add missing GENERIC_ALLOCATOR dependency
2018-09-14 11:20 [PATCH] net: ethernet: ti: add missing GENERIC_ALLOCATOR dependency Corentin Labbe
@ 2018-09-17 14:49 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-09-17 14:49 UTC (permalink / raw)
To: clabbe; +Cc: linux-kernel, netdev
From: Corentin Labbe <clabbe@baylibre.com>
Date: Fri, 14 Sep 2018 11:20:07 +0000
> This patch mades TI_DAVINCI_CPDMA select GENERIC_ALLOCATOR.
> without that, the following sparc64 build failure happen
>
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_check_free_tx_desc':
> (.text+0x278): undefined reference to `gen_pool_avail'
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_chan_submit':
> (.text+0x340): undefined reference to `gen_pool_alloc'
> (.text+0x5c4): undefined reference to `gen_pool_free'
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `__cpdma_chan_free':
> davinci_cpdma.c:(.text+0x64c): undefined reference to `gen_pool_free'
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_desc_pool_destroy.isra.6':
> davinci_cpdma.c:(.text+0x17ac): undefined reference to `gen_pool_size'
> davinci_cpdma.c:(.text+0x17b8): undefined reference to `gen_pool_avail'
> davinci_cpdma.c:(.text+0x1824): undefined reference to `gen_pool_size'
> davinci_cpdma.c:(.text+0x1830): undefined reference to `gen_pool_avail'
> drivers/net/ethernet/ti/davinci_cpdma.o: In function `cpdma_ctlr_create':
> (.text+0x19f8): undefined reference to `devm_gen_pool_create'
> (.text+0x1a90): undefined reference to `gen_pool_add_virt'
> Makefile:1011: recipe for target 'vmlinux' failed
>
> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-17 14:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-14 11:20 [PATCH] net: ethernet: ti: add missing GENERIC_ALLOCATOR dependency Corentin Labbe
2018-09-17 14:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).