* [PATCH] mips: delete duplication of BUILTIN_DTB selection
@ 2018-10-03 17:23 Maksym Kokhan
2018-10-04 8:36 ` Sergei Shtylyov
0 siblings, 1 reply; 6+ messages in thread
From: Maksym Kokhan @ 2018-10-03 17:23 UTC (permalink / raw)
To: Ralf Baechle, Paul Burton, James Hogan
Cc: Andrii Bordunov, linux-mips, linux-kernel
CONFIG_BUILTIN_DTB selection is duplicated in menu
"Machine selection" under MIPS_MALTA.
Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
Signed-off-by: Andrii Bordunov <andrew.bordunov@gmail.com>
---
arch/mips/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 3551199..71d6549 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -539,7 +539,6 @@ config MIPS_MALTA
select USE_OF
select LIBFDT
select ZONE_DMA32 if 64BIT
- select BUILTIN_DTB
select LIBFDT
help
This enables support for the MIPS Technologies Malta evaluation
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection
2018-10-03 17:23 [PATCH] mips: delete duplication of BUILTIN_DTB selection Maksym Kokhan
@ 2018-10-04 8:36 ` Sergei Shtylyov
2018-10-04 9:14 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: Sergei Shtylyov @ 2018-10-04 8:36 UTC (permalink / raw)
To: Maksym Kokhan, Ralf Baechle, Paul Burton, James Hogan
Cc: Andrii Bordunov, linux-mips, linux-kernel
Hello!
On 10/3/2018 8:23 PM, Maksym Kokhan wrote:
> CONFIG_BUILTIN_DTB selection is duplicated in menu
> "Machine selection" under MIPS_MALTA.
>
> Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
> Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
> Signed-off-by: Andrii Bordunov <andrew.bordunov@gmail.com>
> ---
> arch/mips/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 3551199..71d6549 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -539,7 +539,6 @@ config MIPS_MALTA
> select USE_OF
> select LIBFDT
> select ZONE_DMA32 if 64BIT
> - select BUILTIN_DTB
> select LIBFDT
LIBFDT seems duplicated too.
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection
2018-10-04 8:36 ` Sergei Shtylyov
@ 2018-10-04 9:14 ` Geert Uytterhoeven
2018-10-04 12:06 ` Maksym Kokhan
0 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2018-10-04 9:14 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: maksym.kokhan, Ralf Baechle, Paul Burton, James Hogan,
andrew.bordunov, Linux MIPS Mailing List,
Linux Kernel Mailing List
On Thu, Oct 4, 2018 at 10:38 AM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> On 10/3/2018 8:23 PM, Maksym Kokhan wrote:
> > CONFIG_BUILTIN_DTB selection is duplicated in menu
> > "Machine selection" under MIPS_MALTA.
> >
> > Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
> > Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
> > Signed-off-by: Andrii Bordunov <andrew.bordunov@gmail.com>
> > ---
> > arch/mips/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > index 3551199..71d6549 100644
> > --- a/arch/mips/Kconfig
> > +++ b/arch/mips/Kconfig
> > @@ -539,7 +539,6 @@ config MIPS_MALTA
> > select USE_OF
> > select LIBFDT
> > select ZONE_DMA32 if 64BIT
> > - select BUILTIN_DTB
> > select LIBFDT
>
> LIBFDT seems duplicated too.
Using random sort order doesn't help. Keep them sorted, please?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection
2018-10-04 9:14 ` Geert Uytterhoeven
@ 2018-10-04 12:06 ` Maksym Kokhan
2018-11-06 15:29 ` Maksym Kokhan
0 siblings, 1 reply; 6+ messages in thread
From: Maksym Kokhan @ 2018-10-04 12:06 UTC (permalink / raw)
To: geert
Cc: sergei.shtylyov, Ralf Baechle, Paul Burton, James Hogan,
Andrii Bordunov, linux-mips, linux-kernel
On Thu, Oct 4, 2018 at 12:14 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> On Thu, Oct 4, 2018 at 10:38 AM Sergei Shtylyov
> <sergei.shtylyov@cogentembedded.com> wrote:
> > On 10/3/2018 8:23 PM, Maksym Kokhan wrote:
> > > CONFIG_BUILTIN_DTB selection is duplicated in menu
> > > "Machine selection" under MIPS_MALTA.
> > >
> > > Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
> > > Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
> > > Signed-off-by: Andrii Bordunov <andrew.bordunov@gmail.com>
> > > ---
> > > arch/mips/Kconfig | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > > index 3551199..71d6549 100644
> > > --- a/arch/mips/Kconfig
> > > +++ b/arch/mips/Kconfig
> > > @@ -539,7 +539,6 @@ config MIPS_MALTA
> > > select USE_OF
> > > select LIBFDT
> > > select ZONE_DMA32 if 64BIT
> > > - select BUILTIN_DTB
> > > select LIBFDT
> >
> > LIBFDT seems duplicated too.
>
> Using random sort order doesn't help. Keep them sorted, please?
We are going to deal with it in the separate patch.
---
Regards,
Maksym Kokhan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection
2018-10-04 12:06 ` Maksym Kokhan
@ 2018-11-06 15:29 ` Maksym Kokhan
2018-11-08 18:30 ` Paul Burton
0 siblings, 1 reply; 6+ messages in thread
From: Maksym Kokhan @ 2018-11-06 15:29 UTC (permalink / raw)
To: geert
Cc: sergei.shtylyov, Ralf Baechle, Paul Burton, James Hogan,
Andrii Bordunov, linux-mips, linux-kernel
On Thu, Oct 4, 2018 at 3:06 PM Maksym Kokhan
<maksym.kokhan@globallogic.com> wrote:
>
> On Thu, Oct 4, 2018 at 12:14 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > On Thu, Oct 4, 2018 at 10:38 AM Sergei Shtylyov
> > <sergei.shtylyov@cogentembedded.com> wrote:
> > > On 10/3/2018 8:23 PM, Maksym Kokhan wrote:
> > > > CONFIG_BUILTIN_DTB selection is duplicated in menu
> > > > "Machine selection" under MIPS_MALTA.
> > > >
> > > > Fixes: e81a8c7dabac ("MIPS: Malta: Setup RAM regions via DT")
> > > > Signed-off-by: Maksym Kokhan <maksym.kokhan@globallogic.com>
> > > > Signed-off-by: Andrii Bordunov <andrew.bordunov@gmail.com>
> > > > ---
> > > > arch/mips/Kconfig | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > > > index 3551199..71d6549 100644
> > > > --- a/arch/mips/Kconfig
> > > > +++ b/arch/mips/Kconfig
> > > > @@ -539,7 +539,6 @@ config MIPS_MALTA
> > > > select USE_OF
> > > > select LIBFDT
> > > > select ZONE_DMA32 if 64BIT
> > > > - select BUILTIN_DTB
> > > > select LIBFDT
> > >
> > > LIBFDT seems duplicated too.
> >
> > Using random sort order doesn't help. Keep them sorted, please?
>
> We are going to deal with it in the separate patch.
Is it OK to leave this patch as it is and make another patch/patches
for other changes or it would be better to modify it to remove
duplication of LIBFDT too and sort this list of configs?
--
Regards,
Maksym Kokhan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mips: delete duplication of BUILTIN_DTB selection
2018-11-06 15:29 ` Maksym Kokhan
@ 2018-11-08 18:30 ` Paul Burton
0 siblings, 0 replies; 6+ messages in thread
From: Paul Burton @ 2018-11-08 18:30 UTC (permalink / raw)
To: Maksym Kokhan
Cc: geert, sergei.shtylyov, Ralf Baechle, James Hogan,
Andrii Bordunov, linux-mips, linux-kernel
Hi Maksym,
On Tue, Nov 06, 2018 at 05:29:40PM +0200, Maksym Kokhan wrote:
> > > > > diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> > > > > index 3551199..71d6549 100644
> > > > > --- a/arch/mips/Kconfig
> > > > > +++ b/arch/mips/Kconfig
> > > > > @@ -539,7 +539,6 @@ config MIPS_MALTA
> > > > > select USE_OF
> > > > > select LIBFDT
> > > > > select ZONE_DMA32 if 64BIT
> > > > > - select BUILTIN_DTB
> > > > > select LIBFDT
> > > >
> > > > LIBFDT seems duplicated too.
> > >
> > > Using random sort order doesn't help. Keep them sorted, please?
> >
> > We are going to deal with it in the separate patch.
>
> Is it OK to leave this patch as it is and make another patch/patches
> for other changes or it would be better to modify it to remove
> duplication of LIBFDT too and sort this list of configs?
My preference would be that you remove all the duplicates as one patch,
then sort the selects alphabetically in a second patch. That should be
granular enough to make it easy to review, but not so fine-grained that
it becomes annoying.
Thanks,
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-08 18:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-03 17:23 [PATCH] mips: delete duplication of BUILTIN_DTB selection Maksym Kokhan
2018-10-04 8:36 ` Sergei Shtylyov
2018-10-04 9:14 ` Geert Uytterhoeven
2018-10-04 12:06 ` Maksym Kokhan
2018-11-06 15:29 ` Maksym Kokhan
2018-11-08 18:30 ` Paul Burton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).