* [PATCHv2] btrfs: list usage cleanup
@ 2018-10-04 4:48 zhong jiang
2018-10-04 10:02 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: zhong jiang @ 2018-10-04 4:48 UTC (permalink / raw)
To: dsterba; +Cc: osandov, dsterba, jbacik, clm, linux-btrfs, linux-kernel
Trival cleanup, list_move_tail will implement the same function that
list_del() + list_add_tail() will do. hence just replace them.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
fs/btrfs/send.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index 094cc144..30e7e12 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -2075,8 +2075,8 @@ static struct name_cache_entry *name_cache_search(struct send_ctx *sctx,
*/
static void name_cache_used(struct send_ctx *sctx, struct name_cache_entry *nce)
{
- list_del(&nce->list);
- list_add_tail(&nce->list, &sctx->name_cache_list);
+ /* delete from sctx->name_cache_list and add as its tail */
+ list_move_tail(&nce->list, &sctx->name_cache_list);
}
/*
--
1.7.12.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv2] btrfs: list usage cleanup
2018-10-04 4:48 [PATCHv2] btrfs: list usage cleanup zhong jiang
@ 2018-10-04 10:02 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2018-10-04 10:02 UTC (permalink / raw)
To: zhong jiang
Cc: dsterba, osandov, dsterba, jbacik, clm, linux-btrfs, linux-kernel
On Thu, Oct 04, 2018 at 12:48:27PM +0800, zhong jiang wrote:
> Trival cleanup, list_move_tail will implement the same function that
> list_del() + list_add_tail() will do. hence just replace them.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> fs/btrfs/send.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
> index 094cc144..30e7e12 100644
> --- a/fs/btrfs/send.c
> +++ b/fs/btrfs/send.c
> @@ -2075,8 +2075,8 @@ static struct name_cache_entry *name_cache_search(struct send_ctx *sctx,
> */
> static void name_cache_used(struct send_ctx *sctx, struct name_cache_entry *nce)
> {
> - list_del(&nce->list);
> - list_add_tail(&nce->list, &sctx->name_cache_list);
> + /* delete from sctx->name_cache_list and add as its tail */
> + list_move_tail(&nce->list, &sctx->name_cache_list);
The suggestion was to drop name_cache_used and replace it with
list_move_tail(...), the comment as you wrote it does not bring much
information as it merely repeats how list_move_tail is implemeted. A
useful comment explains something that's not obvious.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-04 10:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-04 4:48 [PATCHv2] btrfs: list usage cleanup zhong jiang
2018-10-04 10:02 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).