* [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller
@ 2018-11-01 19:58 Carmeli Tamir
2018-11-07 11:29 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Carmeli Tamir @ 2018-11-01 19:58 UTC (permalink / raw)
To: gregkh, devel, linux-kernel
Cc: areklis909, natechancellor, dan.carpenter, chrisadr, Carmeli Tamir
Added static modifier to the udc_controller, since it's only
required within emxx_udc.c.
Previously posted without any feedback, now updated according to master.
Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 3e51476..94a4327 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -56,7 +56,7 @@ static void _nbu2ss_fifo_flush(struct nbu2ss_udc *, struct nbu2ss_ep *);
/*===========================================================================*/
/* Global */
-struct nbu2ss_udc udc_controller;
+static struct nbu2ss_udc udc_controller;
/*-------------------------------------------------------------------------*/
/* Read */
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller
2018-11-01 19:58 [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller Carmeli Tamir
@ 2018-11-07 11:29 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2018-11-07 11:29 UTC (permalink / raw)
To: Carmeli Tamir
Cc: devel, linux-kernel, areklis909, chrisadr, natechancellor, dan.carpenter
On Thu, Nov 01, 2018 at 03:58:57PM -0400, Carmeli Tamir wrote:
> Added static modifier to the udc_controller, since it's only
> required within emxx_udc.c.
> Previously posted without any feedback, now updated according to master.
>
> Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
I do not see patch 3/3 in this series.
Can you resend the whole series, properly threaded, so that I know what
to apply? I think you send this one already and I have no idea what to
do here, sorry.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller
2018-11-07 20:44 ` [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller Carmeli Tamir
@ 2018-11-12 9:42 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2018-11-12 9:42 UTC (permalink / raw)
To: carmeli.tamir
Cc: Greg KH, Nathan Chancellor, chrisadr, areklis909, Dan Carpenter,
driverdevel, Linux Kernel Mailing List, Magnus Damm,
Linux-Renesas
Hi Carmeli,
CC Magnus
(staging drivers receive so may janitorial changes that the original author is
lost in the git shortlog noise)
On Wed, Nov 7, 2018 at 9:46 PM Carmeli Tamir <carmeli.tamir@gmail.com> wrote:
> Added static modifier to the udc_controller, since it's only
> required within emxx_udc.c.
>
> Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com>
Thanks for your patch!
> --- a/drivers/staging/emxx_udc/emxx_udc.c
> +++ b/drivers/staging/emxx_udc/emxx_udc.c
> @@ -56,7 +56,7 @@ static void _nbu2ss_fifo_flush(struct nbu2ss_udc *, struct nbu2ss_ep *);
>
> /*===========================================================================*/
> /* Global */
> -struct nbu2ss_udc udc_controller;
> +static struct nbu2ss_udc udc_controller;
What about the "Global" comment?
Perhaps this was intentional?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller
2018-11-07 20:44 [PATCH 0/3] staging: emxx_udc: Fixed all meaningful sparse warnings Carmeli Tamir
@ 2018-11-07 20:44 ` Carmeli Tamir
2018-11-12 9:42 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Carmeli Tamir @ 2018-11-07 20:44 UTC (permalink / raw)
To: carmeli.tamir, gregkh, natechancellor, chrisadr, areklis909,
dan.carpenter, devel, linux-kernel
Added static modifier to the udc_controller, since it's only
required within emxx_udc.c.
Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 65cc3d9..f49c863 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -56,7 +56,7 @@ static void _nbu2ss_fifo_flush(struct nbu2ss_udc *, struct nbu2ss_ep *);
/*===========================================================================*/
/* Global */
-struct nbu2ss_udc udc_controller;
+static struct nbu2ss_udc udc_controller;
/*-------------------------------------------------------------------------*/
/* Read */
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller
@ 2018-10-17 21:01 Carmeli Tamir
0 siblings, 0 replies; 5+ messages in thread
From: Carmeli Tamir @ 2018-10-17 21:01 UTC (permalink / raw)
To: gregkh, dan.carpenter, chrisadr; +Cc: carmeli.tamir, devel, linux-kernel
Added static modifier to the udc_controller, since it's only
required within emxx_udc.c.
Signed-off-by: Carmeli Tamir <carmeli.tamir@gmail.com>
---
drivers/staging/emxx_udc/emxx_udc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c b/drivers/staging/emxx_udc/emxx_udc.c
index 3e51476..94a4327 100644
--- a/drivers/staging/emxx_udc/emxx_udc.c
+++ b/drivers/staging/emxx_udc/emxx_udc.c
@@ -56,7 +56,7 @@ static void _nbu2ss_fifo_flush(struct nbu2ss_udc *, struct nbu2ss_ep *);
/*===========================================================================*/
/* Global */
-struct nbu2ss_udc udc_controller;
+static struct nbu2ss_udc udc_controller;
/*-------------------------------------------------------------------------*/
/* Read */
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-11-12 9:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 19:58 [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller Carmeli Tamir
2018-11-07 11:29 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2018-11-07 20:44 [PATCH 0/3] staging: emxx_udc: Fixed all meaningful sparse warnings Carmeli Tamir
2018-11-07 20:44 ` [PATCH 1/3] staging: emxx_udc: Added static modifier to udc_controller Carmeli Tamir
2018-11-12 9:42 ` Geert Uytterhoeven
2018-10-17 21:01 Carmeli Tamir
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).