* [PATCH] clk: fixed-factor: fix of_node_get-put imbalance
@ 2018-11-01 13:15 Ricardo Ribalda Delgado
2018-11-01 23:54 ` Stephen Boyd
2018-11-06 16:28 ` Stephen Boyd
0 siblings, 2 replies; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2018-11-01 13:15 UTC (permalink / raw)
To: Michael Turquette, Alan Tull, Stephen Boyd, linux-clk, linux-kernel
Cc: Ricardo Ribalda Delgado
When the fixed factor clock is created by devicetree,
of_clk_add_provider is called. Add a call to
of_clk_del_provider in the remove function to balance
it out.
Reported-by: Alan Tull <atull@kernel.org>
Fixes: 971451b3b15d ("clk: fixed-factor: Convert into a module platform driver")
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
drivers/clk/clk-fixed-factor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
index 20724abd38bd..7df6b5b1e7ee 100644
--- a/drivers/clk/clk-fixed-factor.c
+++ b/drivers/clk/clk-fixed-factor.c
@@ -210,6 +210,7 @@ static int of_fixed_factor_clk_remove(struct platform_device *pdev)
{
struct clk *clk = platform_get_drvdata(pdev);
+ of_clk_del_provider(pdev->dev.of_node);
clk_unregister_fixed_factor(clk);
return 0;
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: fixed-factor: fix of_node_get-put imbalance
2018-11-01 13:15 [PATCH] clk: fixed-factor: fix of_node_get-put imbalance Ricardo Ribalda Delgado
@ 2018-11-01 23:54 ` Stephen Boyd
2018-11-06 16:28 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2018-11-01 23:54 UTC (permalink / raw)
To: Alan Tull, Michael Turquette, Ricardo Ribalda Delgado, linux-clk,
linux-kernel
Cc: Ricardo Ribalda Delgado
Quoting Ricardo Ribalda Delgado (2018-11-01 06:15:49)
> When the fixed factor clock is created by devicetree,
> of_clk_add_provider is called. Add a call to
> of_clk_del_provider in the remove function to balance
> it out.
>
> Reported-by: Alan Tull <atull@kernel.org>
> Fixes: 971451b3b15d ("clk: fixed-factor: Convert into a module platform driver")
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
Looks good. I'll queue this up for clk-fixes next week.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: fixed-factor: fix of_node_get-put imbalance
2018-11-01 13:15 [PATCH] clk: fixed-factor: fix of_node_get-put imbalance Ricardo Ribalda Delgado
2018-11-01 23:54 ` Stephen Boyd
@ 2018-11-06 16:28 ` Stephen Boyd
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2018-11-06 16:28 UTC (permalink / raw)
To: Alan Tull, Michael Turquette, Ricardo Ribalda Delgado, linux-clk,
linux-kernel
Cc: Ricardo Ribalda Delgado
Quoting Ricardo Ribalda Delgado (2018-11-01 06:15:49)
> When the fixed factor clock is created by devicetree,
> of_clk_add_provider is called. Add a call to
> of_clk_del_provider in the remove function to balance
> it out.
>
> Reported-by: Alan Tull <atull@kernel.org>
> Fixes: 971451b3b15d ("clk: fixed-factor: Convert into a module platform driver")
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
Applied to clk-fixes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-06 16:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-01 13:15 [PATCH] clk: fixed-factor: fix of_node_get-put imbalance Ricardo Ribalda Delgado
2018-11-01 23:54 ` Stephen Boyd
2018-11-06 16:28 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).