[PATCH] clk: fixed-factor: fix of_node_get-put imbalance

* [PATCH] clk: fixed-factor: fix of_node_get-put imbalance
@ 2018-11-01 13:15 Ricardo Ribalda Delgado
  2018-11-01 23:54 ` Stephen Boyd
  2018-11-06 16:28 ` Stephen Boyd
  0 siblings, 2 replies; 3+ messages in thread
From: Ricardo Ribalda Delgado @ 2018-11-01 13:15 UTC (permalink / raw)
  To: Michael Turquette, Alan Tull, Stephen Boyd, linux-clk, linux-kernel
  Cc: Ricardo Ribalda Delgado

When the fixed factor clock is created by devicetree,
of_clk_add_provider is called.  Add a call to
of_clk_del_provider in the remove function to balance
it out.

Reported-by: Alan Tull <atull@kernel.org>
Fixes: 971451b3b15d ("clk: fixed-factor: Convert into a module platform driver")
Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
---
 drivers/clk/clk-fixed-factor.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/clk/clk-fixed-factor.c b/drivers/clk/clk-fixed-factor.c
index 20724abd38bd..7df6b5b1e7ee 100644
--- a/drivers/clk/clk-fixed-factor.c
+++ b/drivers/clk/clk-fixed-factor.c
@@ -210,6 +210,7 @@ static int of_fixed_factor_clk_remove(struct platform_device *pdev)
 {
 	struct clk *clk = platform_get_drvdata(pdev);
 
+	of_clk_del_provider(pdev->dev.of_node);
 	clk_unregister_fixed_factor(clk);
 
 	return 0;
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread