From: Wei Ni <wni@nvidia.com>
To: <thierry.reding@gmail.com>, <daniel.lezcano@linaro.org>,
<linux-tegra@vger.kernel.org>
Cc: <rui.zhang@intel.com>, <edubezval@gmail.com>,
<linux-kernel@vger.kernel.org>, Wei Ni <wni@nvidia.com>
Subject: [PATCH v1 1/4] thermal: tegra: continue if sensor register fails
Date: Mon, 5 Nov 2018 17:32:31 +0800 [thread overview]
Message-ID: <1541410354-19090-2-git-send-email-wni@nvidia.com> (raw)
In-Reply-To: <1541410354-19090-1-git-send-email-wni@nvidia.com>
Don't bail when a sensor fails to register with the
thermal zone and allow other sensors to register.
This allows other sensors to register with thermal
framework even if one sensor fails registration.
Signed-off-by: Wei Ni <wni@nvidia.com>
---
drivers/thermal/tegra/soctherm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
index ed28110a3535..b708300303ff 100644
--- a/drivers/thermal/tegra/soctherm.c
+++ b/drivers/thermal/tegra/soctherm.c
@@ -1370,9 +1370,9 @@ static int tegra_soctherm_probe(struct platform_device *pdev)
&tegra_of_thermal_ops);
if (IS_ERR(z)) {
err = PTR_ERR(z);
- dev_err(&pdev->dev, "failed to register sensor: %d\n",
+ dev_warn(&pdev->dev, "failed to register sensor: %d\n",
err);
- goto disable_clocks;
+ continue;
}
zone->tz = z;
@@ -1434,6 +1434,8 @@ static int __maybe_unused soctherm_resume(struct device *dev)
struct thermal_zone_device *tz;
tz = tegra->thermctl_tzs[soc->ttgs[i]->id];
+ if (!tz)
+ continue;
err = tegra_soctherm_set_hwtrips(dev, soc->ttgs[i], tz);
if (err) {
dev_err(&pdev->dev,
--
2.7.4
next prev parent reply other threads:[~2018-11-05 9:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 9:32 [PATCH v1 0/4] Fixes for Tegra soctherm Wei Ni
2018-11-05 9:32 ` Wei Ni [this message]
2018-11-08 12:48 ` [PATCH v1 1/4] thermal: tegra: continue if sensor register fails Thierry Reding
2018-11-05 9:32 ` [PATCH v1 2/4] thermal: tegra: remove unnecessary warnings Wei Ni
2018-11-08 12:47 ` Thierry Reding
2018-11-09 7:21 ` Wei Ni
2018-11-05 9:32 ` [PATCH v1 3/4] thermal: tegra: fix memory allocation Wei Ni
2018-11-08 12:37 ` Thierry Reding
2018-11-05 9:32 ` [PATCH v1 4/4] thermal: tegra: fix coverity defect Wei Ni
2018-11-08 12:37 ` Thierry Reding
2018-11-09 6:44 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541410354-19090-2-git-send-email-wni@nvidia.com \
--to=wni@nvidia.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).