From: Wei Ni <wni@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: <daniel.lezcano@linaro.org>, <linux-tegra@vger.kernel.org>,
<rui.zhang@intel.com>, <edubezval@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 2/4] thermal: tegra: remove unnecessary warnings
Date: Fri, 9 Nov 2018 15:21:23 +0800 [thread overview]
Message-ID: <ec9e034a-2789-2433-aad7-8d493d2d67c8@nvidia.com> (raw)
In-Reply-To: <20181108124716.GE1340@ulmo>
On 8/11/2018 8:47 PM, Thierry Reding wrote:
> On Mon, Nov 05, 2018 at 05:32:32PM +0800, Wei Ni wrote:
>> Convert warnings to info as not all platforms may
>> have all the thresholds and sensors enabled.
>>
>> Signed-off-by: Wei Ni <wni@nvidia.com>
>> ---
>> drivers/thermal/tegra/soctherm.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> This seems overly generalized to me. Shouldn't we be checking in a more
> fine-grained way for the absence of thresholds and/or sensors?
>
> Otherwise, how are going to make the difference between the sensor not
> being enabled or the device tree just missing the information?
>
The sensor being enabled or not is controlled by device tree, if the dts
have the corresponding nodes, then the sensors should be enabled. And
the thresholds for sensor are not necessary, so I think we just need to
print out them.
BTW, in my patch 1/4, I should print out the sensor name if the sensor
not enabled and register failed.
Will update it.
> Thierry
>
next prev parent reply other threads:[~2018-11-09 7:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 9:32 [PATCH v1 0/4] Fixes for Tegra soctherm Wei Ni
2018-11-05 9:32 ` [PATCH v1 1/4] thermal: tegra: continue if sensor register fails Wei Ni
2018-11-08 12:48 ` Thierry Reding
2018-11-05 9:32 ` [PATCH v1 2/4] thermal: tegra: remove unnecessary warnings Wei Ni
2018-11-08 12:47 ` Thierry Reding
2018-11-09 7:21 ` Wei Ni [this message]
2018-11-05 9:32 ` [PATCH v1 3/4] thermal: tegra: fix memory allocation Wei Ni
2018-11-08 12:37 ` Thierry Reding
2018-11-05 9:32 ` [PATCH v1 4/4] thermal: tegra: fix coverity defect Wei Ni
2018-11-08 12:37 ` Thierry Reding
2018-11-09 6:44 ` Wei Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec9e034a-2789-2433-aad7-8d493d2d67c8@nvidia.com \
--to=wni@nvidia.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).